This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Fix verbose printing of rows added via DW_LNE_end_sequence
ClosedPublic

Authored by jhenderson on Dec 18 2019, 8:15 AM.

Details

Summary

The debug line verbose printing was printing the wrong values for rows added via DW_LNE_end_sequence, because the row was being printed AFTER its state had been reset following it being appended to the line table. This patch fixes this issue by printing the row before appending it.

Diff Detail

Event Timeline

jhenderson created this revision.Dec 18 2019, 8:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2019, 8:15 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
dblaikie accepted this revision.Dec 18 2019, 12:41 PM

Looks good - thanks!

This revision is now accepted and ready to land.Dec 18 2019, 12:41 PM
MaskRay accepted this revision.Dec 18 2019, 2:29 PM

appendRowToMatrix after dumping looks good (D60364 made a similar change to DW_LNS_copy).

llvm/test/tools/llvm-dwarfdump/X86/debug-line-dw-lne-end-sequence.s
4

We may delete -pc-linux
This is not specific to Linux.

This revision was automatically updated to reflect the committed changes.
jhenderson marked an inline comment as done.