This is an archive of the discontinued LLVM Phabricator instance.

[FPEnv] Strict versions of llvm.minimum/llvm.maximum
ClosedPublic

Authored by uweigand on Dec 17 2019, 1:05 PM.

Details

Summary

Add new intrinsics llvm.experimental.constrained.minimum and llvm.experimental.constrained.maximum as strict versions of llvm.minimum and llvm.maximum. Includes SystemZ back-end support.

Diff Detail

Event Timeline

uweigand created this revision.Dec 17 2019, 1:05 PM
craig.topper added inline comments.Dec 17 2019, 3:44 PM
llvm/docs/LangRef.rst
16596

Should this refer to 754-2019 now?

uweigand marked an inline comment as done.Dec 17 2019, 11:21 PM
uweigand added inline comments.
llvm/docs/LangRef.rst
16596

Well, I just copied the current wording from llvm.minimum. I guess we should use 754-2019 now; it looks like this was discussed in D67507 but the patch wasn't applied for some reasons ...

kpn added inline comments.Dec 18 2019, 9:22 AM
llvm/include/llvm/IR/ConstrainedOps.def
74

Adding this file has made new intrinsics so much easier. I'm almost irritated at how easy this was.

craig.topper accepted this revision.Dec 18 2019, 11:09 AM

LGTM We can take the IEEE 754-2019 up as a separate issue.

This revision is now accepted and ready to land.Dec 18 2019, 11:09 AM
This revision was automatically updated to reflect the committed changes.