... I think this is right?
Add support in the switch statement for addr spaces. I couldn't get a magical API combination to get just the address space off the top of my head, but wanted to get this out.
Differential D71486
[clang-tools-extra] Fix switch coverage warning echristo on Dec 13 2019, 12:22 PM. Authored by
Details ... I think this is right? Add support in the switch statement for addr spaces. I couldn't get a magical API combination to get just the address space off the top of my head, but wanted to get this out.
Diff Detail
Event TimelineComment Actions Unit tests: pass. 60867 tests passed, 0 failed and 726 were skipped. clang-format: pass. Build artifacts: console-log.txt, CMakeCache.txt, test-results.xml, diff.json Comment Actions It should be possible to test this by adapting a test case from the original ed8dadb, but I'm not certain...
Comment Actions This concern was not addressed/answered. The commit https://reviews.llvm.org/rG5623bd52acd34db2e9cfc11d1510407610a14db0 claims that this was reviewed by rsmith, but I don't see rsmith's LGTM here.. |
Not very familiar with this code, but it looks like this is feeding the arg back into a builder, and ed8dadb added support for sending LangAS itself to the builder.
So I don't think we should stringify it, but just send the LangAS