This patch supports loop ds form prep for PPC instruction lwa.
Details
Details
- Reviewers
jsji nemanjai steven.zhang hfinkel - Group Reviewers
Restricted Project - Commits
- rGf5440ec41d8e: [PowerPC] make lwa as a valid ds candidate in ppcloopinstrformprep pass
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Other than the minor nit about readability, LGTM.
llvm/lib/Target/PowerPC/PPCLoopInstrFormPrep.cpp | ||
---|---|---|
848–849 | This expression is quite unwieldy. The repeated calls to PtrValue->getType()->getPointerElementType() just look a bit messy. It would make sense to define a local variable to simplify this condition. |
llvm/lib/Target/PowerPC/PPCLoopInstrFormPrep.cpp | ||
---|---|---|
848–849 | will do this in commit patch. |
This expression is quite unwieldy. The repeated calls to PtrValue->getType()->getPointerElementType() just look a bit messy. It would make sense to define a local variable to simplify this condition.