Initial patch for new rendering structs in clangd.
Splitting implementation into smaller chunks, for a full view of the API see D71063.
Differential D71248
[clangd] Introduce paragraph, the first part of new rendering structs kadircet on Dec 10 2019, 3:21 AM. Authored by
Details Initial patch for new rendering structs in clangd. Splitting implementation into smaller chunks, for a full view of the API see D71063.
Diff Detail
Unit Tests
Event TimelineComment Actions Build result: pass - 60655 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt, CMakeCache.txt Comment Actions Build result: pass - 60655 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt, CMakeCache.txt Comment Actions Main thing here is I'm fairly sure that code blocks shouldn't be chunks in a paragraph (or I'm misunderstanding what a paragraph is)
Comment Actions
Comment Actions Unit tests: pass. 60655 tests passed, 0 failed and 726 were skipped. clang-format: pass. Build artifacts: console-log.txt, CMakeCache.txt, test-results.xml, diff.json Comment Actions Unit tests: pass. 60657 tests passed, 0 failed and 726 were skipped. clang-format: pass. Build artifacts: console-log.txt, CMakeCache.txt, test-results.xml, diff.json Comment Actions Design question around newlines :-) Otherwise looks good.
Comment Actions
Comment Actions Unit tests: fail. 60762 tests passed, 1 failed and 726 were skipped. failed: Clang.CodeGenCXX/runtime-dllstorage.cpp clang-format: pass. Build artifacts: console-log.txt, CMakeCache.txt, test-results.xml, diff.json
Comment Actions
Comment Actions Unit tests: pass. 60763 tests passed, 0 failed and 726 were skipped. clang-format: pass. Build artifacts: console-log.txt, CMakeCache.txt, test-results.xml, diff.json
|
I don't think this comment captures what this class is about now. (Rewriting the class but leaving the comment intact is suspicious!)
Comment should allude to how blocks make up a document - a RenderableBlock holds rich text and knows how to lay it out. Blocks can be stacked to form a document, etc.