This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SILoadStoreOptimillzer: Refactor CombineInfo struct
ClosedPublic

Authored by tstellar on Dec 4 2019, 9:03 PM.

Details

Summary

Modify CombineInfo to only store information about a single instruction.
This is a little easier to work with and removes a lot of duplicate
initialization code.

Diff Detail

Event Timeline

tstellar created this revision.Dec 4 2019, 9:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 4 2019, 9:03 PM

Build result: FAILURE - Could not check out parent git hash "ff0aa61d9fd9c8551c31d03de0aa86841cbb2110". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead...

ERROR: arc patch failed with error code 1. Check build log for details.
Log files: console-log.txt, CMakeCache.txt

arsenm accepted this revision.Dec 5 2019, 12:54 AM

LGTM

llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
1199–1201

std::tie, although this was already like this

This revision is now accepted and ready to land.Dec 5 2019, 12:54 AM
nhaehnle accepted this revision.Dec 8 2019, 9:54 AM

Thanks for doing this, LGTM.

This revision was automatically updated to reflect the committed changes.