Page MenuHomePhabricator

[ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.
ClosedPublic

Authored by MarkMurrayARM on Dec 3 2019, 2:47 AM.

Details

Summary

Add MVE VMULH/VRMULH intrinsics and unit tests.

Diff Detail

Event Timeline

MarkMurrayARM created this revision.Dec 3 2019, 2:47 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 3 2019, 2:47 AM

Looks good to me, with a couple of minor nitpicks (that I'm not sure matter or not).

llvm/lib/Target/ARM/ARMInstrMVE.td
3625–3626

Any strong reason to switch these around? From what I can tell most of the patterns are (suffix, unsigned, size) in that order. Although that doesn't seem to be universal. Might as well try to keep it consistent, if you do not have a reason to swap them.

3644

Formatting.

Address review comments.

MarkMurrayARM marked 3 inline comments as done.Dec 4 2019, 5:09 AM
MarkMurrayARM added inline comments.
llvm/lib/Target/ARM/ARMInstrMVE.td
3644

I took a guess as to what you wanted here.

dmgreen added inline comments.Dec 4 2019, 5:15 AM
llvm/lib/Target/ARM/ARMInstrMVE.td
3665

Should this be VTI.Suffix, VTI.Unsigned, VTI.Size, round now?

MarkMurrayARM marked an inline comment as done.

Fix incorrect argument order error.

MarkMurrayARM marked an inline comment as done.Dec 4 2019, 5:21 AM
dmgreen accepted this revision.Dec 4 2019, 5:30 AM

LGTM. Thanks

This revision is now accepted and ready to land.Dec 4 2019, 5:30 AM
This revision was automatically updated to reflect the committed changes.