Add instrinics and patters for the following logical predicate instructions:
- and, ands, bic, bics, eor, eors
- sel
- orr, orrs, orn, orns, nor, nors, nand, nads
Paths
| Differential D70795
[AArch64][SVE] Add intrinsics and patterns for logical predicate instructions ClosedPublic Authored by dancgr on Nov 27 2019, 12:44 PM.
Details
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Nov 27 2019, 1:01 PM
dancgr added inline comments.
dancgr marked an inline comment as done. Comment Actions
Comment Actions
Revision Contents
Diff 232182 llvm/include/llvm/IR/IntrinsicsAArch64.td
llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
llvm/lib/Target/AArch64/SVEInstrFormats.td
llvm/test/CodeGen/AArch64/sve-int-log-pred.ll
llvm/test/CodeGen/AArch64/sve-int-log.ll
llvm/test/CodeGen/AArch64/sve-pred-log.ll
|
Is there a specific reason you're adding the _p? Most of the intrinsics that are predicated don't specify this, which kind of breaks with the convention with the other SVE intrinsics in this file. Note that we can represent an unpredicated and with existing selectiondag nodes so we wouldn't ever need an unpredicated int_aarch64_sve_and. It would be nice if you can change that for this and the other intrinsics before you commit the patch.