This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Remove confusing condition argument from else() NFC
ClosedPublic

Authored by tstellar on Nov 12 2019, 7:34 PM.

Reviewers

Commits

Summary

This makes it look like an elseif and also the variable referenced
in the condition was removed from this function in r366622.

Repository

rG LLVM Github Monorepo

Build Status

Buildable 40859
Build 40997: arc lint + arc unit

LGTM

This revision is now accepted and ready to land.Nov 13 2019, 11:21 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

cmake/

modules/

2 lines

Show First 20 Lines • Show All 262 Lines • ▼ Show 20 Lines	foreach(c ${link_components})
if( c STREQUAL "native" )		if( c STREQUAL "native" )
# already processed		# already processed
elseif( c STREQUAL "backend" )		elseif( c STREQUAL "backend" )
# same case as in `native'.		# same case as in `native'.
elseif( c STREQUAL "engine" )		elseif( c STREQUAL "engine" )
# already processed		# already processed
elseif( c STREQUAL "all" )		elseif( c STREQUAL "all" )
list(APPEND expanded_components ${LLVM_AVAILABLE_LIBS})		list(APPEND expanded_components ${LLVM_AVAILABLE_LIBS})
else( NOT idx LESS 0 )		else()
# Canonize the component name:		# Canonize the component name:
string(TOUPPER "${c}" capitalized)		string(TOUPPER "${c}" capitalized)
list(FIND capitalized_libs LLVM${capitalized} lib_idx)		list(FIND capitalized_libs LLVM${capitalized} lib_idx)
if( lib_idx LESS 0 )		if( lib_idx LESS 0 )
# The component is unknown. Maybe is an omitted target?		# The component is unknown. Maybe is an omitted target?
is_llvm_target_library(${c} iltl_result OMITTED_TARGETS)		is_llvm_target_library(${c} iltl_result OMITTED_TARGETS)
if(iltl_result)		if(iltl_result)
# A missing library to a directly referenced omitted target would be bad.		# A missing library to a directly referenced omitted target would be bad.
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines