Page MenuHomePhabricator

DWARFDebugLoclists: stricter base address handling
ClosedPublic

Authored by labath on Nov 12 2019, 2:50 AM.

Details

Summary

This removes the use of zero as a base address in section-based dumping.
Although this will often be true for (unlinked) object files with a
single compile unit, it is not true in general. This means that
section-based dumping will not be able to resolve entries referencing
the base address (DW_LLE_offset_pair) -- it wasn't able to do that
correctly before either, but now it will be more explicit about it. One
exception to that is if the location list contains an explicit
DW_LLE_base_address entry -- in this case the dumper will pick it up,
and resolve subsequent entries normally.

The patch also removes the fallback to zero in the "inline" dumping in
case the compile unit does not contain a base address.

Diff Detail

Event Timeline

labath created this revision.Nov 12 2019, 2:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2019, 2:50 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
This revision is now accepted and ready to land.Nov 12 2019, 9:21 AM
This revision was automatically updated to reflect the committed changes.