Page MenuHomePhabricator

Fix a regression in macOS-style path remapping.
ClosedPublic

Authored by aprantl on Fri, Nov 8, 5:40 PM.

Details

Summary

When we switched to the LLVM .debug_line parser, the .dSYM-style path remapping logic stopped working for relative paths because of how RemapSourceFile silently fails for relative paths. This patch both makes the code more readable and fixes this particular bug.

One interesting thing I learned is that Module::RemapSourceFile() is a macOS-only code path that operates on on the lldb::Module level and is completely separate from target.source-map, which operates on a per-Target level.

Diff Detail

Event Timeline

aprantl created this revision.Fri, Nov 8, 5:40 PM
JDevlieghere accepted this revision.Fri, Nov 8, 6:03 PM

Sorry for breaking this functionality & thank you for fixing it!

This revision is now accepted and ready to land.Fri, Nov 8, 6:03 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 11, 12:30 PM