Page MenuHomePhabricator

[llvm-xray] Add AArch64 to llvm-xray extract
ClosedPublic

Authored by ianlevesque on Nov 7 2019, 1:34 PM.

Details

Summary

This required adding support for resolving R_AARCH64_ABS64 relocations to
get accurate addresses for function names to resolve.

Diff Detail

Event Timeline

ianlevesque created this revision.Nov 7 2019, 1:34 PM
dberris accepted this revision.Nov 7 2019, 1:45 PM

LGTM

llvm/lib/XRay/InstrumentationMap.cpp
104

I'd suggest a different name here, maybe SupportsRelocation?

This revision is now accepted and ready to land.Nov 7 2019, 1:45 PM

rename Supports

ianlevesque marked an inline comment as done.Nov 7 2019, 1:52 PM

I don't have commit access, can someone land it?

This revision was automatically updated to reflect the committed changes.

It seems like the commit dropped the tests. I'm planning to re-add them, and try converting the binary to YAML in the process.

I converted the test to YAML and committed it as rG56cd447eec8e.