Page MenuHomePhabricator

tetsuo-cpp (Alex Cameron)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2019, 8:47 PM (56 w, 15 h)

Recent Activity

Jul 31 2020

tetsuo-cpp added a comment to D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members.

Friendly ping @njames93.
Does this look ok to you? If so, could you please help me with the commit?

Jul 31 2020, 11:33 PM · Restricted Project, Restricted Project

Jul 23 2020

tetsuo-cpp added a comment to D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members.

@aaron.ballman
Thanks! I took your suggestion and I think this looks cleaner.

Jul 23 2020, 5:46 AM · Restricted Project, Restricted Project
tetsuo-cpp updated the diff for D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members.

Cleanup check conditional.

Jul 23 2020, 5:45 AM · Restricted Project, Restricted Project

Jul 20 2020

tetsuo-cpp added a comment to D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members.

Friendly ping. Could I please get this looked at?

Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project

Jul 13 2020

tetsuo-cpp added a comment to D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members.

Friendly ping!

Jul 13 2020, 4:21 PM · Restricted Project, Restricted Project

Jul 7 2020

tetsuo-cpp updated the diff for D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members.

Address comments: Rename variables, remove unnecessary tests and avoid unnecessary check.

Jul 7 2020, 5:46 AM · Restricted Project, Restricted Project

Jul 5 2020

tetsuo-cpp updated the diff for D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members.

Remove the unnecessary template.

Jul 5 2020, 11:24 PM · Restricted Project, Restricted Project
tetsuo-cpp created D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members.
Jul 5 2020, 11:06 PM · Restricted Project, Restricted Project

Mar 18 2020

tetsuo-cpp added a comment to D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode.

@njames93 @MaskRay
Thanks for helping me with testing. I'll remember this for next time.

I also saw this pattern of retrieving LangOptions from an ASTContext in some other checks (RedundantExpressionCheck and StaticAssertCheck) but I didn't change them to use getLangOpts since the ASTContext is used for other stuff.

Its also not a good idea to change unrelated code in a review

Mar 18 2020, 1:35 PM · Restricted Project, Restricted Project

Mar 10 2020

tetsuo-cpp added a comment to D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode.

@njames93 @MaskRay
Thanks for helping me with testing. I'll remember this for next time.

Mar 10 2020, 7:09 PM · Restricted Project, Restricted Project
tetsuo-cpp updated the diff for D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode.

Address review comments.

Mar 10 2020, 7:09 PM · Restricted Project, Restricted Project
tetsuo-cpp added reviewers for D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode: njames93, MaskRay.
Mar 10 2020, 3:46 AM · Restricted Project, Restricted Project
tetsuo-cpp created D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode.
Mar 10 2020, 3:46 AM · Restricted Project, Restricted Project

Dec 31 2019

tetsuo-cpp added a comment to D69461: [XRay] Sanitize DOT labels in graph output.

Friendly ping!

Dec 31 2019, 10:34 PM · Restricted Project

Nov 18 2019

tetsuo-cpp added a comment to D68179: [lldb] Fix JSON parser to allow empty arrays.

Thanks for the reviews!
@davide could you please commit this on my behalf?

Nov 18 2019, 1:03 AM · Restricted Project, Restricted Project

Nov 14 2019

tetsuo-cpp added a comment to D68179: [lldb] Fix JSON parser to allow empty arrays.

Thanks for looking at this. I will need someone to commit it for me.
However, I've been having issues with the test suite on my MacBook. check-lldb-unit works for me but check-llvm and check-lldb are hitting issues because of something wrong with my environment. So I'll need to sort this out first to verify that I haven't broken anything before it's committed. I'm hoping to spend some time this weekend to debug my setup.

Nov 14 2019, 5:58 AM · Restricted Project, Restricted Project
tetsuo-cpp updated the diff for D68179: [lldb] Fix JSON parser to allow empty arrays.
Nov 14 2019, 5:49 AM · Restricted Project, Restricted Project
tetsuo-cpp added a comment to D69461: [XRay] Sanitize DOT labels in graph output.

Thank you. check-llvm looks healthy with this patch.
Could you please commit this for me?

Nov 14 2019, 3:01 AM · Restricted Project

Nov 13 2019

tetsuo-cpp added a comment to D68179: [lldb] Fix JSON parser to allow empty arrays.

Friendly ping. Could I please get this looked at?

Nov 13 2019, 9:12 PM · Restricted Project, Restricted Project

Nov 9 2019

tetsuo-cpp added a comment to D69461: [XRay] Sanitize DOT labels in graph output.

I compiled multiple older versions of dot and gave them a try (I went back to 2.30.1) but still didn't see this problem. I've been testing like this (mainly testing SVG and JSON):

tetsuo@garland-1572667608860-c-16-sgp1-01:~/dev/llvm-project$ build/bin/llvm-xray graph ./xray-log.a.out.uRHPKt -instr_map ./a.out | dot -Tsvg

@dberris Since I can't reproduce this, should I abandon this revision? Or would you still like the patch.

Nov 9 2019, 10:53 PM · Restricted Project
tetsuo-cpp added a comment to D68179: [lldb] Fix JSON parser to allow empty arrays.

I've had a try at writing some unit tests for the JSON parser in debugserver, including the empty array case which I'm fixing in this patch.

Nov 9 2019, 1:17 AM · Restricted Project, Restricted Project
tetsuo-cpp updated the diff for D68179: [lldb] Fix JSON parser to allow empty arrays.
Nov 9 2019, 1:08 AM · Restricted Project, Restricted Project

Nov 1 2019

tetsuo-cpp added a comment to D69461: [XRay] Sanitize DOT labels in graph output.

I was running 2.40.1-6 which is identical (plus a CVE fix) but still couldn't get dot to error with a test program with templates. The output of dot looks correct for different formats (I was looking mainly at SVG and JSON) before and after this change.
So I'm still not 100% sure that you need this change since I haven't seen the problem first hand. But it doesn't hurt either way.

Nov 1 2019, 8:12 PM · Restricted Project
tetsuo-cpp updated the diff for D69461: [XRay] Sanitize DOT labels in graph output.

Use StringRef.

Nov 1 2019, 7:53 PM · Restricted Project

Oct 26 2019

tetsuo-cpp added a comment to D69461: [XRay] Sanitize DOT labels in graph output.

Understood. If you're still running the same setup, could you please post your dot -V output? I can try testing with the same one.

Oct 26 2019, 1:33 AM · Restricted Project
tetsuo-cpp added a comment to D69461: [XRay] Sanitize DOT labels in graph output.

@lebedev.ri
Thanks for taking a look. I did come across that function earlier but didn't really understand it since I don't see any escaping rules in the docs that look like that. It also doesn't do anything with the & character which will appear in function names too.
But if that solves the problem you described then I'll just use that instead.

Oct 26 2019, 1:06 AM · Restricted Project
tetsuo-cpp created D69461: [XRay] Sanitize DOT labels in graph output.
Oct 26 2019, 12:38 AM · Restricted Project

Oct 14 2019

tetsuo-cpp added a comment to D68906: [llvm-size] Tidy up error messages.

I'm sorry for causing trouble. I was only running check-llvm-tools so I didn't notice this problem. I'll make sure I run everything in the future.

Oct 14 2019, 2:31 PM · Restricted Project
tetsuo-cpp added a comment to D68906: [llvm-size] Tidy up error messages.

Thanks for the reviews @MaskRay and @grimar.
If you're still happy with this patch, could one of you please commit on my behalf?

Oct 14 2019, 3:27 AM · Restricted Project
tetsuo-cpp updated the diff for D68906: [llvm-size] Tidy up error messages.

Remove unnecessary flush.

Oct 14 2019, 3:27 AM · Restricted Project

Oct 12 2019

tetsuo-cpp updated the diff for D68906: [llvm-size] Tidy up error messages.

Address review comments.

Oct 12 2019, 5:44 AM · Restricted Project

Oct 11 2019

tetsuo-cpp created D68906: [llvm-size] Tidy up error messages.
Oct 11 2019, 11:34 PM · Restricted Project

Oct 2 2019

tetsuo-cpp added a comment to D68179: [lldb] Fix JSON parser to allow empty arrays.

Thank you for the suggestions!

Oct 2 2019, 5:13 PM · Restricted Project, Restricted Project
tetsuo-cpp updated the diff for D68179: [lldb] Fix JSON parser to allow empty arrays.

Rebased onto trunk.

Oct 2 2019, 3:48 PM · Restricted Project, Restricted Project

Oct 1 2019

tetsuo-cpp added a comment to D68179: [lldb] Fix JSON parser to allow empty arrays.

Hey, I just want to give you a heads up that I'm in the process to replace LLDB's JSON implementation with the one from LLVM. The parts in StructuredData are already gone (r373359, r373360) and I'm currently working on the other uses in LLDB, except for debugserver which I'm not planning to touch for now.

Oct 1 2019, 3:11 PM · Restricted Project, Restricted Project

Sep 27 2019

tetsuo-cpp updated the diff for D68179: [lldb] Fix JSON parser to allow empty arrays.
Sep 27 2019, 9:47 PM · Restricted Project, Restricted Project
tetsuo-cpp created D68179: [lldb] Fix JSON parser to allow empty arrays.
Sep 27 2019, 7:35 PM · Restricted Project, Restricted Project

Sep 10 2019

tetsuo-cpp added a comment to D67037: [ClangFormat] Add new style option IndentGotoLabels.

@MyDeveloperDay
Thanks for your suggestions! I think it's better now.
This is my first LLVM patch (hopefully first of many) so I don't have commit permissions yet. If you're still happy with this change, could you please commit on my behalf?

Sep 10 2019, 12:24 PM · Restricted Project, Restricted Project, Restricted Project
tetsuo-cpp updated the diff for D67037: [ClangFormat] Add new style option IndentGotoLabels.

Addressed review comments.

Sep 10 2019, 12:18 PM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2019

tetsuo-cpp added a reviewer for D67037: [ClangFormat] Add new style option IndentGotoLabels: MyDeveloperDay.
Sep 6 2019, 5:59 PM · Restricted Project, Restricted Project, Restricted Project
tetsuo-cpp added a comment to D67037: [ClangFormat] Add new style option IndentGotoLabels.

Friendly ping. Could I please get this looked at?

Sep 6 2019, 5:59 PM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2019

tetsuo-cpp created D67037: [ClangFormat] Add new style option IndentGotoLabels.
Aug 31 2019, 4:06 AM · Restricted Project, Restricted Project, Restricted Project