[Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

[rnk]

lgtm

[Ericson2314]

Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to submit an patch email? Is that true, or can/will someone with perms see the approval and eventually merge it from phabricator?

[rnk]

In D69766#1739060, @Ericson2314 wrote:

Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to submit an patch email? Is that true, or can/will someone with perms see the approval and eventually merge it from phabricator?

No, uploading to phabricator is enough.

I started to merge this, but I noticed it breaks two tests:

Failing Tests (2):
  Clang :: Driver/cl-link.c
  Clang :: Driver/fuse-ld.c

I guess this is more of a functional change than I realized. That would need to be investigated.

[shafik]

@rnk can we close this PR?

[rnk]

Let's close it.

clang/lib/Driver/ToolChains/MSVC.cpp

if (TC.getIsVS2017OrNewer() &&
           Environment.push_back(Args.MakeArgString(EnvVar));
         }
         Cursor += EnvVar.size() + 1 /*null-terminator*/;
       }
     }
   SkipSettingEnvironment:;
 #endif
   } else {
-    linkPath = TC.GetProgramPath(Linker.str().c_str());
+    linkPath = TC.GetLinkerPath();
   }
 
   auto LinkCmd = std::make_unique<Command>(
       JA, *this, Args.MakeArgString(linkPath), CmdArgs, Inputs);
   if (!Environment.empty())
     LinkCmd->setEnvironment(Environment);
   C.addCommand(std::move(LinkCmd));
 }