Page MenuHomePhabricator

[Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency
AcceptedPublic

Authored by Ericson2314 on Nov 3 2019, 8:58 AM.

Details

Reviewers
rnk

Event Timeline

Ericson2314 created this revision.Nov 3 2019, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2019, 8:58 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mstorsjo added a reviewer: rnk.Nov 3 2019, 2:24 PM
mstorsjo added a subscriber: mstorsjo.
rnk accepted this revision.Nov 5 2019, 10:31 AM

lgtm

This revision is now accepted and ready to land.Nov 5 2019, 10:31 AM

Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to submit an patch email? Is that true, or can/will someone with perms see the approval and eventually merge it from phabricator?

rnk added a comment.Nov 11 2019, 4:03 PM

Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to submit an patch email? Is that true, or can/will someone with perms see the approval and eventually merge it from phabricator?

No, uploading to phabricator is enough.

I started to merge this, but I noticed it breaks two tests:

Failing Tests (2):
  Clang :: Driver/cl-link.c
  Clang :: Driver/fuse-ld.c

I guess this is more of a functional change than I realized. That would need to be investigated.