Page MenuHomePhabricator
Differential D69419

[llvm-objcopy][MachO] Add support for min os version load commands
ClosedPublic
Actions

Authored by alexshap on Oct 24 2019, 5:38 PM.

Details

Reviewers
seiya
rupprecht
plotfi
smeenai
compnerd
mtrent
jhenderson
Commits
rG074af2daf5f3: [llvm-objcopy][MachO] Add support for min os version load commands
Summary

Add support for min os version load commands.

Test plan: make check-all

Diff Detail

Repository
rL LLVM

Event Timeline

alexshap created this revision.Oct 24 2019, 5:38 PM
Herald added a reviewer: jhenderson. · View Herald TranscriptOct 24 2019, 5:38 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: abrachet, jakehehrlich. · View Herald Transcript
smeenai accepted this revision.Oct 24 2019, 6:45 PM

LGTM ... seems like a trivial change that matches the existing handling of LC_VERSION_MIN_MACOSX (and adds test coverage as an added bonus).

This revision is now accepted and ready to land.Oct 24 2019, 6:45 PM
seiya accepted this revision.Oct 25 2019, 4:01 AM

LGTM too.

compnerd accepted this revision.Oct 25 2019, 8:41 AM
mtrent accepted this revision.Oct 25 2019, 11:10 AM
alexshap closed this revision.Oct 25 2019, 11:45 AM

Committed: https://github.com/llvm/llvm-project/commit/074af2daf5f33b884088dc0200b1acb038bfcaec

Revision Contents
Changeset List

PathSize
llvm/
test/
tools/
llvm-objcopy/
MachO/
Inputs/
15 lines
15 lines
15 lines
15 lines
20 lines
tools/
llvm-objcopy/
MachO/
3 lines

Diff 226365

View Options

llvm/test/tools/llvm-objcopy/MachO/Inputs/min_iphoneos_version_lc.yaml

Loading...
View Options

llvm/test/tools/llvm-objcopy/MachO/Inputs/min_macos_version_lc.yaml

Loading...
View Options

llvm/test/tools/llvm-objcopy/MachO/Inputs/min_tvos_version_lc.yaml

Loading...
View Options

llvm/test/tools/llvm-objcopy/MachO/Inputs/min_watchos_version_lc.yaml

Loading...
View Options

llvm/test/tools/llvm-objcopy/MachO/min-version-load-commands.test

Loading...
View Options

llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp

Loading...