This is an archive of the discontinued LLVM Phabricator instance.

Differential D69315

[LegacyPM] Fix structure dumper
ClosedPublic

Authored by evgeny777 on Oct 22 2019, 11:10 AM.

Details

Reviewers
danielcdh
davide
craig.topper
grosser
tejohnson
chandlerc
Commits
rG87eac7ef6a6f: [LegacyPM] Fix pass structure dumping

Diff Detail

Event Timeline

evgeny777 created this revision.Oct 22 2019, 11:10 AM
Herald added a subscriber: mehdi_amini. · View Herald TranscriptOct 22 2019, 11:10 AM
tejohnson mentioned this in D69331: [LegacyPM] Port CGProfile pass.Oct 23 2019, 11:54 AM
evgeny777 added a reviewer: tejohnson.Oct 25 2019, 5:26 AM
evgeny777 added a comment.Oct 28 2019, 11:50 PM

Ping

evgeny777 added a reviewer: chandlerc.Oct 30 2019, 11:33 PM
tejohnson accepted this revision.Oct 31 2019, 6:22 AM

lgtm but please add patch summary

This revision is now accepted and ready to land.Oct 31 2019, 6:22 AM
Closed by commit rG87eac7ef6a6f: [LegacyPM] Fix pass structure dumping (authored by evgeny777). · Explain WhyNov 1 2019, 5:05 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2019, 5:05 AM
Herald added a subscriber: hiraditya. · View Herald Transcript

Revision Contents

PathSize
llvm/
lib/
IR/
5 lines
test/
CodeGen/
AArch64/
3 lines
Other/
15 lines
15 lines
15 lines
2 lines

Diff 227424

llvm/lib/IR/LegacyPassManager.cpp

Show First 20 Lines • Show All 370 Lines • ▼ Show 20 Lines void getAnalysisUsage(AnalysisUsage &Info) const override {
Info.setPreservesAll(); Info.setPreservesAll();
} }
FPPassManager *getContainedManager(unsigned N) { FPPassManager *getContainedManager(unsigned N) {
assert(N < PassManagers.size() && "Pass number out of range!"); assert(N < PassManagers.size() && "Pass number out of range!");
FPPassManager *FP = static_cast<FPPassManager *>(PassManagers[N]); FPPassManager *FP = static_cast<FPPassManager *>(PassManagers[N]);
return FP; return FP;
} }
void dumpPassStructure(unsigned Offset) override {
for (unsigned I = 0; I < getNumContainedManagers(); ++I)
getContainedManager(I)->dumpPassStructure(Offset);
}
}; };
void FunctionPassManagerImpl::anchor() {} void FunctionPassManagerImpl::anchor() {}
char FunctionPassManagerImpl::ID = 0; char FunctionPassManagerImpl::ID = 0;
} // End of legacy namespace } // End of legacy namespace
} // End of llvm namespace } // End of llvm namespace
▲ Show 20 Lines • Show All 1,443 Lines • Show Last 20 Lines

llvm/test/CodeGen/AArch64/O3-pipeline.ll

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines
; CHECK-NEXT: AArch64 Stack Tagging ; CHECK-NEXT: AArch64 Stack Tagging
; CHECK-NEXT: Natural Loop Information ; CHECK-NEXT: Natural Loop Information
; CHECK-NEXT: CodeGen Prepare ; CHECK-NEXT: CodeGen Prepare
; CHECK-NEXT: Rewrite Symbols ; CHECK-NEXT: Rewrite Symbols
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Exception handling preparation ; CHECK-NEXT: Exception handling preparation
; CHECK-NEXT: AArch64 Promote Constant ; CHECK-NEXT: AArch64 Promote Constant
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Merge internal globals ; CHECK-NEXT: Merge internal globals
; CHECK-NEXT: Safe Stack instrumentation pass ; CHECK-NEXT: Safe Stack instrumentation pass
; CHECK-NEXT: Insert stack protectors ; CHECK-NEXT: Insert stack protectors
; CHECK-NEXT: Module Verifier ; CHECK-NEXT: Module Verifier
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Basic Alias Analysis (stateless AA impl) ; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
; CHECK-NEXT: Function Alias Analysis Results ; CHECK-NEXT: Function Alias Analysis Results
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

llvm/test/Other/opt-O2-pipeline.ll

Show All 22 Lines
; CHECK: Type-Based Alias Analysis ; CHECK: Type-Based Alias Analysis
; CHECK-NEXT: Scoped NoAlias Alias Analysis ; CHECK-NEXT: Scoped NoAlias Alias Analysis
; CHECK-NEXT: Assumption Cache Tracker ; CHECK-NEXT: Assumption Cache Tracker
; CHECK-NEXT: Profile summary info ; CHECK-NEXT: Profile summary info
; CHECK-NEXT: ModulePass Manager ; CHECK-NEXT: ModulePass Manager
; CHECK-NEXT: Force set function attributes ; CHECK-NEXT: Force set function attributes
; CHECK-NEXT: Infer set function attributes ; CHECK-NEXT: Infer set function attributes
; CHECK-NEXT: Interprocedural Sparse Conditional Constant Propagation ; CHECK-NEXT: Interprocedural Sparse Conditional Constant Propagation
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Called Value Propagation ; CHECK-NEXT: Called Value Propagation
; CHECK-NEXT: Deduce and propagate attributes ; CHECK-NEXT: Deduce and propagate attributes
; CHECK-NEXT: Global Variable Optimizer ; CHECK-NEXT: Global Variable Optimizer
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Natural Loop Information
; CHECK-NEXT: Branch Probability Analysis
; CHECK-NEXT: Block Frequency Analysis
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Promote Memory to Register ; CHECK-NEXT: Promote Memory to Register
; CHECK-NEXT: Dead Argument Elimination ; CHECK-NEXT: Dead Argument Elimination
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Basic Alias Analysis (stateless AA impl) ; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
; CHECK-NEXT: Function Alias Analysis Results ; CHECK-NEXT: Function Alias Analysis Results
▲ Show 20 Lines • Show All 131 Lines • ▼ Show 20 Lines
; CHECK-NEXT: Lazy Block Frequency Analysis ; CHECK-NEXT: Lazy Block Frequency Analysis
; CHECK-NEXT: Optimization Remark Emitter ; CHECK-NEXT: Optimization Remark Emitter
; CHECK-NEXT: Combine redundant instructions ; CHECK-NEXT: Combine redundant instructions
; CHECK-NEXT: A No-Op Barrier Pass ; CHECK-NEXT: A No-Op Barrier Pass
; CHECK-NEXT: Eliminate Available Externally Globals ; CHECK-NEXT: Eliminate Available Externally Globals
; CHECK-NEXT: CallGraph Construction ; CHECK-NEXT: CallGraph Construction
; CHECK-NEXT: Deduce function attributes in RPO ; CHECK-NEXT: Deduce function attributes in RPO
; CHECK-NEXT: Global Variable Optimizer ; CHECK-NEXT: Global Variable Optimizer
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Natural Loop Information
; CHECK-NEXT: Branch Probability Analysis
; CHECK-NEXT: Block Frequency Analysis
; CHECK-NEXT: Dead Global Elimination ; CHECK-NEXT: Dead Global Elimination
; CHECK-NEXT: CallGraph Construction ; CHECK-NEXT: CallGraph Construction
; CHECK-NEXT: Globals Alias Analysis ; CHECK-NEXT: Globals Alias Analysis
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Float to int ; CHECK-NEXT: Float to int
; CHECK-NEXT: Lower constant intrinsics ; CHECK-NEXT: Lower constant intrinsics
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines

llvm/test/Other/opt-O3-pipeline.ll

Show All 25 Lines
; CHECK-NEXT: Profile summary info ; CHECK-NEXT: Profile summary info
; CHECK-NEXT: ModulePass Manager ; CHECK-NEXT: ModulePass Manager
; CHECK-NEXT: Force set function attributes ; CHECK-NEXT: Force set function attributes
; CHECK-NEXT: Infer set function attributes ; CHECK-NEXT: Infer set function attributes
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Call-site splitting ; CHECK-NEXT: Call-site splitting
; CHECK-NEXT: Interprocedural Sparse Conditional Constant Propagation ; CHECK-NEXT: Interprocedural Sparse Conditional Constant Propagation
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Called Value Propagation ; CHECK-NEXT: Called Value Propagation
; CHECK-NEXT: Deduce and propagate attributes ; CHECK-NEXT: Deduce and propagate attributes
; CHECK-NEXT: Global Variable Optimizer ; CHECK-NEXT: Global Variable Optimizer
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Natural Loop Information
; CHECK-NEXT: Branch Probability Analysis
; CHECK-NEXT: Block Frequency Analysis
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Promote Memory to Register ; CHECK-NEXT: Promote Memory to Register
; CHECK-NEXT: Dead Argument Elimination ; CHECK-NEXT: Dead Argument Elimination
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Basic Alias Analysis (stateless AA impl) ; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
; CHECK-NEXT: Function Alias Analysis Results ; CHECK-NEXT: Function Alias Analysis Results
▲ Show 20 Lines • Show All 133 Lines • ▼ Show 20 Lines
; CHECK-NEXT: Lazy Block Frequency Analysis ; CHECK-NEXT: Lazy Block Frequency Analysis
; CHECK-NEXT: Optimization Remark Emitter ; CHECK-NEXT: Optimization Remark Emitter
; CHECK-NEXT: Combine redundant instructions ; CHECK-NEXT: Combine redundant instructions
; CHECK-NEXT: A No-Op Barrier Pass ; CHECK-NEXT: A No-Op Barrier Pass
; CHECK-NEXT: Eliminate Available Externally Globals ; CHECK-NEXT: Eliminate Available Externally Globals
; CHECK-NEXT: CallGraph Construction ; CHECK-NEXT: CallGraph Construction
; CHECK-NEXT: Deduce function attributes in RPO ; CHECK-NEXT: Deduce function attributes in RPO
; CHECK-NEXT: Global Variable Optimizer ; CHECK-NEXT: Global Variable Optimizer
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Natural Loop Information
; CHECK-NEXT: Branch Probability Analysis
; CHECK-NEXT: Block Frequency Analysis
; CHECK-NEXT: Dead Global Elimination ; CHECK-NEXT: Dead Global Elimination
; CHECK-NEXT: CallGraph Construction ; CHECK-NEXT: CallGraph Construction
; CHECK-NEXT: Globals Alias Analysis ; CHECK-NEXT: Globals Alias Analysis
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Float to int ; CHECK-NEXT: Float to int
; CHECK-NEXT: Lower constant intrinsics ; CHECK-NEXT: Lower constant intrinsics
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines

llvm/test/Other/opt-Os-pipeline.ll

Show All 22 Lines
; CHECK: Type-Based Alias Analysis ; CHECK: Type-Based Alias Analysis
; CHECK-NEXT: Scoped NoAlias Alias Analysis ; CHECK-NEXT: Scoped NoAlias Alias Analysis
; CHECK-NEXT: Assumption Cache Tracker ; CHECK-NEXT: Assumption Cache Tracker
; CHECK-NEXT: Profile summary info ; CHECK-NEXT: Profile summary info
; CHECK-NEXT: ModulePass Manager ; CHECK-NEXT: ModulePass Manager
; CHECK-NEXT: Force set function attributes ; CHECK-NEXT: Force set function attributes
; CHECK-NEXT: Infer set function attributes ; CHECK-NEXT: Infer set function attributes
; CHECK-NEXT: Interprocedural Sparse Conditional Constant Propagation ; CHECK-NEXT: Interprocedural Sparse Conditional Constant Propagation
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Called Value Propagation ; CHECK-NEXT: Called Value Propagation
; CHECK-NEXT: Deduce and propagate attributes ; CHECK-NEXT: Deduce and propagate attributes
; CHECK-NEXT: Global Variable Optimizer ; CHECK-NEXT: Global Variable Optimizer
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Natural Loop Information
; CHECK-NEXT: Branch Probability Analysis
; CHECK-NEXT: Block Frequency Analysis
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Promote Memory to Register ; CHECK-NEXT: Promote Memory to Register
; CHECK-NEXT: Dead Argument Elimination ; CHECK-NEXT: Dead Argument Elimination
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Basic Alias Analysis (stateless AA impl) ; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
; CHECK-NEXT: Function Alias Analysis Results ; CHECK-NEXT: Function Alias Analysis Results
▲ Show 20 Lines • Show All 118 Lines • ▼ Show 20 Lines
; CHECK-NEXT: Lazy Block Frequency Analysis ; CHECK-NEXT: Lazy Block Frequency Analysis
; CHECK-NEXT: Optimization Remark Emitter ; CHECK-NEXT: Optimization Remark Emitter
; CHECK-NEXT: Combine redundant instructions ; CHECK-NEXT: Combine redundant instructions
; CHECK-NEXT: A No-Op Barrier Pass ; CHECK-NEXT: A No-Op Barrier Pass
; CHECK-NEXT: Eliminate Available Externally Globals ; CHECK-NEXT: Eliminate Available Externally Globals
; CHECK-NEXT: CallGraph Construction ; CHECK-NEXT: CallGraph Construction
; CHECK-NEXT: Deduce function attributes in RPO ; CHECK-NEXT: Deduce function attributes in RPO
; CHECK-NEXT: Global Variable Optimizer ; CHECK-NEXT: Global Variable Optimizer
; CHECK-NEXT: Unnamed pass: implement Pass::getPassName() ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Natural Loop Information
; CHECK-NEXT: Branch Probability Analysis
; CHECK-NEXT: Block Frequency Analysis
; CHECK-NEXT: Dead Global Elimination ; CHECK-NEXT: Dead Global Elimination
; CHECK-NEXT: CallGraph Construction ; CHECK-NEXT: CallGraph Construction
; CHECK-NEXT: Globals Alias Analysis ; CHECK-NEXT: Globals Alias Analysis
; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: FunctionPass Manager
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
; CHECK-NEXT: Float to int ; CHECK-NEXT: Float to int
; CHECK-NEXT: Lower constant intrinsics ; CHECK-NEXT: Lower constant intrinsics
; CHECK-NEXT: Dominator Tree Construction ; CHECK-NEXT: Dominator Tree Construction
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines

llvm/test/Other/pass-pipelines.ll

Show All 22 Lines
; CHECK-O2-NOT: Manager ; CHECK-O2-NOT: Manager
; CHECK-O2: FunctionPass Manager ; CHECK-O2: FunctionPass Manager
; CHECK-O2-NOT: Manager ; CHECK-O2-NOT: Manager
; ;
; CHECK-O2: Pass Arguments: ; CHECK-O2: Pass Arguments:
; CHECK-O2: ModulePass Manager ; CHECK-O2: ModulePass Manager
; CHECK-O2-NOT: Manager ; CHECK-O2-NOT: Manager
; First function pass pipeline just does early opts. ; First function pass pipeline just does early opts.
; CHECK-O2: FunctionPass Manager ; CHECK-O2-COUNT-3: FunctionPass Manager
; CHECK-O2-NOT: Manager ; CHECK-O2-NOT: Manager
; FIXME: It's a bit odd to do dead arg elim in the middle of early opts... ; FIXME: It's a bit odd to do dead arg elim in the middle of early opts...
; CHECK-O2: Dead Argument Elimination ; CHECK-O2: Dead Argument Elimination
; CHECK-O2-NEXT: FunctionPass Manager ; CHECK-O2-NEXT: FunctionPass Manager
; CHECK-O2-NOT: Manager ; CHECK-O2-NOT: Manager
; Very carefully assert the CGSCC pass pipeline as it is fragile and unusually ; Very carefully assert the CGSCC pass pipeline as it is fragile and unusually
; susceptible to phase ordering issues. ; susceptible to phase ordering issues.
; CHECK-O2: CallGraph Construction ; CHECK-O2: CallGraph Construction
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines