This is an archive of the discontinued LLVM Phabricator instance.

[NFC][PowerPC] Clean up PPCAsmPrinter with `IsPPC64` and `IsDarwin`
ClosedPublic

Authored by Xiangling_L on Oct 21 2019, 7:28 AM.

Diff Detail

Event Timeline

Xiangling_L created this revision.Oct 21 2019, 7:28 AM

minor changes

llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
947

IsPPC64 is used as a logical value just a few lines up, but is used as a function here.

1047

Same comment.

Xiangling_L marked 3 inline comments as done.Oct 21 2019, 8:01 AM
Xiangling_L added inline comments.
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
947

Thank you for pointing this out, and I have updated this in my second commit. I guess it's a timing issue so you missed the second commit.

This revision is now accepted and ready to land.Oct 21 2019, 8:09 AM
This revision was automatically updated to reflect the committed changes.
Xiangling_L marked an inline comment as done.