This is an archive of the discontinued LLVM Phabricator instance.

Differential D69254

[lldb] drop .symtab removal in minidebuginfo tests
ClosedPublic

Authored by kwk on Oct 21 2019, 6:09 AM.

Details

Reviewers
• espindola
alexander-shaposhnikov
grimar
labath
Commits
rG9129a281cd5b: [lldb] drop .symtab removal in minidebuginfo tests
rLLDB375415: [lldb] drop .symtab removal in minidebuginfo tests
rL375415: [lldb] drop .symtab removal in minidebuginfo tests
Summary

After D69041, we no longer have to manually remove the .symtab section
once yaml2obj was run.

Diff Detail

Event Timeline

kwk created this revision.Oct 21 2019, 6:09 AM
Herald added a reviewer: • espindola. · View Herald TranscriptOct 21 2019, 6:09 AM
Herald added a reviewer: alexander-shaposhnikov. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: lldb-commits, MaskRay, arichardson, emaste. · View Herald Transcript
kwk planned changes to this revision.Oct 21 2019, 6:10 AM

Still tests are running locally...

Harbormaster completed remote builds in B39851: Diff 225866.Oct 21 2019, 6:16 AM
kwk requested review of this revision.Oct 21 2019, 6:25 AM
kwk added subscribers: grimar, labath.

@grimar @labath tests did pass locally. Are you fine with this change then?

grimar accepted this revision.Oct 21 2019, 6:27 AM

LGTM.

This revision is now accepted and ready to land.Oct 21 2019, 6:27 AM
labath accepted this revision.Oct 21 2019, 6:32 AM
Closed by commit rG9129a281cd5b: [lldb] drop .symtab removal in minidebuginfo tests (authored by kwk). · Explain WhyOct 21 2019, 7:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
test/
Shell/
ObjectFile/
ELF/
5 lines
5 lines
5 lines

Diff 225879

lldb/test/Shell/ObjectFile/ELF/minidebuginfo-corrupt-xz.yaml

# REQUIRES: lzma # REQUIRES: lzma
# This test checks that an error occurs when a corrupted # This test checks that an error occurs when a corrupted
# .gnu_debugdata section is trying to be xz uncompressed. # .gnu_debugdata section is trying to be xz uncompressed.
# RUN: yaml2obj %s > %t.obj # RUN: yaml2obj %s > %t.obj
# TODO(kwk): once yaml2obj doesn't auto-generate a .symtab section
# when there's none in YAML, remove the following line:
# RUN: llvm-objcopy --remove-section=.symtab %t.obj
# RUN: %lldb -b -o 'image dump symtab' %t.obj 2>&1 | FileCheck %s # RUN: %lldb -b -o 'image dump symtab' %t.obj 2>&1 | FileCheck %s
# CHECK: warning: (x86_64) {{.*}}.obj An error occurred while decompression the section .gnu_debugdata: lzma_stream_buffer_decode()=lzma error: LZMA_DATA_ERROR # CHECK: warning: (x86_64) {{.*}}.obj An error occurred while decompression the section .gnu_debugdata: lzma_stream_buffer_decode()=lzma error: LZMA_DATA_ERROR
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Show All 9 Lines

lldb/test/Shell/ObjectFile/ELF/minidebuginfo-find-symbols.yaml

# REQUIRES: lzma # REQUIRES: lzma
# RUN: yaml2obj %s > %t.obj # RUN: yaml2obj %s > %t.obj
# TODO(kwk): once yaml2obj doesn't auto-generate a .symtab section
# when there's none in YAML, remove the following line:
# RUN: llvm-objcopy --remove-section=.symtab %t.obj
# RUN: %lldb -b -o 'image dump symtab' %t.obj | FileCheck %s # RUN: %lldb -b -o 'image dump symtab' %t.obj | FileCheck %s
# CHECK: [ 0] 1 X Code 0x00000000004005b0 0x000000000000000f 0x00000012 multiplyByFour # CHECK: [ 0] 1 X Code 0x00000000004005b0 0x000000000000000f 0x00000012 multiplyByFour
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Show All 9 Lines

lldb/test/Shell/ObjectFile/ELF/minidebuginfo-no-lzma.yaml

# REQUIRES: !lzma # REQUIRES: !lzma
# This test checks that a warning is printed when we're trying # This test checks that a warning is printed when we're trying
# to decompress a .gnu_debugdata section when no LZMA support was compiled in. # to decompress a .gnu_debugdata section when no LZMA support was compiled in.
# RUN: yaml2obj %s > %t.obj # RUN: yaml2obj %s > %t.obj
# TODO(kwk): once yaml2obj doesn't auto-generate a .symtab section
# when there's none in YAML, remove the following line:
# RUN: llvm-objcopy --remove-section=.symtab %t.obj
# RUN: %lldb -b -o 'image dump symtab' %t.obj 2>&1 | FileCheck %s # RUN: %lldb -b -o 'image dump symtab' %t.obj 2>&1 | FileCheck %s
# CHECK: warning: (x86_64) {{.*}}.obj No LZMA support found for reading .gnu_debugdata section # CHECK: warning: (x86_64) {{.*}}.obj No LZMA support found for reading .gnu_debugdata section
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Show All 9 Lines