Page MenuHomePhabricator

[IR] Reimplement FPMathOperator::classof as a whitelist.
ClosedPublic

Authored by foad on Oct 18 2019, 8:56 AM.

Details

Summary

This makes it much easier to verify that the implementation matches the
documentation. It uncovered a bug in the unit tests where we were
accidentally setting fast math flags on a load instruction.

Diff Detail

Event Timeline

foad created this revision.Oct 18 2019, 8:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2019, 8:56 AM
Herald added a subscriber: wdng. · View Herald Transcript
spatel accepted this revision.Oct 18 2019, 9:06 AM

LGTM

This revision is now accepted and ready to land.Oct 18 2019, 9:06 AM
This revision was automatically updated to reflect the committed changes.