Page MenuHomePhabricator

[GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors
ClosedPublic

Authored by qcolombet on Oct 17 2019, 4:12 PM.

Details

Summary

Teach the CombinerHelper how to turn shuffle_vectors, that
concatenate vectors, into concat_vectors and add this combine
to the AArch64 pre-legalizer combiner.

Diff Detail

Event Timeline

qcolombet created this revision.Oct 17 2019, 4:12 PM
arsenm added inline comments.Oct 17 2019, 4:24 PM
lib/CodeGen/GlobalISel/CombinerHelper.cpp
190 ↗(On Diff #225543)

s/unsigned/Register/

235 ↗(On Diff #225543)

s/unsigned/Register

qcolombet marked an inline comment as done.Oct 17 2019, 4:32 PM
qcolombet added inline comments.
lib/CodeGen/GlobalISel/CombinerHelper.cpp
190 ↗(On Diff #225543)

Good catch!
(Habits are hard to kill :))

qcolombet updated this revision to Diff 225544.Oct 17 2019, 4:34 PM
  • Replace some unsigned into Register
qcolombet marked 2 inline comments as done.Oct 17 2019, 4:34 PM
arsenm accepted this revision.Mon, Oct 21, 10:36 AM

LGTM

This revision is now accepted and ready to land.Mon, Oct 21, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Thanks for the quick review @arsenm!