Page MenuHomePhabricator

[AMDGPU][MC][GFX10] Added sdwa/dpp versions of v_cndmask_b32
ClosedPublic

Authored by dp on Oct 17 2019, 3:34 AM.

Diff Detail

Event Timeline

dp created this revision.Oct 17 2019, 3:34 AM
rampitec added inline comments.Oct 17 2019, 9:20 AM
lib/Target/AMDGPU/VOP2Instructions.td
972 ↗(On Diff #225389)

Please add foreach like in D69010. Here and below.

1006 ↗(On Diff #225389)

Also needs foreach,

dp updated this revision to Diff 225491.Oct 17 2019, 12:04 PM

Updated by integrating changes from D69010.

Still missing foreach around dpp.

dp added a comment.Oct 17 2019, 12:23 PM

Still missing foreach around dpp.

I added them but found no differences in *.inc files.
Are they necessary as a reserve for the future?

In D69096#1713450, @dp wrote:

Still missing foreach around dpp.

I added them but found no differences in *.inc files.
Are they necessary as a reserve for the future?

Yes, it is better to have them so we do not have to check every time we are not producing garbage.

dp updated this revision to Diff 225499.Oct 17 2019, 12:49 PM

Added more guards to avoid generating unused instructions.

This revision is now accepted and ready to land.Oct 17 2019, 12:56 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2019, 7:51 AM