Page MenuHomePhabricator

PrzemekWirkus (Przemyslaw Wirkus)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2017, 9:33 AM (151 w, 1 d)

For every complex problem, there is a solution that is simple, neat, and wrong.

Recent Activity

Jan 17 2020

PrzemekWirkus accepted D68779: [LNT][NFC] Fix global import in function.

For Python 2 only support in LNT this patch LGTM.

Jan 17 2020, 6:59 AM

Dec 10 2019

PrzemekWirkus added a comment to D68798: [LNT] Python 3 support: fix printing of exceptions.

LGTM

Dec 10 2019, 4:12 AM
PrzemekWirkus accepted D68798: [LNT] Python 3 support: fix printing of exceptions.
Dec 10 2019, 4:12 AM
PrzemekWirkus accepted D67823: [LNT] Python 3 support: use Python 3 module names.

LGTM

Dec 10 2019, 2:59 AM

Dec 7 2019

PrzemekWirkus accepted D68799: [LNT] Fix sql index name collision.

LGTM

Dec 7 2019, 3:15 PM
PrzemekWirkus accepted D68797: [LNT] Python 3 support: Do not encode report for stdout.

LGTM

Dec 7 2019, 3:15 PM
PrzemekWirkus accepted D71085: [LNT] Declare support for Python 3.6+.
Dec 7 2019, 3:06 PM

Dec 6 2019

PrzemekWirkus accepted D68829: [LNT] Python 3 support: Parse HTML as text.
Dec 6 2019, 2:10 AM

Dec 5 2019

PrzemekWirkus accepted D68921: [LNT] Python 3 support: fix server/ui/statsTester.py test discovery.

LGTM

Dec 5 2019, 3:49 PM
PrzemekWirkus added inline comments to D71085: [LNT] Declare support for Python 3.6+.
Dec 5 2019, 3:45 PM
PrzemekWirkus accepted D68800: [LNT] Python 3 support: adapt csv reader open.

You've defended your code ;)

Dec 5 2019, 3:31 PM
PrzemekWirkus added inline comments to D68800: [LNT] Python 3 support: adapt csv reader open.
Dec 5 2019, 7:59 AM
PrzemekWirkus added inline comments to D68800: [LNT] Python 3 support: adapt csv reader open.
Dec 5 2019, 7:59 AM
PrzemekWirkus accepted D68938: [LNT] Python 3 support: subprocess IO as text.

LGTM

Dec 5 2019, 7:59 AM
PrzemekWirkus added inline comments to D68800: [LNT] Python 3 support: adapt csv reader open.
Dec 5 2019, 7:52 AM
PrzemekWirkus added inline comments to D68800: [LNT] Python 3 support: adapt csv reader open.
Dec 5 2019, 7:49 AM
PrzemekWirkus added inline comments to D68800: [LNT] Python 3 support: adapt csv reader open.
Dec 5 2019, 7:49 AM
PrzemekWirkus accepted D68803: [LNT] Python 3 support: sort benchmark regressing.
Dec 5 2019, 7:33 AM
PrzemekWirkus accepted D68796: [LNT] Python 3 support: fix storage of json data as BLOB.

Ah, DB schema is just above the insert. Silly me!

Dec 5 2019, 7:30 AM
PrzemekWirkus added a comment to D68796: [LNT] Python 3 support: fix storage of json data as BLOB.

From where can I get schema for this database you are inserting to ?

Dec 5 2019, 7:24 AM
PrzemekWirkus added inline comments to D67823: [LNT] Python 3 support: use Python 3 module names.
Dec 5 2019, 7:21 AM
PrzemekWirkus accepted D68803: [LNT] Python 3 support: sort benchmark regressing.
Dec 5 2019, 7:16 AM
PrzemekWirkus accepted D68801: [LNT] Python 3 support: print unknown metric with str.

LGTM

Dec 5 2019, 7:11 AM
PrzemekWirkus accepted D68985: [LNT] Python 3 support: requests.response as text.
Dec 5 2019, 7:07 AM
PrzemekWirkus accepted D69053: [LNT] Switch docker image to Python 3.

LGTM

Dec 5 2019, 7:06 AM
PrzemekWirkus added inline comments to D68779: [LNT][NFC] Fix global import in function.
Dec 5 2019, 7:06 AM
PrzemekWirkus accepted D67881: [LNT] Python 3 support: replace xrange with Python3's range.

LGTM

Dec 5 2019, 6:52 AM
PrzemekWirkus accepted D71057: [LNT] Replace assertEquals for assertEqual.

LGTM

Dec 5 2019, 6:47 AM
PrzemekWirkus accepted D71058: [LNT, NFC] Open tmp file in a context.

LGTM

Dec 5 2019, 6:47 AM
PrzemekWirkus added a comment to D71058: [LNT, NFC] Open tmp file in a context.

LGTM but someone else must approve.

Dec 5 2019, 5:17 AM
PrzemekWirkus added a comment to D71057: [LNT] Replace assertEquals for assertEqual.

LGTM but someone else must approve.

Dec 5 2019, 5:17 AM
PrzemekWirkus added inline comments to D68802: [LNT] Python 3 support: fix writing report to tmp file.
Dec 5 2019, 4:31 AM
PrzemekWirkus added inline comments to D68779: [LNT][NFC] Fix global import in function.
Dec 5 2019, 4:29 AM
PrzemekWirkus added inline comments to D68779: [LNT][NFC] Fix global import in function.
Dec 5 2019, 4:29 AM
PrzemekWirkus added a comment to D69053: [LNT] Switch docker image to Python 3.

LGTM but someone else must approve

Dec 5 2019, 4:20 AM
PrzemekWirkus added a comment to D69053: [LNT] Switch docker image to Python 3.

I don't use Docker. Can someone else review?

Dec 5 2019, 4:20 AM
PrzemekWirkus added inline comments to D68802: [LNT] Python 3 support: fix writing report to tmp file.
Dec 5 2019, 4:02 AM
PrzemekWirkus added a comment to D68985: [LNT] Python 3 support: requests.response as text.

LGTM but someone else must approve.

Dec 5 2019, 3:16 AM
PrzemekWirkus added a comment to D68829: [LNT] Python 3 support: Parse HTML as text.

LGTM but someone else must approve.

Dec 5 2019, 3:07 AM

Dec 4 2019

PrzemekWirkus added inline comments to D68779: [LNT][NFC] Fix global import in function.
Dec 4 2019, 6:44 AM
PrzemekWirkus added inline comments to D68779: [LNT][NFC] Fix global import in function.
Dec 4 2019, 6:44 AM
PrzemekWirkus updated subscribers of D68779: [LNT][NFC] Fix global import in function.

@thopre Thomas, please add me and @leandron as reviewers to this series of patches. We can have a look.

Dec 4 2019, 6:35 AM

Jun 28 2018

PrzemekWirkus accepted D48648: [LNT][cPerf] Decide whether to discard functions before disassembling them.

Looks good to me.

Jun 28 2018, 2:07 AM

May 19 2018

PrzemekWirkus added a comment to D46433: [LNT] lnt profile upgrade command for large Spec2017 perf.data aborts.

@MatzeB There is nothing perf specific in this code, just plain C++ to wrap buffers into containers.

May 19 2018, 5:41 AM

May 16 2018

PrzemekWirkus added a comment to D46433: [LNT] lnt profile upgrade command for large Spec2017 perf.data aborts.

@MatzeB Are you able to have a quick look at this patch please?

May 16 2018, 1:03 AM

May 4 2018

PrzemekWirkus updated the summary of D46433: [LNT] lnt profile upgrade command for large Spec2017 perf.data aborts.
May 4 2018, 8:35 AM
PrzemekWirkus updated the diff for D46433: [LNT] lnt profile upgrade command for large Spec2017 perf.data aborts.

Small curly braces indent issue fixed (consistent coding style)

May 4 2018, 8:26 AM
PrzemekWirkus created D46433: [LNT] lnt profile upgrade command for large Spec2017 perf.data aborts.
May 4 2018, 8:12 AM

Feb 28 2018

PrzemekWirkus added a comment to D43862: [LNT] Error accessing URL /db_default/v4/nts/profile/ajax/getFunctions; NOT FOUND.

@cmatthews Chris, I think below if is needed as session query still may may not return what we are expecting. E.g. in case of DB inconsistency.

Feb 28 2018, 9:28 AM
PrzemekWirkus added a comment to D43862: [LNT] Error accessing URL /db_default/v4/nts/profile/ajax/getFunctions; NOT FOUND.

@leandron Would you be so kind and upstream this patch when code review is finished. I will go on holiday for whole March + I have no push permissions on this repo.
Cheers!

Feb 28 2018, 6:16 AM
PrzemekWirkus created D43862: [LNT] Error accessing URL /db_default/v4/nts/profile/ajax/getFunctions; NOT FOUND.
Feb 28 2018, 2:25 AM

Jun 26 2017

PrzemekWirkus created D34617: LNT's MANIFEST.in file is missing required client & server requirement files.
Jun 26 2017, 7:20 AM