Page MenuHomePhabricator

[AIX][XCOFF][NFC] Change the SectionLen field name of CSect Auxiliary entry to SectionOrLength.
ClosedPublic

Authored by DiggerLin on Tue, Oct 8, 8:36 AM.

Details

Summary

According the the XCOFF document,

If
Then
XTY_SD
x_scnlen contains the csect length.
XTY_LD
x_scnlen contains the symbol table index of the containing csect.
XTY_CM
x_scnlen contains the csect length.
XTY_ER
x_scnlen contains 0.

Change the SectionLen member name to SectionOrLength is more reasonable .

Diff Detail

Event Timeline

DiggerLin created this revision.Tue, Oct 8, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Oct 8, 8:36 AM
DiggerLin retitled this revision from [AIX][NFC] Change the SectionLen field name of CSect Auxiliary entry to SectionOrLength. to [AIX][XCOFF][NFC] Change the SectionLen field name of CSect Auxiliary entry to SectionOrLength..Tue, Oct 8, 8:37 AM

Thanks @DiggerLin. Just minor comments.

llvm/include/llvm/Object/XCOFFObjectFile.h
117

s/it contains//g;

s/XTY_SD,XTY_CM/XTY_SD or XTY_CM/;
s/is XTY_ER/is XTY_ER/;

DiggerLin marked an inline comment as done.Tue, Oct 8, 1:52 PM
DiggerLin added inline comments.
llvm/include/llvm/Object/XCOFFObjectFile.h
117

changed as suggestion.

DiggerLin updated this revision to Diff 223939.Tue, Oct 8, 1:53 PM

addressed comment

LGTM. Thanks again.

This revision is now accepted and ready to land.Tue, Oct 8, 2:46 PM
This revision was automatically updated to reflect the committed changes.

Sorry I accidentally committed llvm/D68650.diff. I already removed it with another commit llvm-svn: 374181.