This is an archive of the discontinued LLVM Phabricator instance.

Differential D68603

[sanitizer] Print SIGTRAP for corresponding signal
ClosedPublic

Authored by vitalybuka on Oct 7 2019, 3:17 PM.

Details

Reviewers
eugenis
jfb
Commits
rG9917c76107f8: [sanitizer] Print SIGTRAP for corresponding signal
rCRT373979: [sanitizer] Print SIGTRAP for corresponding signal
rL373979: [sanitizer] Print SIGTRAP for corresponding signal

Diff Detail

Event Timeline

vitalybuka created this revision.Oct 7 2019, 3:17 PM
Herald added a reviewer: jfb. · View Herald TranscriptOct 7 2019, 3:17 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
vitalybuka updated this revision to Diff 223681.Oct 7 2019, 3:33 PM

remove SIG prefix from the string

Herald added a subscriber: dexonsmith. · View Herald TranscriptOct 7 2019, 3:33 PM
eugenis accepted this revision.Oct 7 2019, 3:38 PM

LGTM

This revision is now accepted and ready to land.Oct 7 2019, 3:38 PM
Harbormaster completed remote builds in B39113: Diff 223674.Oct 7 2019, 10:06 PM
Harbormaster completed remote builds in B39117: Diff 223681.
Closed by commit rL373979: [sanitizer] Print SIGTRAP for corresponding signal (authored by vitalybuka). · Explain WhyOct 7 2019, 10:22 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptOct 7 2019, 10:22 PM
stevewan added a subscriber: stevewan.Oct 9 2019, 8:15 AM

Hi @vitalybuka,

This is causing LIT failures in clang-s390x-linux. Can you please take a look? Thanks!

Steven

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
2 lines
test/
sanitizer_common/
TestCases/
Linux/
8 lines

Diff 223674

compiler-rt/lib/sanitizer_common/sanitizer_posix.cpp

Show First 20 Lines • Show All 306 Lines • ▼ Show 20 Lines switch (GetType()) {
case SIGILL: case SIGILL:
return "ILL"; return "ILL";
case SIGABRT: case SIGABRT:
return "ABRT"; return "ABRT";
case SIGSEGV: case SIGSEGV:
return "SEGV"; return "SEGV";
case SIGBUS: case SIGBUS:
return "BUS"; return "BUS";
case SIGTRAP:
return "SIGTRAP";
} }
return "UNKNOWN SIGNAL"; return "UNKNOWN SIGNAL";
} }
fd_t ReserveStandardFds(fd_t fd) { fd_t ReserveStandardFds(fd_t fd) {
CHECK_GE(fd, 0); CHECK_GE(fd, 0);
if (fd > 2) if (fd > 2)
return fd; return fd;
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines

compiler-rt/test/sanitizer_common/TestCases/Linux/signal_trap.cpp

  • This file was added.
// RUN: %clangxx -O1 %s -o %t && %env_tool_opts=handle_sigtrap=2 not %run %t 2>&1 | FileCheck %s
int main() {
__builtin_debugtrap();
}
// CHECK: Sanitizer:DEADLYSIGNAL
// CHECK: Sanitizer: SIGTRAP on unknown address