This is an archive of the discontinued LLVM Phabricator instance.

Differential D68423

[clang-tools-extra] [cmake] Use add_clang_tool() to install tools
ClosedPublic

Authored by mgorny on Oct 3 2019, 2:18 PM.

Details

Reviewers
compnerd
beanz
phosek
tstellar
smeenai
jtsoftware
hokein
Commits
rCTE373694: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools
rGcb46b69e3eea: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools
rL373694: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools
Summary

Replace add_clang_executable() calls with add_clang_tool() that takes
care of creating correct, distribution-friendly install target. While
at it, remove redundant install calls.

This change also causes clang-move and pp-trace to be installed.

Diff Detail

Event Timeline

mgorny created this revision.Oct 3 2019, 2:18 PM
phosek accepted this revision.Oct 3 2019, 3:33 PM

LGTM

This revision is now accepted and ready to land.Oct 3 2019, 3:33 PM
Closed by commit rL373694: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools (authored by mgorny). · Explain WhyOct 3 2019, 10:39 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 10:39 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang-tools-extra/
clang-apply-replacements/
tool/
3 lines
clang-change-namespace/
tool/
5 lines
clang-include-fixer/
find-all-symbols/
tool/
5 lines
tool/
3 lines
clang-move/
tool/
2 lines
clang-query/
tool/
4 lines
pp-trace/
2 lines

Diff 223093

clang-tools-extra/clang-apply-replacements/tool/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_clang_tool(clang-apply-replacements add_clang_tool(clang-apply-replacements
ClangApplyReplacementsMain.cpp ClangApplyReplacementsMain.cpp
) )
target_link_libraries(clang-apply-replacements target_link_libraries(clang-apply-replacements
PRIVATE PRIVATE
clangApplyReplacements clangApplyReplacements
clangBasic clangBasic
clangFormat clangFormat
clangRewrite clangRewrite
clangToolingCore clangToolingCore
clangToolingRefactoring clangToolingRefactoring
) )
install(TARGETS clang-apply-replacements
RUNTIME DESTINATION bin)

clang-tools-extra/clang-change-namespace/tool/CMakeLists.txt

include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_clang_executable(clang-change-namespace add_clang_tool(clang-change-namespace
ClangChangeNamespace.cpp ClangChangeNamespace.cpp
) )
target_link_libraries(clang-change-namespace target_link_libraries(clang-change-namespace
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangChangeNamespace clangChangeNamespace
clangFormat clangFormat
clangFrontend clangFrontend
clangRewrite clangRewrite
clangSerialization clangSerialization
clangTooling clangTooling
clangToolingCore clangToolingCore
) )
install(TARGETS clang-change-namespace
RUNTIME DESTINATION bin)

clang-tools-extra/clang-include-fixer/find-all-symbols/tool/CMakeLists.txt

include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
add_clang_executable(find-all-symbols add_clang_tool(find-all-symbols
FindAllSymbolsMain.cpp FindAllSymbolsMain.cpp
) )
target_link_libraries(find-all-symbols target_link_libraries(find-all-symbols
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangSerialization clangSerialization
clangTooling clangTooling
findAllSymbols findAllSymbols
) )
install(TARGETS find-all-symbols
RUNTIME DESTINATION bin)
install(PROGRAMS run-find-all-symbols.py install(PROGRAMS run-find-all-symbols.py
DESTINATION share/clang DESTINATION share/clang
COMPONENT find-all-symbols) COMPONENT find-all-symbols)

clang-tools-extra/clang-include-fixer/tool/CMakeLists.txt

Show All 11 Linestarget_link_libraries(clang-include-fixer
clangIncludeFixer clangIncludeFixer
clangRewrite clangRewrite
clangSerialization clangSerialization
clangTooling clangTooling
clangToolingCore clangToolingCore
findAllSymbols findAllSymbols
) )
install(TARGETS clang-include-fixer
RUNTIME DESTINATION bin)
install(PROGRAMS clang-include-fixer.el install(PROGRAMS clang-include-fixer.el
DESTINATION share/clang DESTINATION share/clang
COMPONENT clang-include-fixer) COMPONENT clang-include-fixer)
install(PROGRAMS clang-include-fixer.py install(PROGRAMS clang-include-fixer.py
DESTINATION share/clang DESTINATION share/clang
COMPONENT clang-include-fixer) COMPONENT clang-include-fixer)

clang-tools-extra/clang-move/tool/CMakeLists.txt

include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
add_clang_executable(clang-move add_clang_tool(clang-move
ClangMove.cpp ClangMove.cpp
) )
target_link_libraries(clang-move target_link_libraries(clang-move
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFormat clangFormat
clangFrontend clangFrontend
clangMove clangMove
clangRewrite clangRewrite
clangSerialization clangSerialization
clangTooling clangTooling
clangToolingCore clangToolingCore
) )

clang-tools-extra/clang-query/tool/CMakeLists.txt

include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
add_clang_executable(clang-query add_clang_tool(clang-query
ClangQuery.cpp ClangQuery.cpp
) )
target_link_libraries(clang-query target_link_libraries(clang-query
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangDynamicASTMatchers clangDynamicASTMatchers
clangFrontend clangFrontend
clangQuery clangQuery
clangSerialization clangSerialization
clangTooling clangTooling
) )
install(TARGETS clang-query RUNTIME DESTINATION bin)

clang-tools-extra/pp-trace/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_clang_executable(pp-trace add_clang_tool(pp-trace
PPTrace.cpp PPTrace.cpp
PPCallbacksTracker.cpp PPCallbacksTracker.cpp
) )
target_link_libraries(pp-trace target_link_libraries(pp-trace
PRIVATE PRIVATE
clangAST clangAST
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangSerialization clangSerialization
clangTooling clangTooling
) )