Page MenuHomePhabricator

[WebAssembly] Error when using wasm64 for ISel
ClosedPublic

Authored by tlively on Sep 30 2019, 5:07 PM.

Details

Summary

64-bit WebAssembly (wasm64) is not specified and not supported in the
WebAssembly backend. We do have support for it in clang, however, and
we would like to keep that support because we expect wasm64 to be
specified and supported in the future. For now add an error when
trying to use wasm64 from the backend to minimize user confusion from
unexplained crashes.

Diff Detail

Repository
rL LLVM

Event Timeline

tlively created this revision.Sep 30 2019, 5:07 PM
Herald added a project: Restricted Project. ยท View Herald TranscriptSep 30 2019, 5:07 PM
aheejin accepted this revision.Oct 1 2019, 12:22 AM
aheejin added inline comments.
llvm/lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp
60 โ†—(On Diff #222523)

How about 'not currently supported'? I don't want to make an impression that this is something that's meant not to be supported but also don't want to imply that we have plans to support that in the future, so... ๐Ÿคท๐Ÿปโ€โ™€๏ธ

This revision is now accepted and ready to land.Oct 1 2019, 12:22 AM
This revision was automatically updated to reflect the committed changes.
tlively marked an inline comment as done.