Page MenuHomePhabricator

[WebAssembly] Let users know that wasm64 does not exist
AbandonedPublic

Authored by tlively on Sep 18 2019, 4:09 PM.

Details

Reviewers
dschuff
aheejin

Event Timeline

tlively created this revision.Sep 18 2019, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 18 2019, 4:09 PM

Would it be better to do this check in LLVM, in the backend, with a report_fatal_error?

Clang for its part already supports what we expect wasm64 will need already, and we have a bunch of tests for it, so it'd be nice to keep that code around and tested. And, doing the check in the LLVM backend also means we'll catch users trying to use it from languages other than C/C++.

+1 on erroring out on the backend side. And how about "wasm64 is not supported"? wasm64... is still a registered target in the frontend, so...

tlively planned changes to this revision.Sep 23 2019, 1:48 PM

It sounds reasonable to check this from the backend instead.

tlively abandoned this revision.Sep 30 2019, 5:48 PM

Closing in favor of D68254.