This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Fix parseNamespaceEvents to parse the last token
ClosedPublic

Authored by kadircet on Sep 25 2019, 6:53 AM.

Event Timeline

kadircet created this revision.Sep 25 2019, 6:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 6:53 AM
hokein accepted this revision.Sep 25 2019, 7:02 AM
hokein added inline comments.
clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
429

could you also add an "empty string" test case?

This revision is now accepted and ready to land.Sep 25 2019, 7:02 AM
kadircet updated this revision to Diff 221759.Sep 25 2019, 7:08 AM
  • Add empty string testcase
kadircet marked an inline comment as done.Sep 25 2019, 7:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 7:10 AM