Page Menu
Home
Phabricator
This is an archive of the discontinued LLVM Phabricator instance.
Paths
Table of Contents
t
-
clang-tools-extra/trunk/clangd/
-
trunk/
-
clangd/
-
SourceCode.cpp
-
unittests/
-
SourceCodeTests.cpp
Hide Panel
f
Keyboard Reference
?
Differential
D68020
[clangd] Fix parseNamespaceEvents to parse the last token
Closed
Public
Authored by
kadircet
on Sep 25 2019, 6:53 AM.
Download Raw Diff
Details
Reviewers
hokein
ilya-biryukov
Commits
rG194117f04ba0: [clangd] Fix parseNamespaceEvents to parse the last token
rL372875: [clangd] Fix parseNamespaceEvents to parse the last token
rCTE372875: [clangd] Fix parseNamespaceEvents to parse the last token
Diff Detail
Repository
rL LLVM
Event Timeline
kadircet
created this revision.
Sep 25 2019, 6:53 AM
Herald
added a project:
Restricted Project
.
·
View Herald Transcript
Sep 25 2019, 6:53 AM
Herald
added subscribers:
cfe-commits
,
usaxena95
,
arphaman
and
2 others
.
·
View Herald Transcript
Harbormaster
completed remote builds in
B38535: Diff 221752
.
Sep 25 2019, 6:54 AM
hokein
accepted this revision.
Sep 25 2019, 7:02 AM
hokein
added inline comments.
clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
429 ↗
(On Diff #221752)
could you also add an "empty string" test case?
This revision is now accepted and ready to land.
Sep 25 2019, 7:02 AM
kadircet
updated this revision to
Diff 221759
.
Sep 25 2019, 7:08 AM
Comment Actions
Add empty string testcase
kadircet
marked an inline comment as done.
Sep 25 2019, 7:09 AM
Harbormaster
completed remote builds in
B38536: Diff 221759
.
Sep 25 2019, 7:10 AM
Closed by commit
rL372875: [clangd] Fix parseNamespaceEvents to parse the last token
(authored by
kadircet
).
·
Explain Why
Sep 25 2019, 7:10 AM
This revision was automatically updated to reflect the committed changes.
Herald
added a project:
Restricted Project
.
·
View Herald Transcript
Sep 25 2019, 7:10 AM
Herald
added a subscriber:
llvm-commits
.
·
View Herald Transcript