[LLDB] Add a void* cast when passing object pointers to printf %p

[mstorsjo]

Summary

This fixes build warnings in MinGW mode.

[labath]

This looks fine. When you see a pattern like if(log) { LLDB_LOGF(...) }, feel free to delete the surrounding if(log). It is no longer necessary, and the reason it is still there is simply because Jonas's vim script wasn't smart enough to delete it in some cases.

lldb/trunk/source/Host/windows/ConnectionGenericFileWindows.cpp

finish:
 
   // kBytesAvailableEvent is a manual reset event.  Make sure it gets reset
   // here so that any subsequent operations don't immediately see bytes
   // available.
   ResetEvent(m_event_handles[kBytesAvailableEvent]);
 
   IncrementFilePointer(return_info.GetBytes());
   Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_CONNECTION));
-  if (log) {
-    LLDB_LOGF(log,
-              "%p ConnectionGenericFile::Read()  handle = %p, dst = %p, "
-              "dst_len = %zu) => %zu, error = %s",
-              this, m_file, dst, dst_len, return_info.GetBytes(),
-              return_info.GetError().AsCString());
-  }
+            static_cast<void *>(this), m_file, dst, dst_len,
+            return_info.GetBytes(), return_info.GetError().AsCString());
 
   return return_info.GetBytes();
 }
 
 size_t ConnectionGenericFile::Write(const void *src, size_t src_len,
                                     lldb::ConnectionStatus &status,
                                     Status *error_ptr) {
   ReturnInfo return_info;

 
 finish:
   status = return_info.GetStatus();
   if (error_ptr)
     *error_ptr = return_info.GetError();
 
   IncrementFilePointer(return_info.GetBytes());
   Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_CONNECTION));
-  if (log) {
-    LLDB_LOGF(log,
-              "%p ConnectionGenericFile::Write()  handle = %p, src = %p, "
-              "src_len = %zu) => %zu, error = %s",
-              this, m_file, src, src_len, return_info.GetBytes(),
-              return_info.GetError().AsCString());
-  }
+            static_cast<void *>(this), m_file, src, src_len,
+            return_info.GetBytes(), return_info.GetError().AsCString());
   return return_info.GetBytes();
 }
 
 std::string ConnectionGenericFile::GetURI() { return m_uri; }
 
 bool ConnectionGenericFile::InterruptRead() {
   return ::SetEvent(m_event_handles[kInterruptEvent]);
 }