Page MenuHomePhabricator

hhb (Haibo Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 29 2018, 3:41 PM (50 w, 3 d)

Recent Activity

Wed, Oct 16

hhb committed rG1d4a40751ff3: [lldb] move more things from python to cmake (authored by hhb).
[lldb] move more things from python to cmake
Wed, Oct 16, 11:06 AM
hhb committed rL375024: [lldb] move more things from python to cmake.
[lldb] move more things from python to cmake
Wed, Oct 16, 11:05 AM
hhb closed D69016: [lldb] move more things from python to cmake.
Wed, Oct 16, 11:05 AM · Restricted Project
hhb added a reviewer for D69019: [lldb] move package generation from python to cmake: labath.
Wed, Oct 16, 11:05 AM · Restricted Project
hhb updated the diff for D69019: [lldb] move package generation from python to cmake.

Format

Wed, Oct 16, 11:05 AM · Restricted Project
hhb updated the diff for D69019: [lldb] move package generation from python to cmake.

Rebase

Wed, Oct 16, 11:05 AM · Restricted Project
hhb added a comment to D69016: [lldb] move more things from python to cmake.

I'm not sure if I like the usage of POST_BUILD stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines.

Wed, Oct 16, 9:50 AM · Restricted Project

Tue, Oct 15

hhb created D69019: [lldb] move package generation from python to cmake.
Tue, Oct 15, 10:25 PM · Restricted Project
hhb planned changes to D69019: [lldb] move package generation from python to cmake.
Tue, Oct 15, 10:25 PM · Restricted Project
hhb created D69016: [lldb] move more things from python to cmake.
Tue, Oct 15, 8:18 PM · Restricted Project
hhb committed rL374968: Request commit access for hhb.
Request commit access for hhb
Tue, Oct 15, 7:38 PM
hhb committed rG208e9c01fc09: [lldb] Creates _liblldb symlink from cmake (authored by hhb).
[lldb] Creates _liblldb symlink from cmake
Tue, Oct 15, 3:00 PM
hhb committed rL374953: [lldb] Creates _liblldb symlink from cmake.
[lldb] Creates _liblldb symlink from cmake
Tue, Oct 15, 3:00 PM
hhb closed D68858: [lldb] Creates _liblldb symlink from cmake.
Tue, Oct 15, 3:00 PM · Restricted Project
hhb added a comment to D68910: python path should be platform-dependent.

One additional statement in openSUSE comparing to standard python:

libdir = plat_specific and get_config_var("platlibdir") or "lib"
Tue, Oct 15, 2:51 PM · Restricted Project
hhb added a comment to D68910: python path should be platform-dependent.
Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import distutils.sysconfig
>>> print(distutils.sysconfig.get_python_lib(True, False, ''))
lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(True, False, '/abc'))
/abc/lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(True, False))
/usr/lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False, ''))
lib/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False, '/abc'))
/abc/lib/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False))
/usr/lib/python3.6/site-packages

This is interesting...

Tue, Oct 15, 2:41 PM · Restricted Project
hhb accepted D68910: python path should be platform-dependent.

How about this one?

Tue, Oct 15, 2:23 PM · Restricted Project
hhb added a comment to D68858: [lldb] Creates _liblldb symlink from cmake.

Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode.

Tue, Oct 15, 10:49 AM · Restricted Project
hhb requested changes to D68910: python path should be platform-dependent.

Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change...

Tue, Oct 15, 10:48 AM · Restricted Project

Mon, Oct 14

hhb added inline comments to D68858: [lldb] Creates _liblldb symlink from cmake.
Mon, Oct 14, 10:34 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Oops fix typo.

Mon, Oct 14, 9:48 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix the build for multi-config generator.

Mon, Oct 14, 9:36 PM · Restricted Project
hhb planned changes to D68858: [lldb] Creates _liblldb symlink from cmake.
Mon, Oct 14, 1:06 PM · Restricted Project

Fri, Oct 11

hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Adds VERBATIM

Fri, Oct 11, 4:23 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix typo

Fri, Oct 11, 11:55 AM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix file copy path

Fri, Oct 11, 11:55 AM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix file copy path

Fri, Oct 11, 11:55 AM · Restricted Project
hhb added inline comments to D68719: Fix issue when building with Visual Studio.
Fri, Oct 11, 11:37 AM · Restricted Project
hhb added reviewers for D68858: [lldb] Creates _liblldb symlink from cmake: labath, jingham, tatyana-krasnukha.
Fri, Oct 11, 11:37 AM · Restricted Project
hhb committed rG6aacd9687543: [lldb] Fix python packages install path (authored by hhb).
[lldb] Fix python packages install path
Fri, Oct 11, 10:43 AM
hhb closed D68878: [lldb] Fix python packages install path.
Fri, Oct 11, 10:43 AM · Restricted Project
hhb committed rL374577: [lldb] Fix python packages install path.
[lldb] Fix python packages install path
Fri, Oct 11, 10:42 AM
hhb created D68878: [lldb] Fix python packages install path.
Fri, Oct 11, 10:14 AM · Restricted Project

Thu, Oct 10

hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Remove tailing whitespace

Thu, Oct 10, 10:52 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Rebase

Thu, Oct 10, 10:42 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix format

Thu, Oct 10, 10:42 PM · Restricted Project
hhb created D68858: [lldb] Creates _liblldb symlink from cmake.
Thu, Oct 10, 10:42 PM · Restricted Project
hhb committed rG7b9900dff3c0: Clean up format in cmake file (authored by hhb).
Clean up format in cmake file
Thu, Oct 10, 5:13 PM
hhb closed D68842: Clean up format in cmake file.
Thu, Oct 10, 5:13 PM · Restricted Project
hhb committed rL374483: Clean up format in cmake file.
Clean up format in cmake file
Thu, Oct 10, 5:13 PM
hhb created D68842: Clean up format in cmake file.
Thu, Oct 10, 5:04 PM · Restricted Project
hhb added inline comments to D68719: Fix issue when building with Visual Studio.
Thu, Oct 10, 2:43 PM · Restricted Project
hhb added inline comments to D68719: Fix issue when building with Visual Studio.
Thu, Oct 10, 1:46 PM · Restricted Project

Wed, Oct 9

hhb committed rG1a509417714d: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR (authored by hhb).
[lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR
Wed, Oct 9, 3:35 PM
hhb closed D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.
Wed, Oct 9, 3:34 PM · Restricted Project
hhb committed rL374250: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.
[lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR
Wed, Oct 9, 3:34 PM
hhb updated the diff for D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.

Simplify the path

Wed, Oct 9, 2:31 PM · Restricted Project
hhb updated the summary of D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.
Wed, Oct 9, 2:12 PM · Restricted Project
hhb added a comment to D68719: Fix issue when building with Visual Studio.

I think this is caused by D68442. Can you check whether D68728 fixes it?

Wed, Oct 9, 2:12 PM · Restricted Project
hhb updated the diff for D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.

Fix format

Wed, Oct 9, 2:07 PM · Restricted Project
hhb created D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.
Wed, Oct 9, 2:06 PM · Restricted Project

Mon, Oct 7

hhb committed rG0016b450bee8: [lldb] Reverts part of 61f471a (authored by hhb).
[lldb] Reverts part of 61f471a
Mon, Oct 7, 10:25 PM
hhb committed rL373998: [lldb] Reverts part of 61f471a.
[lldb] Reverts part of 61f471a
Mon, Oct 7, 10:25 PM
hhb committed rG61f471a705a5: [lldb] Unifying lldb python path (authored by hhb).
[lldb] Unifying lldb python path
Mon, Oct 7, 10:24 PM
hhb committed rL373991: [lldb] Unifying lldb python path.
[lldb] Unifying lldb python path
Mon, Oct 7, 10:24 PM
hhb closed D68442: [lldb] Unifying lldb python path.

This is merged as 61f471a and 0016b45. Closing...

Mon, Oct 7, 5:36 PM · Restricted Project
hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Reverts the change related to python dir for windows.

Mon, Oct 7, 5:09 PM · Restricted Project
hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Converts python output path to cmake format.

Mon, Oct 7, 4:10 PM · Restricted Project
hhb abandoned D67988: [lldb] clean up lldb/scripts a little bit.
Mon, Oct 7, 1:59 PM · Restricted Project
hhb added a comment to D68442: [lldb] Unifying lldb python path.

Cool work. I presume you've tested it. I can test it tomorrow if you need me to. However, I can do that after the commit.

Mon, Oct 7, 12:53 PM · Restricted Project
hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Fix comments

Mon, Oct 7, 12:47 PM · Restricted Project
hhb added inline comments to D68442: [lldb] Unifying lldb python path.
Mon, Oct 7, 12:47 PM · Restricted Project

Sat, Oct 5

hhb added inline comments to D68442: [lldb] Unifying lldb python path.
Sat, Oct 5, 10:00 AM · Restricted Project
hhb added inline comments to D68442: [lldb] Unifying lldb python path.
Sat, Oct 5, 9:50 AM · Restricted Project

Fri, Oct 4

hhb updated the summary of D68442: [lldb] Unifying lldb python path.
Fri, Oct 4, 5:39 PM · Restricted Project
hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Rebase

Fri, Oct 4, 5:39 PM · Restricted Project
hhb updated the summary of D68442: [lldb] Unifying lldb python path.
Fri, Oct 4, 5:39 PM · Restricted Project
hhb added reviewers for D68442: [lldb] Unifying lldb python path: labath, mgorny.
Fri, Oct 4, 5:23 PM · Restricted Project

Thu, Oct 3

hhb updated the diff for D68442: [lldb] Unifying lldb python path.

Fix description..

Thu, Oct 3, 9:52 PM · Restricted Project
hhb retitled D68442: [lldb] Unifying lldb python path from [lldb] Remove unused variables. to [lldb] Unifying lldb python path.
Thu, Oct 3, 9:52 PM · Restricted Project
hhb created D68442: [lldb] Unifying lldb python path.
Thu, Oct 3, 9:50 PM · Restricted Project
hhb updated the diff for D67988: [lldb] clean up lldb/scripts a little bit.

Fix comment

Thu, Oct 3, 4:31 PM · Restricted Project
hhb abandoned D67583: Fix swig python package path.
Thu, Oct 3, 4:20 PM · Restricted Project, Restricted Project
hhb committed rG48b38c93bc02: [lldb] Remove unused variables. (authored by hhb).
[lldb] Remove unused variables.
Thu, Oct 3, 2:56 PM
hhb committed rL373669: [lldb] Remove unused variables..
[lldb] Remove unused variables.
Thu, Oct 3, 2:55 PM
hhb committed rG958091c209d0: [lldb] Calculate relative path for symbol links (authored by hhb).
[lldb] Calculate relative path for symbol links
Thu, Oct 3, 2:52 PM
hhb committed rL373668: [lldb] Calculate relative path for symbol links.
[lldb] Calculate relative path for symbol links
Thu, Oct 3, 2:52 PM
hhb closed D67993: [lldb] Calculate relative path for symbol links.
Thu, Oct 3, 2:52 PM · Restricted Project, Restricted Project

Wed, Sep 25

hhb committed rGac3243c3e1fd: [lldb] Excludes private headers from SWIG dependency. (authored by hhb).
[lldb] Excludes private headers from SWIG dependency.
Wed, Sep 25, 11:19 AM
hhb committed rL372905: [lldb] Excludes private headers from SWIG dependency..
[lldb] Excludes private headers from SWIG dependency.
Wed, Sep 25, 11:16 AM
hhb closed D68040: [lldb] Excludes private headers from SWIG dependency..
Wed, Sep 25, 11:16 AM · Restricted Project, Restricted Project
hhb created D68040: [lldb] Excludes private headers from SWIG dependency..
Wed, Sep 25, 11:13 AM · Restricted Project, Restricted Project
hhb added inline comments to D68007: [lldb] Move swig call from python code to cmake.
Wed, Sep 25, 10:57 AM · Restricted Project, Restricted Project
hhb committed rG30a07d8f8edb: [lldb] Move swig call from python code to cmake (authored by hhb).
[lldb] Move swig call from python code to cmake
Wed, Sep 25, 9:37 AM
hhb committed rL372895: [lldb] Move swig call from python code to cmake.
[lldb] Move swig call from python code to cmake
Wed, Sep 25, 9:36 AM
hhb closed D68007: [lldb] Move swig call from python code to cmake.
Wed, Sep 25, 9:35 AM · Restricted Project, Restricted Project

Tue, Sep 24

hhb added a comment to D68007: [lldb] Move swig call from python code to cmake.

I'm kinda surprised we don't need site-packages path there after all.

Tue, Sep 24, 10:45 PM · Restricted Project, Restricted Project
hhb added a comment to D67993: [lldb] Calculate relative path for symbol links.

Yep, that's a change in the right direction. Have you (at least mentally) verified that it produces the correct path in all cases? I wouldn't trust the inputs being entirely correct.

Tue, Sep 24, 10:41 PM · Restricted Project, Restricted Project
hhb added a reviewer for D68007: [lldb] Move swig call from python code to cmake: JDevlieghere.
Tue, Sep 24, 8:58 PM · Restricted Project, Restricted Project
hhb updated the diff for D68007: [lldb] Move swig call from python code to cmake.

Format

Tue, Sep 24, 8:39 PM · Restricted Project, Restricted Project
hhb updated the diff for D68007: [lldb] Move swig call from python code to cmake.

Fix a typo

Tue, Sep 24, 8:33 PM · Restricted Project, Restricted Project
hhb created D68007: [lldb] Move swig call from python code to cmake.
Tue, Sep 24, 8:26 PM · Restricted Project, Restricted Project
hhb accepted D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib.
Tue, Sep 24, 8:18 PM · Restricted Project
hhb created D67993: [lldb] Calculate relative path for symbol links.
Tue, Sep 24, 3:30 PM · Restricted Project, Restricted Project
hhb created D67988: [lldb] clean up lldb/scripts a little bit.
Tue, Sep 24, 2:47 PM · Restricted Project
hhb abandoned D67942: Install python dll to bin.
Tue, Sep 24, 9:36 AM · Restricted Project
hhb added a comment to D67942: Install python dll to bin.

Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above.

Tue, Sep 24, 12:04 AM · Restricted Project

Mon, Sep 23

hhb created D67942: Install python dll to bin.
Mon, Sep 23, 5:43 PM · Restricted Project
hhb accepted D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW.
Mon, Sep 23, 3:38 PM · Restricted Project, Restricted Project
hhb added inline comments to D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib.
Mon, Sep 23, 2:55 PM · Restricted Project