Page MenuHomePhabricator

hhb (Haibo Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 29 2018, 3:41 PM (103 w, 3 d)

Recent Activity

Jun 1 2020

hhb added a comment to D80510: Update BFI when handling inlined landing / eh pad.
In D80510#2067617, @hhb wrote:
In D80510#2067484, @hhb wrote:
In D80510#2067446, @hhb wrote:

D75341 and comments there seem highly related.

Actually that change supposes to fix this kind of non-deterministic. Not sure why it does not work as intended.

We may still want to copy BFI when split BBs. But other concerns should have been solved by CallbackVH...

Huh.. added davidxl for more background, too, he remembered something along the lines of this non-determinism being addressed somehow (probably via the CallbackVH)

Aha it is simply because BFICallbackVH is new enough to not include in Android tree (that's what I test against). I will try again with latest llvm.

Jun 1 2020, 5:21 PM · Restricted Project
hhb added a comment to D80510: Update BFI when handling inlined landing / eh pad.
In D80510#2067484, @hhb wrote:
In D80510#2067446, @hhb wrote:

D75341 and comments there seem highly related.

Actually that change supposes to fix this kind of non-deterministic. Not sure why it does not work as intended.

We may still want to copy BFI when split BBs. But other concerns should have been solved by CallbackVH...

Huh.. added davidxl for more background, too, he remembered something along the lines of this non-determinism being addressed somehow (probably via the CallbackVH)

Jun 1 2020, 4:16 PM · Restricted Project
hhb added a comment to D80510: Update BFI when handling inlined landing / eh pad.
In D80510#2067446, @hhb wrote:

D75341 and comments there seem highly related.

Jun 1 2020, 3:11 PM · Restricted Project
hhb updated the summary of D80510: Update BFI when handling inlined landing / eh pad.
Jun 1 2020, 3:11 PM · Restricted Project
hhb added a reviewer for D80510: Update BFI when handling inlined landing / eh pad: mtrofin.
Jun 1 2020, 3:11 PM · Restricted Project
hhb added a comment to D80510: Update BFI when handling inlined landing / eh pad.

D75341 and comments there seem highly related.

Jun 1 2020, 3:11 PM · Restricted Project
hhb added a reviewer for D80510: Update BFI when handling inlined landing / eh pad: DaniilSuchkov.
Jun 1 2020, 3:11 PM · Restricted Project
hhb added a comment to D80510: Update BFI when handling inlined landing / eh pad.

Shouldn't this happen as part of BasicBlock::splitBasicBlock? Or probably BasicBlockUtils.cpp (llvm::SplitBlock).

There should also probably be a call to BlockFrequencyInfoImpl::forgetBlock that we're missing somewhere, that triggers this in the first place.

This is a good find, and I think we should identify the places that introduce fragility (i.e. deletions of BBs without telling BFI to forget - there seems to have been a design about this, BFICallbackVH, can't seem to find uses of it though)

I do want to put this into splitBasicBlock and other related functions. But it seems too intrusive. Consider the situation that all analysis passes adding a parameter to splitBasicBlock...

Jun 1 2020, 1:33 PM · Restricted Project

May 25 2020

hhb updated the diff for D80510: Update BFI when handling inlined landing / eh pad.

Revert to last version

May 25 2020, 6:13 PM · Restricted Project
hhb updated the diff for D80510: Update BFI when handling inlined landing / eh pad.

Don't output block name when a node is invalid: it is almost certainly fail.

May 25 2020, 5:41 PM · Restricted Project
hhb updated the diff for D80510: Update BFI when handling inlined landing / eh pad.

Rebase

May 25 2020, 12:51 PM · Restricted Project
hhb created D80510: Update BFI when handling inlined landing / eh pad.
May 25 2020, 2:38 AM · Restricted Project

May 20 2020

hhb committed rG780d7d77327c: [lldb] Allows customizing libxml2 for darwin (authored by hhb).
[lldb] Allows customizing libxml2 for darwin
May 20 2020, 12:38 PM
hhb committed rG04daba967031: [lldb] Cleans up system_libs (authored by hhb).
[lldb] Cleans up system_libs
May 20 2020, 12:38 PM
hhb closed D80257: [lldb] Allows customizing libxml2 for darwin.
May 20 2020, 12:38 PM · Restricted Project
hhb closed D80253: [lldb] Cleans up system_libs.
May 20 2020, 12:38 PM · Restricted Project

May 19 2020

hhb added reviewers for D80257: [lldb] Allows customizing libxml2 for darwin: labath, JDevlieghere.
May 19 2020, 5:38 PM · Restricted Project
hhb updated the diff for D80257: [lldb] Allows customizing libxml2 for darwin.

rebase

May 19 2020, 4:34 PM · Restricted Project
hhb updated the summary of D80257: [lldb] Allows customizing libxml2 for darwin.
May 19 2020, 4:34 PM · Restricted Project
hhb updated the diff for D80257: [lldb] Allows customizing libxml2 for darwin.

Remove endif()

May 19 2020, 4:34 PM · Restricted Project
hhb created D80257: [lldb] Allows customizing libxml2 for darwin.
May 19 2020, 4:34 PM · Restricted Project
hhb added reviewers for D80253: [lldb] Cleans up system_libs: labath, JDevlieghere.
May 19 2020, 4:00 PM · Restricted Project
hhb created D80253: [lldb] Cleans up system_libs.
May 19 2020, 3:27 PM · Restricted Project

May 16 2020

hhb accepted D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 16 2020, 12:07 AM · Restricted Project

May 8 2020

hhb requested changes to D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 8 2020, 10:32 PM · Restricted Project
hhb accepted D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 8 2020, 10:32 PM · Restricted Project

Feb 21 2020

hhb committed rG3ec3f62f0a0b: Allow customized relative PYTHONHOME (Attemp 1) (authored by hhb).
Allow customized relative PYTHONHOME (Attemp 1)
Feb 21 2020, 4:30 PM
hhb closed D74998: Allow customized relative PYTHONHOME (Attemp 1).
Feb 21 2020, 4:30 PM · Restricted Project
hhb created D74998: Allow customized relative PYTHONHOME (Attemp 1).
Feb 21 2020, 4:02 PM · Restricted Project
hhb committed rG0bb90628b5f7: Allow customized relative PYTHONHOME (authored by hhb).
Allow customized relative PYTHONHOME
Feb 21 2020, 12:56 PM
hhb closed D74727: Allow customized relative PYTHONHOME.
Feb 21 2020, 12:55 PM · Restricted Project

Feb 20 2020

hhb updated the diff for D74727: Allow customized relative PYTHONHOME.

The code should check on LLDB_EMBED_PYTHON_HOME

Feb 20 2020, 5:05 PM · Restricted Project
hhb added a reviewer for D74917: [lldb/cmake] Enable more verbose find_package output.: JDevlieghere.
Feb 20 2020, 3:52 PM · Restricted Project
hhb updated the diff for D74727: Allow customized relative PYTHONHOME.

Move option() into if

Feb 20 2020, 2:39 PM · Restricted Project

Feb 19 2020

hhb updated the diff for D74727: Allow customized relative PYTHONHOME.

Rename LLDB_RELOCATABLE_PYTHON to LLDB_EMBED_PYTHON_HOME.

Feb 19 2020, 1:29 PM · Restricted Project

Feb 18 2020

hhb added inline comments to D74727: Allow customized relative PYTHONHOME.
Feb 18 2020, 11:02 AM · Restricted Project
hhb added a comment to D74727: Allow customized relative PYTHONHOME.

Can we maybe rename it to something like that?

Feb 18 2020, 10:53 AM · Restricted Project
hhb updated the diff for D74727: Allow customized relative PYTHONHOME.

Fix comments.

Feb 18 2020, 10:53 AM · Restricted Project
hhb updated the diff for D74727: Allow customized relative PYTHONHOME.

Fix comments

Feb 18 2020, 10:44 AM · Restricted Project

Feb 17 2020

hhb added a reviewer for D74727: Allow customized relative PYTHONHOME: JDevlieghere.
Feb 17 2020, 7:19 PM · Restricted Project
hhb created D74727: Allow customized relative PYTHONHOME.
Feb 17 2020, 9:45 AM · Restricted Project
hhb added a reviewer for D74727: Allow customized relative PYTHONHOME: labath.
Feb 17 2020, 9:45 AM · Restricted Project
hhb updated the summary of D74727: Allow customized relative PYTHONHOME.
Feb 17 2020, 9:45 AM · Restricted Project

Nov 7 2019

hhb added a comment to D69931: Add rpath to liblldb so vendors can ship their own python framework (or others).

In principle, this looks pretty similar to D67942, and my opinion on it is the same -- I don't think we should be in the business of trying to package the transitive set of lldb dependencies. I think the lldb install target should install the stuff that it has built itself, and the rest should be up to some higher level packaging system.

Nov 7 2019, 3:04 PM · Restricted Project
hhb closed D69630: [lldb] Record framework build path and use it everywhere.
Nov 7 2019, 3:04 PM · Restricted Project

Nov 6 2019

hhb committed rG77a60f0df673: [lldb] Record framework build path and use it everywhere (authored by hhb).
[lldb] Record framework build path and use it everywhere
Nov 6 2019, 2:11 PM
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

@hhb I just did, and get the same error as well :(
ninja: error: 'bin/LLDB.framework/LLDB', needed by 'bin/LLDB.framework/Resources/Python/lldb/_lldb.so', missing and no known rule to make it

Nov 6 2019, 12:48 PM · Restricted Project

Nov 5 2019

hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

@hhb fwiw, I still get the same error with this diff (after applying it on top of D69834). But D69834 by itself works great!

Nov 5 2019, 3:42 PM · Restricted Project
hhb updated the diff for D69589: [lldb] Refactor all POST_BUILD commands into targets.

Fix some naming

Nov 5 2019, 3:33 PM · Restricted Project
hhb updated the diff for D69589: [lldb] Refactor all POST_BUILD commands into targets.

Rebase

Nov 5 2019, 1:43 PM · Restricted Project
hhb committed rG6a79e083a0d1: [lldb] Add a install target for lldb python on darwin (authored by hhb).
[lldb] Add a install target for lldb python on darwin
Nov 5 2019, 1:34 PM
hhb closed D69834: [lldb] Add a install target for lldb python on darwin.
Nov 5 2019, 1:34 PM · Restricted Project
hhb updated the diff for D69834: [lldb] Add a install target for lldb python on darwin.

Rebase

Nov 5 2019, 1:34 PM · Restricted Project

Nov 4 2019

hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

Sent D69834. Haven't get a chance to test but you can see the idea...

Nov 4 2019, 5:09 PM · Restricted Project
hhb created D69834: [lldb] Add a install target for lldb python on darwin.
Nov 4 2019, 5:06 PM · Restricted Project
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

See D68370. We probably need to do the same thing for darwin...

Nov 4 2019, 5:06 PM · Restricted Project
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

Alternatively we should not depends on install-liblldb to install python packages, but have a install command similar to what we did below for other platforms.

Nov 4 2019, 4:29 PM · Restricted Project
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

I fixed this locally by doing this (this fix doesn't really feel good but not sure what's the best way to do it):

Nov 4 2019, 4:20 PM · Restricted Project

Oct 30 2019

hhb updated the diff for D69589: [lldb] Refactor all POST_BUILD commands into targets.

When creating symlink, make the target depends on relative target path. So that if the target file doesn't exist, the build will fail.

Oct 30 2019, 5:14 PM · Restricted Project
hhb updated the diff for D69630: [lldb] Record framework build path and use it everywhere.

Fix

Oct 30 2019, 1:34 PM · Restricted Project
hhb updated the diff for D69630: [lldb] Record framework build path and use it everywhere.

Update one more place

Oct 30 2019, 11:21 AM · Restricted Project
hhb created D69630: [lldb] Record framework build path and use it everywhere.
Oct 30 2019, 10:41 AM · Restricted Project
hhb added a comment to D69589: [lldb] Refactor all POST_BUILD commands into targets.

This looks reasonable to me. I'm just wondering, now that these are separate targets, I guess that means they can be run in random order, right? Will that cause any problems, for instance when creating a package and its subpackage (formatters and formatters/cpp maybe)?

Oct 30 2019, 10:02 AM · Restricted Project

Oct 29 2019

hhb created D69589: [lldb] Refactor all POST_BUILD commands into targets.
Oct 29 2019, 3:31 PM · Restricted Project

Oct 28 2019

hhb committed rG99046b873f7f: [lldb] move package generation from python to cmake (authored by hhb).
[lldb] move package generation from python to cmake
Oct 28 2019, 5:53 PM
hhb closed D69019: [lldb] move package generation from python to cmake.
Oct 28 2019, 5:53 PM · Restricted Project
hhb updated the diff for D69019: [lldb] move package generation from python to cmake.

Rebase

Oct 28 2019, 4:51 PM · Restricted Project

Oct 27 2019

hhb added a comment to D69019: [lldb] move package generation from python to cmake.

Right. I see what you mean.

But... does this have to happen at build time? Since the list of files is already known at configuration time, you should be able to generate the files in the "cmake" step (but still leave the copying for the build step, so that any changes to the files are reflected in rebuilds).

(I'm not insisting on that -- I think that the current patch is already much better than what we had before. If you think that the python script is better than that, feel free to say so.)

Oct 27 2019, 4:41 PM · Restricted Project

Oct 25 2019

hhb added a comment to D69019: [lldb] move package generation from python to cmake.

I'm sorry, this dropped off my radar. The only question I have here is about the createPythonInit.py script. If we're moving stuff to cmake, I am wondering if we shouldn't move that thing too? It doesn't look like the code is doing anything which would be hard to replicate in cmake. WDYT ?

Oct 25 2019, 4:11 PM · Restricted Project

Oct 16 2019

hhb committed rG1d4a40751ff3: [lldb] move more things from python to cmake (authored by hhb).
[lldb] move more things from python to cmake
Oct 16 2019, 11:06 AM
hhb committed rL375024: [lldb] move more things from python to cmake.
[lldb] move more things from python to cmake
Oct 16 2019, 11:05 AM
hhb closed D69016: [lldb] move more things from python to cmake.
Oct 16 2019, 11:05 AM · Restricted Project
hhb added a reviewer for D69019: [lldb] move package generation from python to cmake: labath.
Oct 16 2019, 11:05 AM · Restricted Project
hhb updated the diff for D69019: [lldb] move package generation from python to cmake.

Format

Oct 16 2019, 11:05 AM · Restricted Project
hhb updated the diff for D69019: [lldb] move package generation from python to cmake.

Rebase

Oct 16 2019, 11:05 AM · Restricted Project
hhb added a comment to D69016: [lldb] move more things from python to cmake.

I'm not sure if I like the usage of POST_BUILD stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines.

Oct 16 2019, 9:50 AM · Restricted Project

Oct 15 2019

hhb created D69019: [lldb] move package generation from python to cmake.
Oct 15 2019, 10:25 PM · Restricted Project
hhb planned changes to D69019: [lldb] move package generation from python to cmake.
Oct 15 2019, 10:25 PM · Restricted Project
hhb created D69016: [lldb] move more things from python to cmake.
Oct 15 2019, 8:18 PM · Restricted Project
hhb committed rL374968: Request commit access for hhb.
Request commit access for hhb
Oct 15 2019, 7:38 PM
hhb committed rG208e9c01fc09: [lldb] Creates _liblldb symlink from cmake (authored by hhb).
[lldb] Creates _liblldb symlink from cmake
Oct 15 2019, 3:00 PM
hhb committed rL374953: [lldb] Creates _liblldb symlink from cmake.
[lldb] Creates _liblldb symlink from cmake
Oct 15 2019, 3:00 PM
hhb closed D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 15 2019, 3:00 PM · Restricted Project
hhb added a comment to D68910: python path should be platform-dependent.

One additional statement in openSUSE comparing to standard python:

libdir = plat_specific and get_config_var("platlibdir") or "lib"
Oct 15 2019, 2:51 PM · Restricted Project
hhb added a comment to D68910: python path should be platform-dependent.
Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import distutils.sysconfig
>>> print(distutils.sysconfig.get_python_lib(True, False, ''))
lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(True, False, '/abc'))
/abc/lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(True, False))
/usr/lib64/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False, ''))
lib/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False, '/abc'))
/abc/lib/python3.6/site-packages
>>> print(distutils.sysconfig.get_python_lib(False, False))
/usr/lib/python3.6/site-packages

This is interesting...

Oct 15 2019, 2:41 PM · Restricted Project
hhb accepted D68910: python path should be platform-dependent.

How about this one?

Oct 15 2019, 2:23 PM · Restricted Project
hhb added a comment to D68858: [lldb] Creates _liblldb symlink from cmake.

Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode.

Oct 15 2019, 10:49 AM · Restricted Project
hhb requested changes to D68910: python path should be platform-dependent.

Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change...

Oct 15 2019, 10:48 AM · Restricted Project

Oct 14 2019

hhb added inline comments to D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 14 2019, 10:34 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Oops fix typo.

Oct 14 2019, 9:48 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix the build for multi-config generator.

Oct 14 2019, 9:36 PM · Restricted Project
hhb planned changes to D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 14 2019, 1:06 PM · Restricted Project

Oct 11 2019

hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Adds VERBATIM

Oct 11 2019, 4:23 PM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix typo

Oct 11 2019, 11:55 AM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix file copy path

Oct 11 2019, 11:55 AM · Restricted Project
hhb updated the diff for D68858: [lldb] Creates _liblldb symlink from cmake.

Fix file copy path

Oct 11 2019, 11:55 AM · Restricted Project
hhb added inline comments to D68719: Fix issue when building with Visual Studio.
Oct 11 2019, 11:37 AM · Restricted Project
hhb added reviewers for D68858: [lldb] Creates _liblldb symlink from cmake: labath, jingham, tatyana-krasnukha.
Oct 11 2019, 11:37 AM · Restricted Project
hhb committed rG6aacd9687543: [lldb] Fix python packages install path (authored by hhb).
[lldb] Fix python packages install path
Oct 11 2019, 10:43 AM
hhb closed D68878: [lldb] Fix python packages install path.
Oct 11 2019, 10:43 AM · Restricted Project