Page MenuHomePhabricator

[LLDB] Add a void* cast when passing object pointers to printf %p
ClosedPublic

Authored by mstorsjo on Sun, Sep 22, 12:24 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sun, Sep 22, 12:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Sep 22, 12:24 PM
labath accepted this revision.Mon, Sep 23, 4:06 AM

This looks fine. When you see a pattern like if(log) { LLDB_LOGF(...) }, feel free to delete the surrounding if(log). It is no longer necessary, and the reason it is still there is simply because Jonas's vim script wasn't smart enough to delete it in some cases.

This revision is now accepted and ready to land.Mon, Sep 23, 4:06 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Sep 23, 5:03 AM