This is an archive of the discontinued LLVM Phabricator instance.

Fix missed case of switching getConstant to getTargetConstant. Try 2.
ClosedPublic

Authored by saugustine on Sep 20 2019, 11:19 AM.

Diff Detail

Event Timeline

saugustine created this revision.Sep 20 2019, 11:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2019, 11:19 AM
RKSimon added a subscriber: RKSimon.

The test file doesn't look like it needs GlobalIsel - rename it llvm/test/CodeGen/X86/isel-blendi-gettargetconstant.ll

llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll
1

RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=sse4.2 | FileCheck %s

And then run the file through the utils/update_llc_test_checks.py script

3

Remove #0

12

Remove this

arsenm added inline comments.Sep 20 2019, 11:42 AM
llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll
1

This is not a GlobalISel test, and should not go in the GlobalISel directory

saugustine marked 2 inline comments as done.

Addressing comments.

saugustine marked 3 inline comments as done.Sep 20 2019, 11:50 AM
saugustine marked an inline comment as done.Sep 20 2019, 11:52 AM
saugustine added inline comments.
llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll
1

Where should it go?

I'm inclined just to drop the test case altogether. Most of the other code paths that needed the switch from getConstant to getTargetConstant don't have test cases either.

craig.topper added inline comments.Sep 20 2019, 11:57 AM
llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll
1

This shouldn't be in the GlobalISel directory. It doesn't enable GlobalIsel.

1

It can just go in test/CodeGen/X86. That's where all the SelectionDAG based tests are. Only tests that enable the non-default global instruction selection should be in the GlobalISel subdirectory.

Move test case out of GlobalISel.

saugustine marked an inline comment as done.Sep 20 2019, 12:21 PM
echristo accepted this revision.Sep 20 2019, 12:22 PM

Looks much better, but then again I approved the last one ;)

Let's let Craig or Simon give an ack too.

This revision is now accepted and ready to land.Sep 20 2019, 12:22 PM

We've been blocked on this for a day now, so going ahead and checking it in. Will wait and watch for problems.

This revision was automatically updated to reflect the committed changes.