Page MenuHomePhabricator

Can't pass .dSYM directory to llvm-objdump -dsym= (and error message is wrong)
ClosedPublic

Authored by mtrent on Sep 19 2019, 5:41 PM.

Details

Summary

Allow users to pass the path to a .dSYM directory to llvm-objdump's -dsym
flag rather than requiring users to find the DWARF DSYM Mach-O within the
bundle structure by hand.

rdar://46873333

Diff Detail

Repository
rL LLVM

Event Timeline

mtrent created this revision.Sep 19 2019, 5:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2019, 5:41 PM
pete accepted this revision.Sep 19 2019, 9:23 PM

LGTM

This revision is now accepted and ready to land.Sep 19 2019, 9:23 PM
MaskRay added inline comments.
tools/llvm-objdump/MachODump.cpp
7345 ↗(On Diff #220925)

if -> If

7354 ↗(On Diff #220925)

load -> Load. And append a full stop.

aprantl added inline comments.Sep 20 2019, 9:32 AM
tools/llvm-objdump/MachODump.cpp
7350 ↗(On Diff #220925)

sys::path::append() is slightly more portable over hardcoding the path separators. Not sure if anyone would ever want to run this on Windows...

mtrent updated this revision to Diff 221061.Sep 20 2019, 10:35 AM

Updating to use path::append to build the bundle contents string.

mtrent updated this revision to Diff 221063.Sep 20 2019, 10:38 AM
mtrent marked an inline comment as done.

mechanical comment changes

mtrent marked 2 inline comments as done.Sep 20 2019, 10:38 AM
aprantl accepted this revision.Sep 20 2019, 10:59 AM
This revision was automatically updated to reflect the committed changes.