Page MenuHomePhabricator

Scrub FileCheck regex delimiters from test checks
Needs RevisionPublic

Authored by greened on Sep 18 2019, 12:22 PM.

Details

Summary

It's quite common for ScalarEvolution to emit a "{{" sequence, which FileCheck
will interpret as the start of a regular expression. Escape such patterns so
that we can correctly match them in the auto-generated checks.

Diff Detail

Event Timeline

greened created this revision.Sep 18 2019, 12:22 PM

Is there a suitable test case change?

Is there a suitable test case change?

Are there tests for this tool? I ran into this issue with some downstream testing. I could mock-up a testcase but where does it go?

I could mock-up a testcase but where does it go?

As you mentioned SCEV, you can add new/update test for SCEV. But I dont think this "step" is required.

I could mock-up a testcase but where does it go?

As you mentioned SCEV, you can add new/update test for SCEV. But I dont think this "step" is required.

So, that leaves me with a question. What else needs to be done before getting this committed?

I could mock-up a testcase but where does it go?

As you mentioned SCEV, you can add new/update test for SCEV. But I dont think this "step" is required.

So, that leaves me with a question. What else needs to be done before getting this committed?

Ping.

Is there a suitable test case change?

Are there tests for this tool? I ran into this issue with some downstream testing. I could mock-up a testcase but where does it go?

You can attach a minimalist example with generated CHECK lines before/after this change in the summary. Logic in this script is very tricky and such examples in the git logs will be very helpful to a future poor soul hacking the source.

MaskRay requested changes to this revision.Apr 28 2021, 4:24 PM
This revision now requires changes to proceed.Apr 28 2021, 4:24 PM