Page MenuHomePhabricator

[clang] [unittest] Import LLVMTestingSupport if necessary
ClosedPublic

Authored by mgorny on Sep 11 2019, 9:51 AM.

Details

Summary

Add LLVMTestingSupport directory from LLVM_MAIN_SRC_DIR when building
clang stand-alone and LLVMTestingSupport library is not present. This
is needed to fix stand-alone builds without clang-tools-extra.

// The code is copied verbatim from clangd unittests

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Sep 11 2019, 9:51 AM
gribozavr accepted this revision.Sep 12 2019, 2:58 AM

Thanks for the fix! I'm not a fan of the complexity that standalone builds create, but if we are supporting them... oh well.

This revision is now accepted and ready to land.Sep 12 2019, 2:58 AM

Thanks. Could you also ack the backport in https://bugs.llvm.org/show_bug.cgi?id=43281?

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2019, 6:05 AM