Page MenuHomePhabricator

[PowerPC][NFC] Update test assertions using update_llc_test_checks.py
ClosedPublic

Authored by lkail on Sep 7 2019, 5:36 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

lkail created this revision.Sep 7 2019, 5:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2019, 5:36 AM
Higuoxing added inline comments.Sep 7 2019, 5:54 AM
llvm/test/CodeGen/PowerPC/store-combine.ll
238 ↗(On Diff #219238)

Thanks, I'm not familiar with PowerPC instructions. What's your purpose by removing these two check points? It's useless or you will fix the typo later?

lkail marked an inline comment as done.Sep 7 2019, 6:05 AM
lkail added inline comments.
llvm/test/CodeGen/PowerPC/store-combine.ll
238 ↗(On Diff #219238)

This test has been declared NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py. Re-running update_llc_test_checks.py, seems these two instructions should not appear. I've also added original author as a reviewer to see if some CHECK-NOT directives shall keep or not.

Higuoxing added inline comments.Sep 7 2019, 6:43 AM
llvm/test/CodeGen/PowerPC/store-combine.ll
238 ↗(On Diff #219238)

Ok, I got it. Thanks a lot.

LGTM.
If we are producing the checks with the script, we should refrain from manually changing them as any future updates to the test will make it very difficult to determine whether the change is intended or not.

nemanjai accepted this revision.Sep 9 2019, 5:00 AM

Forgot to select Accept.

This revision is now accepted and ready to land.Sep 9 2019, 5:00 AM
This revision was automatically updated to reflect the committed changes.