This is an archive of the discontinued LLVM Phabricator instance.

Differential D67263

[DwarfExpression] Disallow some rewrites to avoid undefined behavior
ClosedPublic

Authored by bjope on Sep 6 2019, 4:46 AM.

Details

Reviewers
sdesmalen
rnk
JDevlieghere
Commits
rG2b698a13a11e: [DwarfExpression] Disallow some rewrites to avoid undefined behavior
rL371304: [DwarfExpression] Disallow some rewrites to avoid undefined behavior
Summary

The value operand in DW_OP_plus_uconst/DW_OP_constu value can be
large (it uses uint64_t as representation internally in LLVM).
This means that in the uint64_t to int conversions, previously done
by DwarfExpression::addMachineRegExpression, could lose information.
Also, the negation done in "-Offset" was undefined behavior in case
Offset was exactly INT_MIN.

To avoid the above problems, we now avoid transformation like
[Reg, DW_OP_plus_uconst, Offset] --> [DW_OP_breg, Offset]
and
[Reg, DW_OP_constu, Offset, DW_OP_plus] --> [DW_OP_breg, Offset]
when Offset > INT_MAX.

And we avoid to transform
[Reg, DW_OP_constu, Offset, DW_OP_minus] --> [DW_OP_breg,-Offset]
when Offset > INT_MAX+1.

The patch also adjusts DwarfCompileUnit::constructVariableDIEImpl
to make sure that "DW_OP_constu, Offset, DW_OP_minus" is used
instead of "DW_OP_plus_uconst, Offset" when creating DIExpressions
with negative frame index offsets.

Notice that this might just be the tip of the iceberg. There
are lots of fishy handling related to these constants. I think both
DIExpression::appendOffset and DIExpression::extractIfOffset may
trigger undefined behavior for certain values.

Diff Detail

Repository
rL LLVM

Event Timeline

bjope created this revision.Sep 6 2019, 4:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2019, 4:46 AM
Herald added subscribers: ychen, hiraditya, aprantl. · View Herald Transcript
Harbormaster completed remote builds in B37837: Diff 219062.Sep 6 2019, 4:47 AM
bjope marked an inline comment as done.Sep 6 2019, 5:14 AM
bjope added inline comments.
llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
650 ↗(On Diff #219062)

This fix was (the minimum) needed to make other lit tests pass. I.e not ending up with huge unsigned offsets in DW_OP_plus_uconst or DW_OP_plus resulting in changes in DWARF output.

So the "regressions" seen in the added dw_op_constu.mir test case are not supposed to happen in reality (as long as we use DW_OP_minus when having negative offsets).

JDevlieghere added inline comments.Sep 6 2019, 9:00 AM
llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
284 ↗(On Diff #219062)

We should use C++ style casts and std::numeric_limits.

bjope updated this revision to Diff 219131.Sep 6 2019, 9:55 AM

Now using std::numeric_limits and C++ style casts (thanks JDevlieghere!).

Also updated checks in test/DebugInfo/NVPTX/dbg-declare-alloca.ll. By using DIExpression::appendOffset in DwarfCompileUnit::constructVariableDIEImpl we now get rid of an, afaict, useless "DW_OP_add_uconst 0".

Herald added a subscriber: jholewinski. · View Herald TranscriptSep 6 2019, 9:55 AM
bjope marked an inline comment as done.Sep 6 2019, 9:55 AM
Harbormaster completed remote builds in B37857: Diff 219131.Sep 6 2019, 9:58 AM
JDevlieghere accepted this revision.Sep 6 2019, 10:06 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 6 2019, 10:06 AM
Closed by commit rL371304: [DwarfExpression] Disallow some rewrites to avoid undefined behavior (authored by bjope). · Explain WhySep 7 2019, 4:39 AM
This revision was automatically updated to reflect the committed changes.
aprantl added inline comments.Sep 9 2019, 2:14 PM
llvm/trunk/test/DebugInfo/X86/dw_op_constu.mir
285

We should fix the comment printer to emit very large constants as hex...

Revision Contents

PathSize
llvm/
trunk/
lib/
CodeGen/
AsmPrinter/
3 lines
20 lines
test/
DebugInfo/
NVPTX/
22 lines
X86/
151 lines

Diff 219231

llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp

Show First 20 Lines • Show All 641 Lines • ▼ Show 20 LinesDIE *DwarfCompileUnit::constructVariableDIEImpl(const DbgVariable &DV,
DIEDwarfExpression DwarfExpr(*Asm, *this, *Loc); DIEDwarfExpression DwarfExpr(*Asm, *this, *Loc);
for (auto &Fragment : DV.getFrameIndexExprs()) { for (auto &Fragment : DV.getFrameIndexExprs()) {
unsigned FrameReg = 0; unsigned FrameReg = 0;
const DIExpression *Expr = Fragment.Expr; const DIExpression *Expr = Fragment.Expr;
const TargetFrameLowering *TFI = Asm->MF->getSubtarget().getFrameLowering(); const TargetFrameLowering *TFI = Asm->MF->getSubtarget().getFrameLowering();
int Offset = TFI->getFrameIndexReference(*Asm->MF, Fragment.FI, FrameReg); int Offset = TFI->getFrameIndexReference(*Asm->MF, Fragment.FI, FrameReg);
DwarfExpr.addFragmentOffset(Expr); DwarfExpr.addFragmentOffset(Expr);
SmallVector<uint64_t, 8> Ops; SmallVector<uint64_t, 8> Ops;
Ops.push_back(dwarf::DW_OP_plus_uconst); DIExpression::appendOffset(Ops, Offset);
Ops.push_back(Offset);
// According to // According to
// https://docs.nvidia.com/cuda/archive/10.0/ptx-writers-guide-to-interoperability/index.html#cuda-specific-dwarf // https://docs.nvidia.com/cuda/archive/10.0/ptx-writers-guide-to-interoperability/index.html#cuda-specific-dwarf
// cuda-gdb requires DW_AT_address_class for all variables to be able to // cuda-gdb requires DW_AT_address_class for all variables to be able to
// correctly interpret address space of the variable address. // correctly interpret address space of the variable address.
// Decode DW_OP_constu <DWARF Address Space> DW_OP_swap DW_OP_xderef // Decode DW_OP_constu <DWARF Address Space> DW_OP_swap DW_OP_xderef
// sequence for the NVPTX + gdb target. // sequence for the NVPTX + gdb target.
unsigned LocalNVPTXAddressSpace; unsigned LocalNVPTXAddressSpace;
if (Asm->TM.getTargetTriple().isNVPTX() && DD->tuneForGDB()) { if (Asm->TM.getTargetTriple().isNVPTX() && DD->tuneForGDB()) {
▲ Show 20 Lines • Show All 672 Lines • Show Last 20 Lines

llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.cpp

Show First 20 Lines • Show All 274 Lines • ▼ Show 20 Linesbool DwarfExpression::addMachineRegExpression(const TargetRegisterInfo &TRI,
auto Reg = DwarfRegs[0]; auto Reg = DwarfRegs[0];
bool FBReg = isFrameRegister(TRI, MachineReg); bool FBReg = isFrameRegister(TRI, MachineReg);
int SignedOffset = 0; int SignedOffset = 0;
assert(Reg.Size == 0 && "subregister has same size as superregister"); assert(Reg.Size == 0 && "subregister has same size as superregister");
// Pattern-match combinations for which more efficient representations exist. // Pattern-match combinations for which more efficient representations exist.
// [Reg, DW_OP_plus_uconst, Offset] --> [DW_OP_breg, Offset]. // [Reg, DW_OP_plus_uconst, Offset] --> [DW_OP_breg, Offset].
if (Op && (Op->getOp() == dwarf::DW_OP_plus_uconst)) { if (Op && (Op->getOp() == dwarf::DW_OP_plus_uconst)) {
SignedOffset = Op->getArg(0); uint64_t Offset = Op->getArg(0);
uint64_t IntMax = static_cast<uint64_t>(std::numeric_limits<int>::max());
if (Offset <= IntMax) {
SignedOffset = Offset;
ExprCursor.take(); ExprCursor.take();
} }
}
// [Reg, DW_OP_constu, Offset, DW_OP_plus] --> [DW_OP_breg, Offset] // [Reg, DW_OP_constu, Offset, DW_OP_plus] --> [DW_OP_breg, Offset]
// [Reg, DW_OP_constu, Offset, DW_OP_minus] --> [DW_OP_breg,-Offset] // [Reg, DW_OP_constu, Offset, DW_OP_minus] --> [DW_OP_breg,-Offset]
// If Reg is a subregister we need to mask it out before subtracting. // If Reg is a subregister we need to mask it out before subtracting.
if (Op && Op->getOp() == dwarf::DW_OP_constu) { if (Op && Op->getOp() == dwarf::DW_OP_constu) {
uint64_t Offset = Op->getArg(0);
uint64_t IntMax = static_cast<uint64_t>(std::numeric_limits<int>::max());
auto N = ExprCursor.peekNext(); auto N = ExprCursor.peekNext();
if (N && (N->getOp() == dwarf::DW_OP_plus || if (N && N->getOp() == dwarf::DW_OP_plus && Offset <= IntMax) {
(N->getOp() == dwarf::DW_OP_minus && !SubRegisterSizeInBits))) { SignedOffset = Offset;
int Offset = Op->getArg(0); ExprCursor.consume(2);
SignedOffset = (N->getOp() == dwarf::DW_OP_minus) ? -Offset : Offset; } else if (N && N->getOp() == dwarf::DW_OP_minus &&
!SubRegisterSizeInBits && Offset <= IntMax + 1) {
SignedOffset = -static_cast<int64_t>(Offset);
ExprCursor.consume(2); ExprCursor.consume(2);
} }
} }
if (FBReg) if (FBReg)
addFBReg(SignedOffset); addFBReg(SignedOffset);
else else
addBReg(Reg.DwarfRegNo, SignedOffset); addBReg(Reg.DwarfRegNo, SignedOffset);
▲ Show 20 Lines • Show All 241 Lines • Show Last 20 Lines

llvm/trunk/test/DebugInfo/NVPTX/dbg-declare-alloca.ll

Show First 20 Lines • Show All 119 Lines • ▼ Show 20 Lines
; CHECK-NEXT: .b8 11 // DW_AT_byte_size ; CHECK-NEXT: .b8 11 // DW_AT_byte_size
; CHECK-NEXT: .b8 11 // DW_FORM_data1 ; CHECK-NEXT: .b8 11 // DW_FORM_data1
; CHECK-NEXT: .b8 0 // EOM(1) ; CHECK-NEXT: .b8 0 // EOM(1)
; CHECK-NEXT: .b8 0 // EOM(2) ; CHECK-NEXT: .b8 0 // EOM(2)
; CHECK-NEXT: .b8 0 // EOM(3) ; CHECK-NEXT: .b8 0 // EOM(3)
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: .section .debug_info ; CHECK-NEXT: .section .debug_info
; CHECK-NEXT: { ; CHECK-NEXT: {
; CHECK-NEXT: .b32 136 // Length of Unit ; CHECK-NEXT: .b32 134 // Length of Unit
; CHECK-NEXT: .b8 2 // DWARF version number ; CHECK-NEXT: .b8 2 // DWARF version number
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b32 .debug_abbrev // Offset Into Abbrev. Section ; CHECK-NEXT: .b32 .debug_abbrev // Offset Into Abbrev. Section
; CHECK-NEXT: .b8 8 // Address Size (in bytes) ; CHECK-NEXT: .b8 8 // Address Size (in bytes)
; CHECK-NEXT: .b8 1 // Abbrev [1] 0xb:0x81 DW_TAG_compile_unit ; CHECK-NEXT: .b8 1 // Abbrev [1] 0xb:0x7f DW_TAG_compile_unit
; CHECK-NEXT: .b8 99 // DW_AT_producer ; CHECK-NEXT: .b8 99 // DW_AT_producer
; CHECK-NEXT: .b8 108 ; CHECK-NEXT: .b8 108
; CHECK-NEXT: .b8 97 ; CHECK-NEXT: .b8 97
; CHECK-NEXT: .b8 110 ; CHECK-NEXT: .b8 110
; CHECK-NEXT: .b8 103 ; CHECK-NEXT: .b8 103
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b8 12 // DW_AT_language ; CHECK-NEXT: .b8 12 // DW_AT_language
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b8 116 // DW_AT_name ; CHECK-NEXT: .b8 116 // DW_AT_name
; CHECK-NEXT: .b8 46 ; CHECK-NEXT: .b8 46
; CHECK-NEXT: .b8 99 ; CHECK-NEXT: .b8 99
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b32 .debug_line // DW_AT_stmt_list ; CHECK-NEXT: .b32 .debug_line // DW_AT_stmt_list
; CHECK-NEXT: .b8 116 // DW_AT_comp_dir ; CHECK-NEXT: .b8 116 // DW_AT_comp_dir
; CHECK-NEXT: .b8 101 ; CHECK-NEXT: .b8 101
; CHECK-NEXT: .b8 115 ; CHECK-NEXT: .b8 115
; CHECK-NEXT: .b8 116 ; CHECK-NEXT: .b8 116
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b64 Lfunc_begin0 // DW_AT_low_pc ; CHECK-NEXT: .b64 Lfunc_begin0 // DW_AT_low_pc
; CHECK-NEXT: .b64 Lfunc_end0 // DW_AT_high_pc ; CHECK-NEXT: .b64 Lfunc_end0 // DW_AT_high_pc
; CHECK-NEXT: .b8 2 // Abbrev [2] 0x31:0x3e DW_TAG_subprogram ; CHECK-NEXT: .b8 2 // Abbrev [2] 0x31:0x3c DW_TAG_subprogram
; CHECK-NEXT: .b64 Lfunc_begin0 // DW_AT_low_pc ; CHECK-NEXT: .b64 Lfunc_begin0 // DW_AT_low_pc
; CHECK-NEXT: .b64 Lfunc_end0 // DW_AT_high_pc ; CHECK-NEXT: .b64 Lfunc_end0 // DW_AT_high_pc
; CHECK-NEXT: .b8 1 // DW_AT_frame_base ; CHECK-NEXT: .b8 1 // DW_AT_frame_base
; CHECK-NEXT: .b8 156 ; CHECK-NEXT: .b8 156
; CHECK-NEXT: .b8 117 // DW_AT_name ; CHECK-NEXT: .b8 117 // DW_AT_name
; CHECK-NEXT: .b8 115 ; CHECK-NEXT: .b8 115
; CHECK-NEXT: .b8 101 ; CHECK-NEXT: .b8 101
; CHECK-NEXT: .b8 95 ; CHECK-NEXT: .b8 95
; CHECK-NEXT: .b8 100 ; CHECK-NEXT: .b8 100
; CHECK-NEXT: .b8 98 ; CHECK-NEXT: .b8 98
; CHECK-NEXT: .b8 103 ; CHECK-NEXT: .b8 103
; CHECK-NEXT: .b8 95 ; CHECK-NEXT: .b8 95
; CHECK-NEXT: .b8 100 ; CHECK-NEXT: .b8 100
; CHECK-NEXT: .b8 101 ; CHECK-NEXT: .b8 101
; CHECK-NEXT: .b8 99 ; CHECK-NEXT: .b8 99
; CHECK-NEXT: .b8 108 ; CHECK-NEXT: .b8 108
; CHECK-NEXT: .b8 97 ; CHECK-NEXT: .b8 97
; CHECK-NEXT: .b8 114 ; CHECK-NEXT: .b8 114
; CHECK-NEXT: .b8 101 ; CHECK-NEXT: .b8 101
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b8 1 // DW_AT_decl_file ; CHECK-NEXT: .b8 1 // DW_AT_decl_file
; CHECK-NEXT: .b8 3 // DW_AT_decl_line ; CHECK-NEXT: .b8 3 // DW_AT_decl_line
; CHECK-NEXT: .b8 1 // DW_AT_prototyped ; CHECK-NEXT: .b8 1 // DW_AT_prototyped
; CHECK-NEXT: .b8 1 // DW_AT_external ; CHECK-NEXT: .b8 1 // DW_AT_external
; CHECK-NEXT: .b8 3 // Abbrev [3] 0x58:0x16 DW_TAG_variable ; CHECK-NEXT: .b8 3 // Abbrev [3] 0x58:0x14 DW_TAG_variable
; CHECK-NEXT: .b8 6 // DW_AT_address_class ; CHECK-NEXT: .b8 6 // DW_AT_address_class
; CHECK-NEXT: .b8 11 // DW_AT_location ; CHECK-NEXT: .b8 9 // DW_AT_location
; CHECK-NEXT: .b8 3 ; CHECK-NEXT: .b8 3
; CHECK-NEXT: .b64 __local_depot0 ; CHECK-NEXT: .b64 __local_depot0
; CHECK-NEXT: .b8 35
; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b8 111 // DW_AT_name ; CHECK-NEXT: .b8 111 // DW_AT_name
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b8 1 // DW_AT_decl_file ; CHECK-NEXT: .b8 1 // DW_AT_decl_file
; CHECK-NEXT: .b8 4 // DW_AT_decl_line ; CHECK-NEXT: .b8 4 // DW_AT_decl_line
; CHECK-NEXT: .b32 111 // DW_AT_type ; CHECK-NEXT: .b32 109 // DW_AT_type
; CHECK-NEXT: .b8 0 // End Of Children Mark ; CHECK-NEXT: .b8 0 // End Of Children Mark
; CHECK-NEXT: .b8 4 // Abbrev [4] 0x6f:0x15 DW_TAG_structure_type ; CHECK-NEXT: .b8 4 // Abbrev [4] 0x6d:0x15 DW_TAG_structure_type
; CHECK-NEXT: .b8 70 // DW_AT_name ; CHECK-NEXT: .b8 70 // DW_AT_name
; CHECK-NEXT: .b8 111 ; CHECK-NEXT: .b8 111
; CHECK-NEXT: .b8 111 ; CHECK-NEXT: .b8 111
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b8 4 // DW_AT_byte_size ; CHECK-NEXT: .b8 4 // DW_AT_byte_size
; CHECK-NEXT: .b8 1 // DW_AT_decl_file ; CHECK-NEXT: .b8 1 // DW_AT_decl_file
; CHECK-NEXT: .b8 1 // DW_AT_decl_line ; CHECK-NEXT: .b8 1 // DW_AT_decl_line
; CHECK-NEXT: .b8 5 // Abbrev [5] 0x77:0xc DW_TAG_member ; CHECK-NEXT: .b8 5 // Abbrev [5] 0x75:0xc DW_TAG_member
; CHECK-NEXT: .b8 120 // DW_AT_name ; CHECK-NEXT: .b8 120 // DW_AT_name
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b32 132 // DW_AT_type ; CHECK-NEXT: .b32 130 // DW_AT_type
; CHECK-NEXT: .b8 1 // DW_AT_decl_file ; CHECK-NEXT: .b8 1 // DW_AT_decl_file
; CHECK-NEXT: .b8 1 // DW_AT_decl_line ; CHECK-NEXT: .b8 1 // DW_AT_decl_line
; CHECK-NEXT: .b8 2 // DW_AT_data_member_location ; CHECK-NEXT: .b8 2 // DW_AT_data_member_location
; CHECK-NEXT: .b8 35 ; CHECK-NEXT: .b8 35
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b8 0 // End Of Children Mark ; CHECK-NEXT: .b8 0 // End Of Children Mark
; CHECK-NEXT: .b8 6 // Abbrev [6] 0x84:0x7 DW_TAG_base_type ; CHECK-NEXT: .b8 6 // Abbrev [6] 0x82:0x7 DW_TAG_base_type
; CHECK-NEXT: .b8 105 // DW_AT_name ; CHECK-NEXT: .b8 105 // DW_AT_name
; CHECK-NEXT: .b8 110 ; CHECK-NEXT: .b8 110
; CHECK-NEXT: .b8 116 ; CHECK-NEXT: .b8 116
; CHECK-NEXT: .b8 0 ; CHECK-NEXT: .b8 0
; CHECK-NEXT: .b8 5 // DW_AT_encoding ; CHECK-NEXT: .b8 5 // DW_AT_encoding
; CHECK-NEXT: .b8 4 // DW_AT_byte_size ; CHECK-NEXT: .b8 4 // DW_AT_byte_size
; CHECK-NEXT: .b8 0 // End Of Children Mark ; CHECK-NEXT: .b8 0 // End Of Children Mark
; CHECK-NEXT: } ; CHECK-NEXT: }
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

llvm/trunk/test/DebugInfo/X86/dw_op_constu.mir

Show First 20 Lines • Show All 141 Lines • ▼ Show 20 Lines bb.2: ;-------------------------- DW_OP_plus_uconst -------------------------------
RETQ debug-location !14 RETQ debug-location !14
... ...
# CHECK-LABEL: .Ldebug_loc0: # CHECK-LABEL: .Ldebug_loc0:
# CHECK-NEXT: .quad .Ltmp0-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp0-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp1-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp1-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 9 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 1 # 1 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 16 # DW_OP_constu
# CHECK-NEXT: .byte 255 # 4294967295
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 15 #
# CHECK-NEXT: .byte 28 # DW_OP_minus
# CHECK-NEXT: .quad .Ltmp1-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp1-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp2-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp2-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 9 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 0 # 0 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 16 # DW_OP_constu
# CHECK-NEXT: .byte 128 # 4294967296
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 16 #
# CHECK-NEXT: .byte 28 # DW_OP_minus
# CHECK-NEXT: .quad .Ltmp2-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp2-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp3-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp3-.Lfunc_begin0
# CHECK-NEXT: .short 6 # Loc expr size # CHECK-NEXT: .short 6 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 129 # -2147483647 # CHECK-NEXT: .byte 129 # -2147483647
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
Show All 9 Lines
# CHECK-NEXT: .byte 120 # # CHECK-NEXT: .byte 120 #
# CHECK-NEXT: .quad .Ltmp4-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp4-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp5-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp5-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 2 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 0 # 0 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .quad .Ltmp5-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp5-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp6-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp6-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 5 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 1 # 1 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 48 # DW_OP_lit0
# CHECK-NEXT: .byte 32 # DW_OP_not
# CHECK-NEXT: .byte 28 # DW_OP_minus
# CHECK-NEXT: .quad .Ltmp6-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp6-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp7-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp7-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 14 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 2 # 2 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 16 # DW_OP_constu
# CHECK-NEXT: .byte 254 # 18446744073709551614
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 1 #
# CHECK-NEXT: .byte 28 # DW_OP_minus
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
# CHECK-NEXT: .quad .Ltmp8-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp8-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp9-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp9-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 9 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 127 # -1 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 16 # DW_OP_constu
# CHECK-NEXT: .byte 255 # 4294967295
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 15 #
# CHECK-NEXT: .byte 34 # DW_OP_plus
# CHECK-NEXT: .quad .Ltmp9-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp9-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp10-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp10-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 9 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 0 # 0 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 16 # DW_OP_constu
# CHECK-NEXT: .byte 128 # 4294967296
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 16 #
# CHECK-NEXT: .byte 34 # DW_OP_plus
# CHECK-NEXT: .quad .Ltmp10-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp10-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp11-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp11-.Lfunc_begin0
# CHECK-NEXT: .short 6 # Loc expr size # CHECK-NEXT: .short 6 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 255 # 2147483647 # CHECK-NEXT: .byte 255 # 2147483647
# CHECK-NEXT: .byte 255 # # CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 # # CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 # # CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 7 # # CHECK-NEXT: .byte 7 #
# CHECK-NEXT: .quad .Ltmp11-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp11-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp12-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp12-.Lfunc_begin0
# CHECK-NEXT: .short 6 # Loc expr size # CHECK-NEXT: .short 9 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 128 # -2147483648 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 16 # DW_OP_constu
# CHECK-NEXT: .byte 128 # 2147483648
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 120 # # CHECK-NEXT: .byte 8 #
# CHECK-NEXT: .byte 34 # DW_OP_plus
# CHECK-NEXT: .quad .Ltmp12-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp12-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp13-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp13-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 2 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 0 # 0 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .quad .Ltmp13-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp13-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp14-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp14-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 5 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 127 # -1 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 48 # DW_OP_lit0
# CHECK-NEXT: .byte 32 # DW_OP_not
# CHECK-NEXT: .byte 34 # DW_OP_plus
# CHECK-NEXT: .quad .Ltmp14-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp14-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp15-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp15-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 14 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 126 # -2 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 16 # DW_OP_constu
# CHECK-NEXT: .byte 254 # 18446744073709551614
aprantlUnsubmitted
Not Done
ReplyInline Actions

We should fix the comment printer to emit very large constants as hex...

aprantl: We should fix the comment printer to emit very large constants as hex...
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 1 #
# CHECK-NEXT: .byte 34 # DW_OP_plus
#----------------------------------------------------------------------- #-----------------------------------------------------------------------
# CHECK-NEXT: .quad .Ltmp16-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp16-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp17-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp17-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 8 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 127 # -1 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 35 # DW_OP_plus_uconst
# CHECK-NEXT: .byte 255 # 4294967295
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 15 #
# CHECK-NEXT: .quad .Ltmp17-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp17-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp18-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp18-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 8 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 0 # 0 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 35 # DW_OP_plus_uconst
# CHECK-NEXT: .byte 128 # 4294967296
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 16 #
# CHECK-NEXT: .quad .Ltmp18-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp18-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp19-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp19-.Lfunc_begin0
# CHECK-NEXT: .short 6 # Loc expr size # CHECK-NEXT: .short 6 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 255 # 2147483647 # CHECK-NEXT: .byte 255 # 2147483647
# CHECK-NEXT: .byte 255 # # CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 # # CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 # # CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 7 # # CHECK-NEXT: .byte 7 #
# CHECK-NEXT: .quad .Ltmp19-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp19-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp20-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp20-.Lfunc_begin0
# CHECK-NEXT: .short 6 # Loc expr size # CHECK-NEXT: .short 8 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 128 # -2147483648 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 35 # DW_OP_plus_uconst
# CHECK-NEXT: .byte 128 # 2147483648
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 128 # # CHECK-NEXT: .byte 128 #
# CHECK-NEXT: .byte 120 # # CHECK-NEXT: .byte 8 #
# CHECK-NEXT: .quad .Ltmp20-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp20-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp21-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp21-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 2 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 0 # 0 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .quad .Ltmp21-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp21-.Lfunc_begin0
# CHECK-NEXT: .quad .Ltmp22-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp22-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 13 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 127 # -1 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 35 # DW_OP_plus_uconst
# CHECK-NEXT: .byte 255 # 18446744073709551615
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 1 #
# CHECK-NEXT: .quad .Ltmp22-.Lfunc_begin0 # CHECK-NEXT: .quad .Ltmp22-.Lfunc_begin0
# CHECK-NEXT: .quad .Lfunc_end0-.Lfunc_begin0 # CHECK-NEXT: .quad .Lfunc_end0-.Lfunc_begin0
# CHECK-NEXT: .short 2 # Loc expr size # CHECK-NEXT: .short 13 # Loc expr size
# CHECK-NEXT: .byte 114 # DW_OP_breg2 # CHECK-NEXT: .byte 114 # DW_OP_breg2
# CHECK-NEXT: .byte 126 # -2 # CHECK-NEXT: .byte 0 # 0
# CHECK-NEXT: .byte 35 # DW_OP_plus_uconst
# CHECK-NEXT: .byte 254 # 18446744073709551614
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 255 #
# CHECK-NEXT: .byte 1 #
# CHECK-NEXT: .quad 0 # CHECK-NEXT: .quad 0
# CHECK-NEXT: .quad 0 # CHECK-NEXT: .quad 0