This is an archive of the discontinued LLVM Phabricator instance.

Update libc++ release notes
ClosedPublic

Authored by zoecarver on Aug 29 2019, 9:42 AM.

Details

Summary

This patch simply updates the release notes for libc++ 9.0. I have
picked out a few featues/fixes/updates that I think are worth
mentioning. Feel free to suggest changes, or simply leave a comment with
something that should be added and I will update this patch.

Event Timeline

zoecarver created this revision.Aug 29 2019, 9:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
thakis added a subscriber: thakis.Aug 29 2019, 10:53 AM
thakis added inline comments.
libcxx/docs/ReleaseNotes.rst
45
afaik `foo` is a link in rst and ``foo`` is code
hans accepted this revision.Aug 30 2019, 1:16 AM

Thanks for writing release notes! Please let me know if you need assistance with committing to the branch.

libcxx/docs/ReleaseNotes.rst
45

I'm not sure if it's a link, I think it ends up using italics or something.

But +1, please use `foo` instead.

This revision is now accepted and ready to land.Aug 30 2019, 1:16 AM
jfb added inline comments.Aug 30 2019, 1:26 AM
libcxx/docs/ReleaseNotes.rst
58

This seems misleading if it refers to my llvm version bump? The runtime is compiled with llvm so it’s true there, but users of older GCC should still be able to use the libc++ headers I think.

zoecarver marked an inline comment as done.Aug 30 2019, 12:19 PM
zoecarver added inline comments.
libcxx/docs/ReleaseNotes.rst
58

I was referring to a commit Eric made. Users of older GCC versions _will not_ be able to use libc++ headers anymore (because of constexpr, variadics, rvalues, etc.).

zoecarver marked an inline comment as done.
  • update back-tick links to be code
zoecarver closed this revision.Aug 30 2019, 1:06 PM

Committed as rL370514.