Page MenuHomePhabricator

[SimplifyCFG] Skip sinking common lifetime markers of `alloca`.
ClosedPublic

Authored by hliao on Aug 29 2019, 8:27 AM.

Details

Summary
  • Similar to the workaround in fix of PR30188, skip sinking common lifetime markers of alloca. They are mostly left there after inlining functions in branches.

Diff Detail

Event Timeline

hliao created this revision.Aug 29 2019, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 8:27 AM
jmolloy accepted this revision.Aug 29 2019, 8:42 AM

Thanks! One nit.

llvm/lib/Transforms/Utils/SimplifyCFG.cpp
1510

Nit: I'd prefer this out of line as it doesn't use any state from this function and its intent is clear from the name.

This revision is now accepted and ready to land.Aug 29 2019, 8:42 AM
hliao updated this revision to Diff 217901.Aug 29 2019, 8:58 AM

Revise isLifeTimeMarker following review comment.

This revision was automatically updated to reflect the committed changes.