Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION

[labath]

Summary

With the XCode project gone, there doesn't seem to be anything setting
this macro anymore -- and the macro wasn't doing much anyway.

[labath]

Any thoughts on this one?

[friss]

I don't see reason to keep this around.

source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

 #include "Plugins/Process/POSIX/CrashReason.h"
 #include "Plugins/Process/POSIX/ProcessPOSIXLog.h"
 #include "ProcessFreeBSD.h"
 #include "ProcessMonitor.h"
 
 using namespace lldb;
 using namespace lldb_private;
 
-// We disable the tracing of ptrace calls for integration builds to avoid the
-// additional indirection and checks.
-#ifndef LLDB_CONFIGURATION_BUILDANDINTEGRATION
 // Wrapper for ptrace to catch errors and log calls.
 
 const char *Get_PT_IO_OP(int op) {
   switch (op) {
   case PIOD_READ_D:
     return "READ_D";
   case PIOD_WRITE_D:
     return "WRITE_D";
extern long PtraceWrapper(int req, lldb::pid_t pid, void *addr, int data) {
   long result = 0;
   errno = 0;
   result = ptrace(req, pid, (caddr_t)addr, data);
   return result;
 }
 
 #define PTRACE(req, pid, addr, data)                                           \
   PtraceWrapper((req), (pid), (addr), (data), #req, __FILE__, __LINE__)
-#else
-PtraceWrapper((req), (pid), (addr), (data))
-#endif
 
 // Static implementations of ProcessMonitor::ReadMemory and
 // ProcessMonitor::WriteMemory.  This enables mutual recursion between these
 // functions without needed to go thru the thread funnel.
 
 static size_t DoReadMemory(lldb::pid_t pid, lldb::addr_t vm_addr, void *buf,
                            size_t size, Status &error) {
   struct ptrace_io_desc pi_desc;

source/Plugins/Process/POSIX/CrashReason.cpp

case CrashReason::eFloatSubscriptRange:
     str = "signal SIGFPE: invalid floating point subscript range";
     break;
   }
 
   return str;
 }
 
 const char *CrashReasonAsString(CrashReason reason) {
-#ifdef LLDB_CONFIGURATION_BUILDANDINTEGRATION
-  // Just return the code in ascii for integration builds.
-  chcar str[8];
-  sprintf(str, "%d", reason);
-#else
   const char *str = nullptr;
 
   switch (reason) {
   case CrashReason::eInvalidCrashReason:
     str = "eInvalidCrashReason";
     break;
 
   // SIGSEGV crash reasons.
case CrashReason::eFloatInexactResult:
     break;
   case CrashReason::eFloatInvalidOperation:
     str = "eFloatInvalidOperation";
     break;
   case CrashReason::eFloatSubscriptRange:
     str = "eFloatSubscriptRange";
     break;
   }
-#endif
-
   return str;
 }
 
 CrashReason GetCrashReason(const siginfo_t &info) {
   switch (info.si_signo) {
   case SIGSEGV:
     return GetCrashReasonForSIGSEGV(info);
   case SIGBUS:

source/Plugins/Process/POSIX/ProcessMessage.cpp

 
 using namespace lldb_private;
 
 const char *ProcessMessage::PrintCrashReason() const {
   return CrashReasonAsString(m_crash_reason);
 }
 
 const char *ProcessMessage::PrintKind(Kind kind) {
-#ifdef LLDB_CONFIGURATION_BUILDANDINTEGRATION
-  // Just return the code in ascii for integration builds.
-  chcar str[8];
-  sprintf(str, "%d", reason);
-#else
   const char *str = nullptr;
 
   switch (kind) {
   case eInvalidMessage:
     str = "eInvalidMessage";
     break;
   case eAttachMessage:
     str = "eAttachMessage";
case eCrashMessage:
     break;
   case eNewThreadMessage:
     str = "eNewThreadMessage";
     break;
   case eExecMessage:
     str = "eExecMessage";
     break;
   }
-#endif
-
   return str;
 }
 
 const char *ProcessMessage::PrintKind() const { return PrintKind(m_kind); }