This is an archive of the discontinued LLVM Phabricator instance.

[ELF] EhFrameSection: postpone FDE liveness check to finalizeSections
ClosedPublic

Authored by MaskRay on Aug 25 2019, 10:43 PM.

Details

Summary

EhFrameSection::addSection checks liveness of FDE early. This makes it
infeasible to move combineEhSections before ICF.

Postpone the check to EhFrameSection::finalizeContents to resemble
ARMExidxSyntheticSection. This will make a subsequent patch D66717
simpler.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Aug 25 2019, 10:43 PM
MaskRay updated this revision to Diff 217080.Aug 25 2019, 11:10 PM
MaskRay retitled this revision from [ELF] Simplify EhInputSection and .ARM.exidx* handling to [ELF] EhFrameSection: postpone FDE liveness check to finalizeSections.
MaskRay edited the summary of this revision. (Show Details)

Reorder this patch before D66717. This should make overall diff smaller

ruiu accepted this revision.Aug 26 2019, 2:35 AM

LGTM

This revision is now accepted and ready to land.Aug 26 2019, 2:35 AM
MaskRay updated this revision to Diff 217106.Aug 26 2019, 3:28 AM

Change the comment a bit

This revision was automatically updated to reflect the committed changes.