This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Correct Logic around ilp32e macros
ClosedPublic

Authored by lenary on Aug 22 2019, 7:18 AM.

Details

Summary

GCC seperates the __riscv_float_abi_* macros and the
__riscv_abi_rve macro. If the chosen abi is ilp32e, `gcc -march=rv32i
-mabi=ilp32i -E -dM` shows that both __riscv_float_abi_soft and
__riscv_abi_rve are set.

This patch corrects the compiler logic around these defines.

At the moment, this patch will not change clang's behaviour, because we do not
accept the ilp32e abi yet.

Event Timeline

lenary created this revision.Aug 22 2019, 7:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2019, 7:18 AM
This revision is now accepted and ready to land.Aug 28 2019, 6:12 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2019, 1:47 AM