Page MenuHomePhabricator

[lit] Diagnose insufficient args to internal env
ClosedPublic

Authored by jdenny on Tue, Aug 20, 9:24 AM.

Details

Summary

Without this patch, failing to provide a subcommand to lit's internal
env results in either a python IndexError or an attempt to execute
the final env argument, such as FOO=1, as a command. This patch
diagnoses those cases with a more helpful message.

Diff Detail

Repository
rL LLVM

Event Timeline

jdenny created this revision.Tue, Aug 20, 9:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Aug 20, 9:24 AM
Herald added a subscriber: delcypher. · View Herald Transcript
This revision is now accepted and ready to land.Tue, Aug 20, 10:26 AM
jdenny updated this revision to Diff 216213.Tue, Aug 20, 12:28 PM

Replace ValueError with InternalShellError as just discussed in D65697. I'll wait a little while to push in case someone wants to comment on this.

This revision was automatically updated to reflect the committed changes.