This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Update theme when color theme changes in vscode extension.
ClosedPublic

Authored by jvikstrom on Aug 19 2019, 1:25 AM.

Event Timeline

jvikstrom created this revision.Aug 19 2019, 1:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2019, 1:25 AM

the change looks good, but I'd wait until D66219 is finished.

jvikstrom updated this revision to Diff 217638.Aug 28 2019, 6:57 AM

Updated to new master.

please update the description of the patch.

clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts
97

does conf.affectsConfiguration('workbench.colorTheme') work?

jvikstrom marked an inline comment as done.

Use conf.affectsConfiguration('workbench.colorTheme') instead of keeping track of the old color theme manually.

jvikstrom retitled this revision from [clangd] Update themeRuleMatcher when color theme changes in vscode extension. to [clangd] Update theme when color theme changes in vscode extension..Aug 29 2019, 12:39 AM
jvikstrom edited the summary of this revision. (Show Details)
hokein accepted this revision.Aug 29 2019, 1:31 AM
This revision is now accepted and ready to land.Aug 29 2019, 1:31 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 1:40 AM