Page MenuHomePhabricator

jvikstrom (Johan Vikström)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2019, 2:13 AM (14 w, 1 d)

Recent Activity

Fri, Aug 30

jvikstrom committed rGbecbdc66dcb5: [clangd] Add highlighting for macro expansions. (authored by jvikstrom).
[clangd] Add highlighting for macro expansions.
Fri, Aug 30, 8:48 AM
jvikstrom committed rL370482: [clangd] Add highlighting for macro expansions..
[clangd] Add highlighting for macro expansions.
Fri, Aug 30, 8:47 AM
jvikstrom closed D66995: [clangd] Add highlighting for macro expansions..
Fri, Aug 30, 8:46 AM · Restricted Project, Restricted Project
jvikstrom committed rG268f45bfb8f7: [clangd] Added highlighting for structured bindings. (authored by jvikstrom).
[clangd] Added highlighting for structured bindings.
Fri, Aug 30, 7:09 AM
jvikstrom committed rL370473: [clangd] Added highlighting for structured bindings..
[clangd] Added highlighting for structured bindings.
Fri, Aug 30, 7:06 AM
jvikstrom closed D66738: [clangd] Added highlighting for structured bindings..
Fri, Aug 30, 7:06 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66995: [clangd] Add highlighting for macro expansions..

Renamed MacroExpansion to Macro.

Fri, Aug 30, 6:59 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66995: [clangd] Add highlighting for macro expansions..
Fri, Aug 30, 6:54 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66995: [clangd] Add highlighting for macro expansions..

Address comments.

Fri, Aug 30, 6:49 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66995: [clangd] Add highlighting for macro expansions..

Removed SourceManager field from HighlightingTokenCollector.

Fri, Aug 30, 3:17 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66738: [clangd] Added highlighting for structured bindings..
Fri, Aug 30, 3:02 AM · Restricted Project, Restricted Project
jvikstrom created D66995: [clangd] Add highlighting for macro expansions..
Fri, Aug 30, 2:56 AM · Restricted Project, Restricted Project
jvikstrom updated the summary of D66738: [clangd] Added highlighting for structured bindings..
Fri, Aug 30, 2:56 AM · Restricted Project, Restricted Project
jvikstrom committed rG84b4c4a495f8: [clangd] Collecting main file macro expansion locations in ParsedAST. (authored by jvikstrom).
[clangd] Collecting main file macro expansion locations in ParsedAST.
Fri, Aug 30, 2:34 AM
jvikstrom committed rL370452: [clangd] Collecting main file macro expansion locations in ParsedAST..
[clangd] Collecting main file macro expansion locations in ParsedAST.
Fri, Aug 30, 2:32 AM
jvikstrom closed D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
Fri, Aug 30, 2:32 AM · Restricted Project, Restricted Project
jvikstrom added a comment to D66516: [clangd] Highlight typedefs to template parameters as template parameters.

Pinging about this @ilya-biryukov

Fri, Aug 30, 2:30 AM · Restricted Project, Restricted Project
jvikstrom added a comment to D66990: [clangd] Add distinct highlightings for declarations of functions and methods.

Should we have different highlightings for declarations vs usages? (Although I guess in the end it will be up to the editor if they highlight them differently as the scope is just more specific for declarations)
I guess I personally don't really see the reason as it should be clear from the context if it's a declaration or a function call.
But this might actually be nice if you have macros that declare functions

Fri, Aug 30, 12:29 AM · Restricted Project
jvikstrom accepted D66949: [clangd] Add .vscode-test to .gitignore..
Fri, Aug 30, 12:16 AM · Restricted Project, Restricted Project

Thu, Aug 29

jvikstrom added inline comments to D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
Thu, Aug 29, 10:07 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..

Added test for prepending concatenations. Also added made tests pass.

Thu, Aug 29, 9:57 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
Thu, Aug 29, 7:27 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
Thu, Aug 29, 3:13 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..

Clarified comments. Added tests. Not getting expansions inside other macro expansions.

Thu, Aug 29, 3:10 AM · Restricted Project, Restricted Project
jvikstrom committed rG4683eec2d303: [clangd] Update themeRuleMatcher when color theme changes in vscode extension. (authored by jvikstrom).
[clangd] Update themeRuleMatcher when color theme changes in vscode extension.
Thu, Aug 29, 1:41 AM
jvikstrom committed rL370305: [clangd] Update themeRuleMatcher when color theme changes in vscode extension..
[clangd] Update themeRuleMatcher when color theme changes in vscode extension.
Thu, Aug 29, 1:41 AM
jvikstrom closed D66406: [clangd] Update theme when color theme changes in vscode extension..
Thu, Aug 29, 1:40 AM · Restricted Project, Restricted Project
jvikstrom created D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
Thu, Aug 29, 1:02 AM · Restricted Project, Restricted Project
jvikstrom retitled D66406: [clangd] Update theme when color theme changes in vscode extension. from [clangd] Update themeRuleMatcher when color theme changes in vscode extension. to [clangd] Update theme when color theme changes in vscode extension..
Thu, Aug 29, 12:39 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66406: [clangd] Update theme when color theme changes in vscode extension..

Use conf.affectsConfiguration('workbench.colorTheme') instead of keeping track of the old color theme manually.

Thu, Aug 29, 12:30 AM · Restricted Project, Restricted Project

Wed, Aug 28

jvikstrom accepted D66881: [clangd][vscode] Don't leak the resources.
Wed, Aug 28, 8:05 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66738: [clangd] Added highlighting for structured bindings..

Abandoned trying to highlight the same as the bound decl.

Wed, Aug 28, 7:44 AM · Restricted Project, Restricted Project
jvikstrom added a comment to D66881: [clangd][vscode] Don't leak the resources.

Oh, was not aware we needed to dispose the extension as well.

Wed, Aug 28, 7:03 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66406: [clangd] Update theme when color theme changes in vscode extension..

Updated to new master.

Wed, Aug 28, 7:03 AM · Restricted Project, Restricted Project
jvikstrom committed rG2dddf3e4ff81: [clangd] Cleans up the semantic highlighting resources if clangd stops. (authored by jvikstrom).
[clangd] Cleans up the semantic highlighting resources if clangd stops.
Wed, Aug 28, 6:47 AM
jvikstrom committed rL370202: [clangd] Cleans up the semantic highlighting resources if clangd stops..
[clangd] Cleans up the semantic highlighting resources if clangd stops.
Wed, Aug 28, 6:45 AM
jvikstrom closed D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes..
Wed, Aug 28, 6:45 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Wed, Aug 28, 6:41 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66516: [clangd] Highlight typedefs to template parameters as template parameters.

Added a RecursiveASTVisitor for finding 'underlying' types.

Wed, Aug 28, 6:17 AM · Restricted Project, Restricted Project

Tue, Aug 27

jvikstrom updated the diff for D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes..

Dispose of all resources when disposing.

Tue, Aug 27, 7:24 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes..
Tue, Aug 27, 4:43 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes..

Renamed disposables to subscriptions and removed clangd crashes in api.

Tue, Aug 27, 4:43 AM · Restricted Project, Restricted Project

Mon, Aug 26

jvikstrom abandoned D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension..
Mon, Aug 26, 9:52 AM · Restricted Project
jvikstrom created D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes..
Mon, Aug 26, 7:26 AM · Restricted Project, Restricted Project
jvikstrom committed rL369911: [clangd] Handling text editor/document lifetimes in vscode extension..
[clangd] Handling text editor/document lifetimes in vscode extension.
Mon, Aug 26, 7:25 AM
jvikstrom committed rG1c9aa70b042b: [clangd] Handling text editor/document lifetimes in vscode extension. (authored by jvikstrom).
[clangd] Handling text editor/document lifetimes in vscode extension.
Mon, Aug 26, 7:19 AM
jvikstrom closed D66735: [clangd] Handling text editor/document lifetimes in vscode extension..
Mon, Aug 26, 7:19 AM · Restricted Project
jvikstrom updated the diff for D66735: [clangd] Handling text editor/document lifetimes in vscode extension..

Fixed changes that weren't supposed to be made.

Mon, Aug 26, 6:37 AM · Restricted Project
jvikstrom updated the diff for D66735: [clangd] Handling text editor/document lifetimes in vscode extension..

Address comments.

Mon, Aug 26, 6:31 AM · Restricted Project
jvikstrom created D66738: [clangd] Added highlighting for structured bindings..
Mon, Aug 26, 6:22 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66735: [clangd] Handling text editor/document lifetimes in vscode extension..
Mon, Aug 26, 6:04 AM · Restricted Project
jvikstrom created D66735: [clangd] Handling text editor/document lifetimes in vscode extension..
Mon, Aug 26, 5:26 AM · Restricted Project
jvikstrom committed rG3b6d7040cf4f: [clangd] Added a colorizer to the vscode extension. (authored by jvikstrom).
[clangd] Added a colorizer to the vscode extension.
Mon, Aug 26, 4:36 AM
jvikstrom committed rL369893: [clangd] Added a colorizer to the vscode extension..
[clangd] Added a colorizer to the vscode extension.
Mon, Aug 26, 4:35 AM
jvikstrom closed D66219: [clangd] Added a colorizer to the vscode extension..
Mon, Aug 26, 4:35 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Mon, Aug 26, 4:20 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66219: [clangd] Added a colorizer to the vscode extension..
Mon, Aug 26, 2:51 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66219: [clangd] Added a colorizer to the vscode extension..

Made tests more readable.

Mon, Aug 26, 2:51 AM · Restricted Project, Restricted Project

Thu, Aug 22

jvikstrom added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Thu, Aug 22, 9:12 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66219: [clangd] Added a colorizer to the vscode extension..

Added missing protected and comment.

Thu, Aug 22, 7:51 AM · Restricted Project, Restricted Project
jvikstrom added a comment to D66219: [clangd] Added a colorizer to the vscode extension..

I had completely forgotten we could just override the applyHighlightings method in the tests, everything is much simpler now.

Thu, Aug 22, 7:51 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66219: [clangd] Added a colorizer to the vscode extension..

Rewrote the Highlighter class as we can override the highlighting method for the tests.

Thu, Aug 22, 7:44 AM · Restricted Project, Restricted Project
jvikstrom accepted D66541: [clangd] Send highlighting diff beyond the end of the file..

It feels a bit strange to be sending highlighting (even if they are empty) beyond eof. But I guess the proposal does not specify this and it would make life for the vscode extension (much) simpler.
Theia also does not crash from this and if we apply decorations to vscode outside the file nothing happens as well so I guess it should be fine. (even when vscode finally implements this feature into lsp)

Thu, Aug 22, 1:44 AM · Restricted Project, Restricted Project

Wed, Aug 21

jvikstrom added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Wed, Aug 21, 3:05 AM · Restricted Project, Restricted Project
jvikstrom created D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Wed, Aug 21, 1:50 AM · Restricted Project, Restricted Project

Tue, Aug 20

jvikstrom committed rG6687fde07aea: [Syntax] Added function to get macro expansion tokens to TokenBuffer. (authored by jvikstrom).
[Syntax] Added function to get macro expansion tokens to TokenBuffer.
Tue, Aug 20, 6:34 AM
jvikstrom committed rL369385: [Syntax] Added function to get macro expansion tokens to TokenBuffer..
[Syntax] Added function to get macro expansion tokens to TokenBuffer.
Tue, Aug 20, 6:33 AM
jvikstrom closed D66470: [Syntax] Added function to get macro expansion tokens to TokenBuffer..
Tue, Aug 20, 6:33 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66470: [Syntax] Added function to get macro expansion tokens to TokenBuffer..

Readded dissapeared newline.

Tue, Aug 20, 5:05 AM · Restricted Project, Restricted Project
jvikstrom created D66470: [Syntax] Added function to get macro expansion tokens to TokenBuffer..
Tue, Aug 20, 4:57 AM · Restricted Project, Restricted Project

Mon, Aug 19

jvikstrom committed rGf497da304161: [clangd] Added highlighting for tokens that are macro arguments. (authored by jvikstrom).
[clangd] Added highlighting for tokens that are macro arguments.
Mon, Aug 19, 9:28 AM
jvikstrom committed rL369275: [clangd] Added highlighting for tokens that are macro arguments..
[clangd] Added highlighting for tokens that are macro arguments.
Mon, Aug 19, 9:27 AM
jvikstrom closed D64741: [clangd] Added highlighting for tokens that are macro arguments..
Mon, Aug 19, 9:27 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D64741: [clangd] Added highlighting for tokens that are macro arguments..
Mon, Aug 19, 8:28 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64741: [clangd] Added highlighting for tokens that are macro arguments..

Rewrote conflicting token removal code.

Mon, Aug 19, 8:26 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66219: [clangd] Added a colorizer to the vscode extension..

Renamed colorizer to highlighter and added FIXME about highlightings below eof.

Mon, Aug 19, 7:12 AM · Restricted Project, Restricted Project

Aug 19 2019

jvikstrom added a comment to D64741: [clangd] Added highlighting for tokens that are macro arguments..

@ilya-biryukov @hokein ping

Aug 19 2019, 2:29 AM · Restricted Project, Restricted Project
jvikstrom created D66406: [clangd] Update theme when color theme changes in vscode extension..
Aug 19 2019, 1:25 AM · Restricted Project, Restricted Project
jvikstrom committed rG17587b36d192: [clangd] Added special HighlightingKind for function parameters. (authored by jvikstrom).
[clangd] Added special HighlightingKind for function parameters.
Aug 19 2019, 12:53 AM
jvikstrom committed rL369238: [clangd] Added special HighlightingKind for function parameters..
[clangd] Added special HighlightingKind for function parameters.
Aug 19 2019, 12:51 AM
jvikstrom closed D66335: [clangd] Added special HighlightingKind for function parameters..
Aug 19 2019, 12:50 AM · Restricted Project, Restricted Project

Aug 16 2019

jvikstrom committed rG71ae2bf302cc: [clangd] Added highlighting for non type templates. (authored by jvikstrom).
[clangd] Added highlighting for non type templates.
Aug 16 2019, 2:32 AM
jvikstrom committed rL369090: [clangd] Added highlighting for non type templates..
[clangd] Added highlighting for non type templates.
Aug 16 2019, 2:29 AM
jvikstrom closed D66221: [clangd] Added highlighting for non type templates..
Aug 16 2019, 2:29 AM · Restricted Project, Restricted Project
jvikstrom created D66335: [clangd] Added special HighlightingKind for function parameters..
Aug 16 2019, 2:27 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D66221: [clangd] Added highlighting for non type templates..

Highlight as TemplateParameter.

Aug 16 2019, 2:20 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66221: [clangd] Added highlighting for non type templates..
Aug 16 2019, 2:20 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D66221: [clangd] Added highlighting for non type templates..
Aug 16 2019, 12:57 AM · Restricted Project, Restricted Project

Aug 14 2019

jvikstrom created D66221: [clangd] Added highlighting for non type templates..
Aug 14 2019, 8:23 AM · Restricted Project, Restricted Project
jvikstrom updated the summary of D66219: [clangd] Added a colorizer to the vscode extension..
Aug 14 2019, 8:08 AM · Restricted Project, Restricted Project
jvikstrom created D66219: [clangd] Added a colorizer to the vscode extension..
Aug 14 2019, 7:04 AM · Restricted Project, Restricted Project
jvikstrom committed rG9fa2599e9b9c: [clangd] Loading TokenColorRules as a class mapping the rules to their… (authored by jvikstrom).
[clangd] Loading TokenColorRules as a class mapping the rules to their…
Aug 14 2019, 5:13 AM
jvikstrom committed rL368834: [clangd] Loading TokenColorRules as a class mapping the rules to their….
[clangd] Loading TokenColorRules as a class mapping the rules to their…
Aug 14 2019, 5:12 AM
jvikstrom closed D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Aug 14 2019, 5:12 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.

Simplified matching code. Use real scopes for test.

Aug 14 2019, 2:53 AM · Restricted Project, Restricted Project

Aug 13 2019

jvikstrom updated the diff for D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.

Added fixme for ranking.

Aug 13 2019, 8:37 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Aug 13 2019, 8:25 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.

Changed variable name.

Aug 13 2019, 8:25 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Aug 13 2019, 7:37 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.

Removed stray edits from loadTheme.

Aug 13 2019, 7:37 AM · Restricted Project, Restricted Project