- User Since
- Jun 11 2019, 2:13 AM (14 w, 1 d)
Fri, Aug 30
Renamed MacroExpansion to Macro.
Removed SourceManager field from HighlightingTokenCollector.
Pinging about this @ilya-biryukov
Should we have different highlightings for declarations vs usages? (Although I guess in the end it will be up to the editor if they highlight them differently as the scope is just more specific for declarations)
I guess I personally don't really see the reason as it should be clear from the context if it's a declaration or a function call.
But this might actually be nice if you have macros that declare functions
Thu, Aug 29
Added test for prepending concatenations. Also added made tests pass.
Clarified comments. Added tests. Not getting expansions inside other macro expansions.
Use conf.affectsConfiguration('workbench.colorTheme') instead of keeping track of the old color theme manually.
Wed, Aug 28
Abandoned trying to highlight the same as the bound decl.
Oh, was not aware we needed to dispose the extension as well.
Updated to new master.
Added a RecursiveASTVisitor for finding 'underlying' types.
Tue, Aug 27
Dispose of all resources when disposing.
Renamed disposables to subscriptions and removed clangd crashes in api.
Mon, Aug 26
Fixed changes that weren't supposed to be made.
Made tests more readable.
Thu, Aug 22
Added missing protected and comment.
I had completely forgotten we could just override the applyHighlightings method in the tests, everything is much simpler now.
Rewrote the Highlighter class as we can override the highlighting method for the tests.
It feels a bit strange to be sending highlighting (even if they are empty) beyond eof. But I guess the proposal does not specify this and it would make life for the vscode extension (much) simpler.
Theia also does not crash from this and if we apply decorations to vscode outside the file nothing happens as well so I guess it should be fine. (even when vscode finally implements this feature into lsp)
Wed, Aug 21
Tue, Aug 20
Readded dissapeared newline.
Mon, Aug 19
Rewrote conflicting token removal code.
Renamed colorizer to highlighter and added FIXME about highlightings below eof.
Aug 19 2019
Aug 16 2019
Highlight as TemplateParameter.
Aug 14 2019
Simplified matching code. Use real scopes for test.
Aug 13 2019
Added fixme for ranking.
Changed variable name.
Removed stray edits from loadTheme.