Page MenuHomePhabricator
People jvikstrom

jvikstrom (Johan Vikström)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2019, 2:13 AM (5 w, 21 h)

Recent Activity
View All

Today

jvikstrom committed rGaae7553b3463: [clangd] Added highlighting for the targets in typedefs and using. (authored by jvikstrom).
[clangd] Added highlighting for the targets in typedefs and using.
Tue, Jul 16, 6:25 AM
jvikstrom committed rL366207: [clangd] Added highlighting for the targets in typedefs and using..
[clangd] Added highlighting for the targets in typedefs and using.
Tue, Jul 16, 6:23 AM
jvikstrom closed D64754: [clangd] Added highlighting for the targets in typedefs..
Tue, Jul 16, 6:23 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64475: [clangd] Duplicate lines of semantic highlightings sent removed..

Moved highlighting state to LSP layer. Removed class holding state. Addressed comments.

Tue, Jul 16, 6:11 AM · Restricted Project
jvikstrom updated the diff for D64754: [clangd] Added highlighting for the targets in typedefs..

Add support for using A = ....

Tue, Jul 16, 2:48 AM · Restricted Project, Restricted Project

Yesterday

jvikstrom created D64754: [clangd] Added highlighting for the targets in typedefs..
Mon, Jul 15, 9:53 AM · Restricted Project, Restricted Project
jvikstrom committed rG4e34a85aa2e7: [clangd] Fix duplicate highlighting tokens appearing in initializer lists. (authored by jvikstrom).
[clangd] Fix duplicate highlighting tokens appearing in initializer lists.
Mon, Jul 15, 8:09 AM
jvikstrom committed rL366070: [clangd] Fix duplicate highlighting tokens appearing in initializer lists..
[clangd] Fix duplicate highlighting tokens appearing in initializer lists.
Mon, Jul 15, 8:08 AM
jvikstrom closed D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.
Mon, Jul 15, 8:08 AM · Restricted Project, Restricted Project
jvikstrom added a comment to D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.
In D64634#1585521, @ilya-biryukov wrote:

Have we tried figuring out why RecursiveASTVisitor visits the argument lists twice? Is that an expected behavior?

Mon, Jul 15, 7:15 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.

Address comment.

Mon, Jul 15, 7:13 AM · Restricted Project, Restricted Project
jvikstrom created D64741: [clangd] Added highlighting for tokens that are macro arguments..
Mon, Jul 15, 7:13 AM · Restricted Project
jvikstrom updated the diff for D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.

Removed return type hint for lambda.

Mon, Jul 15, 1:43 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.

Readded newline that was removed accidentaly.

Mon, Jul 15, 1:39 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.

Remove operator< and use std::unique.

Mon, Jul 15, 1:38 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.
Mon, Jul 15, 1:30 AM · Restricted Project, Restricted Project
jvikstrom committed rG17b4a932fae9: [clangd] Added highlighting for members and methods. (authored by jvikstrom).
[clangd] Added highlighting for members and methods.
Mon, Jul 15, 1:13 AM
jvikstrom committed rL366047: [clangd] Added highlighting for members and methods..
[clangd] Added highlighting for members and methods.
Mon, Jul 15, 1:13 AM
jvikstrom closed D64617: [clangd] Added highlighting for members and methods.
Mon, Jul 15, 1:12 AM · Restricted Project, Restricted Project
jvikstrom committed rGd02f17daed31: [clangd] Added highlighting to enum constants. (authored by jvikstrom).
[clangd] Added highlighting to enum constants.
Mon, Jul 15, 12:42 AM
jvikstrom committed rL366045: [clangd] Added highlighting to enum constants..
[clangd] Added highlighting to enum constants.
Mon, Jul 15, 12:42 AM
jvikstrom closed D64624: [clangd] Added highlighting to enum constants..
Mon, Jul 15, 12:41 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D64624: [clangd] Added highlighting to enum constants..
Mon, Jul 15, 12:33 AM · Restricted Project, Restricted Project

Fri, Jul 12

jvikstrom updated the diff for D64624: [clangd] Added highlighting to enum constants..

Address comments.

Fri, Jul 12, 9:31 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64617: [clangd] Added highlighting for members and methods.

Removed addToken for Exprs.

Fri, Jul 12, 9:23 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64617: [clangd] Added highlighting for members and methods.

Addressed comments.

Fri, Jul 12, 9:23 AM · Restricted Project, Restricted Project
jvikstrom created D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists.
Fri, Jul 12, 7:08 AM · Restricted Project, Restricted Project
jvikstrom created D64624: [clangd] Added highlighting to enum constants..
Fri, Jul 12, 2:58 AM · Restricted Project, Restricted Project
jvikstrom updated the summary of D64617: [clangd] Added highlighting for members and methods.
Fri, Jul 12, 2:28 AM · Restricted Project, Restricted Project
jvikstrom created D64617: [clangd] Added highlighting for members and methods.
Fri, Jul 12, 1:37 AM · Restricted Project, Restricted Project

Thu, Jul 11

jvikstrom added inline comments to D64475: [clangd] Duplicate lines of semantic highlightings sent removed..
Thu, Jul 11, 8:24 AM · Restricted Project
jvikstrom updated the diff for D64475: [clangd] Duplicate lines of semantic highlightings sent removed..

Removed unused code snippets.

Thu, Jul 11, 8:24 AM · Restricted Project
jvikstrom updated the diff for D64475: [clangd] Duplicate lines of semantic highlightings sent removed..

Made diffing function shorter, added multiple previous highlighting entries.

Thu, Jul 11, 8:14 AM · Restricted Project
jvikstrom committed rGb6a74e33c38e: [clangd] Added highlightings for namespace specifiers. (authored by jvikstrom).
[clangd] Added highlightings for namespace specifiers.
Thu, Jul 11, 2:31 AM
jvikstrom committed rL365745: [clangd] Added highlightings for namespace specifiers..
[clangd] Added highlightings for namespace specifiers.
Thu, Jul 11, 2:30 AM
jvikstrom closed D64492: [clangd] Added highlightings for namespace specifiers..
Thu, Jul 11, 2:30 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D64492: [clangd] Added highlightings for namespace specifiers..
Thu, Jul 11, 1:03 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64492: [clangd] Added highlightings for namespace specifiers..

Moved alias target namespace add token to another function and added testcase for global namespace specifier.

Thu, Jul 11, 12:58 AM · Restricted Project, Restricted Project

Wed, Jul 10

jvikstrom added inline comments to D64492: [clangd] Added highlightings for namespace specifiers..
Wed, Jul 10, 10:01 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64492: [clangd] Added highlightings for namespace specifiers..

Addressed comments.

Wed, Jul 10, 9:59 AM · Restricted Project, Restricted Project
jvikstrom created D64492: [clangd] Added highlightings for namespace specifiers..
Wed, Jul 10, 7:09 AM · Restricted Project, Restricted Project
jvikstrom created D64475: [clangd] Duplicate lines of semantic highlightings sent removed..
Wed, Jul 10, 4:30 AM · Restricted Project
jvikstrom committed rGeff868fdef2b: [clangd] Added highlighting for class and enum types. (authored by jvikstrom).
[clangd] Added highlighting for class and enum types.
Wed, Jul 10, 1:43 AM
jvikstrom committed rL365602: [clangd] Added highlighting for class and enum types..
[clangd] Added highlighting for class and enum types.
Wed, Jul 10, 1:43 AM
jvikstrom closed D64257: [clangd] Added highlighting for class and enum types.
Wed, Jul 10, 1:43 AM · Restricted Project, Restricted Project
jvikstrom added a comment to D64257: [clangd] Added highlighting for class and enum types.
In D64257#1577347, @nridge wrote:

@jvikstrom out of curiosity, are you testing these patches against a client-side implementation of semantic highlighting? If so, which one?

Wed, Jul 10, 1:10 AM · Restricted Project, Restricted Project

Tue, Jul 9

jvikstrom updated the diff for D64257: [clangd] Added highlighting for class and enum types.

Addressed comments.

Tue, Jul 9, 8:58 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64257: [clangd] Added highlighting for class and enum types.

Changed comment in addToken.

Tue, Jul 9, 6:55 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64257: [clangd] Added highlighting for class and enum types.

No longer highlighting anonymous structs as types.

Tue, Jul 9, 6:55 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D64257: [clangd] Added highlighting for class and enum types.
Tue, Jul 9, 6:55 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D64257: [clangd] Added highlighting for class and enum types.
Tue, Jul 9, 3:04 AM · Restricted Project, Restricted Project
jvikstrom retitled D64257: [clangd] Added highlighting for class and enum types from [clangd] Added highlighting for non-builtin types to [clangd] Added highlighting for class and enum types.
Tue, Jul 9, 3:00 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64257: [clangd] Added highlighting for class and enum types.

Changed commit message.

Tue, Jul 9, 3:00 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64257: [clangd] Added highlighting for class and enum types.

Addressed comments.

Tue, Jul 9, 3:00 AM · Restricted Project, Restricted Project

Mon, Jul 8

jvikstrom updated the diff for D64257: [clangd] Added highlighting for class and enum types.

Clang formatted.

Mon, Jul 8, 7:57 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D64257: [clangd] Added highlighting for class and enum types.
Mon, Jul 8, 7:53 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64257: [clangd] Added highlighting for class and enum types.

Addressed comments.

Mon, Jul 8, 7:43 AM · Restricted Project, Restricted Project
jvikstrom abandoned D64310: [clangd] Added semantic highlighting for constructors and destructors..

Abandoning after discussion with sammccall and hokein.

Mon, Jul 8, 6:22 AM · Restricted Project
jvikstrom added inline comments to D64257: [clangd] Added highlighting for class and enum types.
Mon, Jul 8, 3:37 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64257: [clangd] Added highlighting for class and enum types.

Type -> Class
Also added more tests.

Mon, Jul 8, 3:37 AM · Restricted Project, Restricted Project
jvikstrom created D64310: [clangd] Added semantic highlighting for constructors and destructors..
Mon, Jul 8, 12:18 AM · Restricted Project

Fri, Jul 5

jvikstrom created D64257: [clangd] Added highlighting for class and enum types.
Fri, Jul 5, 10:54 AM · Restricted Project, Restricted Project
jvikstrom committed rG8ca1c65cedb0: [clangd] Added highlighting for variable references (declrefs) (authored by jvikstrom).
[clangd] Added highlighting for variable references (declrefs)
Fri, Jul 5, 6:08 AM
jvikstrom committed rL365205: [clangd] Added highlighting for variable references (declrefs).
[clangd] Added highlighting for variable references (declrefs)
Fri, Jul 5, 6:06 AM
jvikstrom closed D64199: [clangd] Added highlighting for variable references (declrefs).
Fri, Jul 5, 6:06 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D64199: [clangd] Added highlighting for variable references (declrefs).
Fri, Jul 5, 4:33 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64199: [clangd] Added highlighting for variable references (declrefs).

Separated into three testcases.

Fri, Jul 5, 4:29 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64199: [clangd] Added highlighting for variable references (declrefs).

Made tests more readable.

Fri, Jul 5, 4:24 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64199: [clangd] Added highlighting for variable references (declrefs).

Added additional testcase.

Fri, Jul 5, 12:33 AM · Restricted Project, Restricted Project

Thu, Jul 4

jvikstrom added inline comments to D64199: [clangd] Added highlighting for variable references (declrefs).
Thu, Jul 4, 7:44 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64199: [clangd] Added highlighting for variable references (declrefs).

Added testcae. Added another bailout from VisitNamedDecl.

Thu, Jul 4, 7:43 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64199: [clangd] Added highlighting for variable references (declrefs).

Removed debug prints from test.

Thu, Jul 4, 6:48 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64199: [clangd] Added highlighting for variable references (declrefs).

Removed VisitVarDecl and VisitFuncDecl in favor of VisitNamedDecl.

Thu, Jul 4, 6:44 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D64199: [clangd] Added highlighting for variable references (declrefs).

Added overload for addToken and added more code to the test cases.

Thu, Jul 4, 6:36 AM · Restricted Project, Restricted Project
jvikstrom created D64199: [clangd] Added highlighting for variable references (declrefs).
Thu, Jul 4, 2:53 AM · Restricted Project, Restricted Project
jvikstrom committed rGc1ead0e1b5af: [clangd] Add missing changes for 365111 (authored by jvikstrom).
[clangd] Add missing changes for 365111
Thu, Jul 4, 1:10 AM
jvikstrom committed rL365112: [clangd] Add missing changes for 365111.
[clangd] Add missing changes for 365111
Thu, Jul 4, 1:07 AM
jvikstrom committed rGa848dab7a31d: [clangd] Emit publishSemanticHighlighting in LSP if enabled (authored by jvikstrom).
[clangd] Emit publishSemanticHighlighting in LSP if enabled
Thu, Jul 4, 12:54 AM
jvikstrom committed rL365111: [clangd] Emit publishSemanticHighlighting in LSP if enabled.
[clangd] Emit publishSemanticHighlighting in LSP if enabled
Thu, Jul 4, 12:54 AM
jvikstrom closed D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.
Thu, Jul 4, 12:54 AM · Restricted Project, Restricted Project

Wed, Jul 3

jvikstrom updated the diff for D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

Addressed comments.

Wed, Jul 3, 6:59 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.
Wed, Jul 3, 4:59 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

Not sending TextMate scopes over LSP if semantic highlighting is not enabled.

Wed, Jul 3, 4:55 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

Removed unused headers

Wed, Jul 3, 12:33 AM · Restricted Project, Restricted Project

Tue, Jul 2

jvikstrom updated the diff for D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

Removed from hiding under hidden flag .

Tue, Jul 2, 8:04 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.
Tue, Jul 2, 6:17 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

Address comments.

Tue, Jul 2, 6:17 AM · Restricted Project, Restricted Project

Mon, Jul 1

jvikstrom committed rG881aab4dc3df: [clangd] No longer getting template instantiations from header files in Main… (authored by jvikstrom).
[clangd] No longer getting template instantiations from header files in Main…
Mon, Jul 1, 4:50 AM
jvikstrom committed rL364747: [clangd] No longer getting template instantiations from header files in Main….
[clangd] No longer getting template instantiations from header files in Main…
Mon, Jul 1, 4:49 AM
jvikstrom closed D63817: [clangd] No longer getting template instantiations from header files in Main AST..
Mon, Jul 1, 4:49 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

Addressed comments.

Mon, Jul 1, 1:50 AM · Restricted Project, Restricted Project

Fri, Jun 28

jvikstrom updated the diff for D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.

Added SemanticHighlightingInformation and SemantigHighlightingParams.

Fri, Jun 28, 3:53 AM · Restricted Project, Restricted Project
jvikstrom created D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled.
Fri, Jun 28, 1:07 AM · Restricted Project, Restricted Project

Thu, Jun 27

jvikstrom committed rG6b8a2515baaa: [clangd] Emit semantic highlighting tokens when the main AST is built. (authored by jvikstrom).
[clangd] Emit semantic highlighting tokens when the main AST is built.
Thu, Jun 27, 8:17 AM
jvikstrom committed rL364551: [clangd] Emit semantic highlighting tokens when the main AST is built..
[clangd] Emit semantic highlighting tokens when the main AST is built.
Thu, Jun 27, 8:17 AM
jvikstrom closed D63821: [clangd] Added C++ API code for semantic highlighting.
Thu, Jun 27, 8:17 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D63821: [clangd] Added C++ API code for semantic highlighting.

Made test safe again

Thu, Jun 27, 6:50 AM · Restricted Project, Restricted Project
jvikstrom updated the diff for D63821: [clangd] Added C++ API code for semantic highlighting.

Simplified test.

Thu, Jun 27, 5:57 AM · Restricted Project, Restricted Project
jvikstrom added inline comments to D63821: [clangd] Added C++ API code for semantic highlighting.
Thu, Jun 27, 5:56 AM · Restricted Project, Restricted Project
jvikstrom accepted D63874: [clangd] No need to setTraversalScope in SemanticHighlighting..

lgtm

Thu, Jun 27, 5:21 AM · Restricted Project, Restricted Project