User Details
User Details
- User Since
- Jun 11 2019, 2:13 AM (85 w, 18 h)
Aug 30 2019
Aug 30 2019
jvikstrom committed rGbecbdc66dcb5: [clangd] Add highlighting for macro expansions. (authored by jvikstrom).
[clangd] Add highlighting for macro expansions.
[clangd] Add highlighting for macro expansions.
jvikstrom committed rG268f45bfb8f7: [clangd] Added highlighting for structured bindings. (authored by jvikstrom).
[clangd] Added highlighting for structured bindings.
[clangd] Added highlighting for structured bindings.
jvikstrom updated the diff for D66995: [clangd] Add highlighting for macro expansions..
Renamed MacroExpansion to Macro.
jvikstrom added inline comments to D66995: [clangd] Add highlighting for macro expansions..
jvikstrom updated the diff for D66995: [clangd] Add highlighting for macro expansions..
Address comments.
jvikstrom updated the diff for D66995: [clangd] Add highlighting for macro expansions..
Removed SourceManager field from HighlightingTokenCollector.
jvikstrom added inline comments to D66738: [clangd] Added highlighting for structured bindings..
jvikstrom updated the summary of D66738: [clangd] Added highlighting for structured bindings..
jvikstrom committed rG84b4c4a495f8: [clangd] Collecting main file macro expansion locations in ParsedAST. (authored by jvikstrom).
[clangd] Collecting main file macro expansion locations in ParsedAST.
jvikstrom committed rL370452: [clangd] Collecting main file macro expansion locations in ParsedAST..
[clangd] Collecting main file macro expansion locations in ParsedAST.
jvikstrom added a comment to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Pinging about this @ilya-biryukov
jvikstrom added a comment to D66990: [clangd] Add distinct highlightings for declarations of functions and methods.
Should we have different highlightings for declarations vs usages? (Although I guess in the end it will be up to the editor if they highlight them differently as the scope is just more specific for declarations)
I guess I personally don't really see the reason as it should be clear from the context if it's a declaration or a function call.
But this might actually be nice if you have macros that declare functions
Aug 30 2019, 12:29 AM · Restricted Project
Aug 29 2019
Aug 29 2019
jvikstrom added inline comments to D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
jvikstrom updated the diff for D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
Added test for prepending concatenations. Also added made tests pass.
jvikstrom added inline comments to D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
jvikstrom added inline comments to D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
jvikstrom updated the diff for D66928: [clangd] Collecting main file macro expansion locations in ParsedAST..
Clarified comments. Added tests. Not getting expansions inside other macro expansions.
jvikstrom committed rG4683eec2d303: [clangd] Update themeRuleMatcher when color theme changes in vscode extension. (authored by jvikstrom).
[clangd] Update themeRuleMatcher when color theme changes in vscode extension.
jvikstrom committed rL370305: [clangd] Update themeRuleMatcher when color theme changes in vscode extension..
[clangd] Update themeRuleMatcher when color theme changes in vscode extension.
jvikstrom retitled D66406: [clangd] Update theme when color theme changes in vscode extension. from [clangd] Update themeRuleMatcher when color theme changes in vscode extension. to [clangd] Update theme when color theme changes in vscode extension..
jvikstrom updated the diff for D66406: [clangd] Update theme when color theme changes in vscode extension..
Use conf.affectsConfiguration('workbench.colorTheme') instead of keeping track of the old color theme manually.
Aug 28 2019
Aug 28 2019
jvikstrom updated the diff for D66738: [clangd] Added highlighting for structured bindings..
Abandoned trying to highlight the same as the bound decl.
jvikstrom added a comment to D66881: [clangd][vscode] Don't leak the resources.
Oh, was not aware we needed to dispose the extension as well.
jvikstrom updated the diff for D66406: [clangd] Update theme when color theme changes in vscode extension..
Updated to new master.
jvikstrom committed rG2dddf3e4ff81: [clangd] Cleans up the semantic highlighting resources if clangd stops. (authored by jvikstrom).
[clangd] Cleans up the semantic highlighting resources if clangd stops.
jvikstrom committed rL370202: [clangd] Cleans up the semantic highlighting resources if clangd stops..
[clangd] Cleans up the semantic highlighting resources if clangd stops.
jvikstrom added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
jvikstrom updated the diff for D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Added a RecursiveASTVisitor for finding 'underlying' types.
Aug 27 2019
Aug 27 2019
jvikstrom updated the diff for D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes..
Dispose of all resources when disposing.
jvikstrom added inline comments to D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes..
jvikstrom updated the diff for D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes..
Renamed disposables to subscriptions and removed clangd crashes in api.
Aug 26 2019
Aug 26 2019
jvikstrom abandoned D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension..
Aug 26 2019, 9:52 AM · Restricted Project
jvikstrom committed rL369911: [clangd] Handling text editor/document lifetimes in vscode extension..
[clangd] Handling text editor/document lifetimes in vscode extension.
jvikstrom committed rG1c9aa70b042b: [clangd] Handling text editor/document lifetimes in vscode extension. (authored by jvikstrom).
[clangd] Handling text editor/document lifetimes in vscode extension.
Aug 26 2019, 7:19 AM · Restricted Project
jvikstrom updated the diff for D66735: [clangd] Handling text editor/document lifetimes in vscode extension..
Fixed changes that weren't supposed to be made.
Aug 26 2019, 6:37 AM · Restricted Project
jvikstrom updated the diff for D66735: [clangd] Handling text editor/document lifetimes in vscode extension..
Address comments.
Aug 26 2019, 6:31 AM · Restricted Project
jvikstrom added inline comments to D66735: [clangd] Handling text editor/document lifetimes in vscode extension..
Aug 26 2019, 6:04 AM · Restricted Project
Aug 26 2019, 5:26 AM · Restricted Project
jvikstrom committed rG3b6d7040cf4f: [clangd] Added a colorizer to the vscode extension. (authored by jvikstrom).
[clangd] Added a colorizer to the vscode extension.
[clangd] Added a colorizer to the vscode extension.
jvikstrom added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
jvikstrom added inline comments to D66219: [clangd] Added a colorizer to the vscode extension..
jvikstrom updated the diff for D66219: [clangd] Added a colorizer to the vscode extension..
Made tests more readable.
Aug 22 2019
Aug 22 2019
jvikstrom added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
jvikstrom updated the diff for D66219: [clangd] Added a colorizer to the vscode extension..
Added missing protected and comment.
jvikstrom added a comment to D66219: [clangd] Added a colorizer to the vscode extension..
I had completely forgotten we could just override the applyHighlightings method in the tests, everything is much simpler now.
jvikstrom updated the diff for D66219: [clangd] Added a colorizer to the vscode extension..
Rewrote the Highlighter class as we can override the highlighting method for the tests.
It feels a bit strange to be sending highlighting (even if they are empty) beyond eof. But I guess the proposal does not specify this and it would make life for the vscode extension (much) simpler.
Theia also does not crash from this and if we apply decorations to vscode outside the file nothing happens as well so I guess it should be fine. (even when vscode finally implements this feature into lsp)
Aug 21 2019
Aug 21 2019
jvikstrom added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Aug 20 2019
Aug 20 2019
jvikstrom committed rG6687fde07aea: [Syntax] Added function to get macro expansion tokens to TokenBuffer. (authored by jvikstrom).
[Syntax] Added function to get macro expansion tokens to TokenBuffer.
jvikstrom committed rL369385: [Syntax] Added function to get macro expansion tokens to TokenBuffer..
[Syntax] Added function to get macro expansion tokens to TokenBuffer.
jvikstrom updated the diff for D66470: [Syntax] Added function to get macro expansion tokens to TokenBuffer..
Readded dissapeared newline.
Aug 19 2019
Aug 19 2019
jvikstrom committed rGf497da304161: [clangd] Added highlighting for tokens that are macro arguments. (authored by jvikstrom).
[clangd] Added highlighting for tokens that are macro arguments.
[clangd] Added highlighting for tokens that are macro arguments.
jvikstrom added inline comments to D64741: [clangd] Added highlighting for tokens that are macro arguments..
jvikstrom updated the diff for D64741: [clangd] Added highlighting for tokens that are macro arguments..
Rewrote conflicting token removal code.
jvikstrom updated the diff for D66219: [clangd] Added a colorizer to the vscode extension..
Renamed colorizer to highlighter and added FIXME about highlightings below eof.
jvikstrom added a comment to D64741: [clangd] Added highlighting for tokens that are macro arguments..
@ilya-biryukov @hokein ping
jvikstrom committed rG17587b36d192: [clangd] Added special HighlightingKind for function parameters. (authored by jvikstrom).
[clangd] Added special HighlightingKind for function parameters.
[clangd] Added special HighlightingKind for function parameters.
Aug 16 2019
Aug 16 2019
jvikstrom committed rG71ae2bf302cc: [clangd] Added highlighting for non type templates. (authored by jvikstrom).
[clangd] Added highlighting for non type templates.
[clangd] Added highlighting for non type templates.
jvikstrom updated the diff for D66221: [clangd] Added highlighting for non type templates..
Highlight as TemplateParameter.
jvikstrom added inline comments to D66221: [clangd] Added highlighting for non type templates..
jvikstrom added inline comments to D66221: [clangd] Added highlighting for non type templates..
Aug 14 2019
Aug 14 2019
jvikstrom updated the summary of D66219: [clangd] Added a colorizer to the vscode extension..
jvikstrom committed rG9fa2599e9b9c: [clangd] Loading TokenColorRules as a class mapping the rules to their… (authored by jvikstrom).
[clangd] Loading TokenColorRules as a class mapping the rules to their…
jvikstrom committed rL368834: [clangd] Loading TokenColorRules as a class mapping the rules to their….
[clangd] Loading TokenColorRules as a class mapping the rules to their…
jvikstrom updated the diff for D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Simplified matching code. Use real scopes for test.
Aug 13 2019
Aug 13 2019
jvikstrom updated the diff for D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Added fixme for ranking.
jvikstrom added inline comments to D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
jvikstrom updated the diff for D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Changed variable name.
jvikstrom added inline comments to D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
jvikstrom updated the diff for D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Removed stray edits from loadTheme.