This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Print qualifiers of out-of-line definitions in document outline
ClosedPublic

Authored by ilya-biryukov on Aug 14 2019, 5:08 AM.

Event Timeline

ilya-biryukov created this revision.Aug 14 2019, 5:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2019, 5:08 AM
hokein accepted this revision.Aug 14 2019, 5:29 AM
hokein added inline comments.
clang-tools-extra/clangd/AST.cpp
106

if .. out-of-line definition seems a bit confusing, I think here we just return a nested name specifier if it is written/present in the source code?

This revision is now accepted and ready to land.Aug 14 2019, 5:29 AM
ilya-biryukov marked 2 inline comments as done.
  • Rename the helper function
  • Remove mention of 'out-of-line definition' from a comment
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2019, 5:50 AM
ilya-biryukov added inline comments.Aug 14 2019, 6:45 AM
clang-tools-extra/clangd/AST.cpp
106

Good point, probably too many related concepts (and even synonyms) mentioned in one function.
Renamed to getQualifier and not mentioning the out-of-line definition anymore.

With the examples, it should be clear what this function is doing.