Page MenuHomePhabricator

[clangd] Print qualifiers of out-of-line definitions in document outline
ClosedPublic

Authored by ilya-biryukov on Wed, Aug 14, 5:08 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ilya-biryukov created this revision.Wed, Aug 14, 5:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 14, 5:08 AM
hokein accepted this revision.Wed, Aug 14, 5:29 AM
hokein added inline comments.
clang-tools-extra/clangd/AST.cpp
106 ↗(On Diff #215084)

if .. out-of-line definition seems a bit confusing, I think here we just return a nested name specifier if it is written/present in the source code?

This revision is now accepted and ready to land.Wed, Aug 14, 5:29 AM
ilya-biryukov marked 2 inline comments as done.
  • Rename the helper function
  • Remove mention of 'out-of-line definition' from a comment
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 14, 5:50 AM
ilya-biryukov added inline comments.Wed, Aug 14, 6:45 AM
clang-tools-extra/clangd/AST.cpp
106 ↗(On Diff #215084)

Good point, probably too many related concepts (and even synonyms) mentioned in one function.
Renamed to getQualifier and not mentioning the out-of-line definition anymore.

With the examples, it should be clear what this function is doing.