Code is mostly copied from AArch64 port and modified where needed for Mips.
This handles the "non" legal cases of logical ops. Legal cases are handled by tablegen patterns.
Differential D6599
Add logical ops to Mips fast-isel rkotler on Dec 10 2014, 5:28 PM. Authored by
Details Code is mostly copied from AArch64 port and modified where needed for Mips. This handles the "non" legal cases of logical ops. Legal cases are handled by tablegen patterns.
Diff Detail Event TimelineComment Actions LGTM with whitespace nits and an improved test case. Currently many tests are missing and i32_test lacks any CHECK directives. There's a few more comments on this subject below.
Comment Actions This just brings the previous patch up to tip of tree. The test case will be replaced with a more complete test case and other comments from the previous review will be addressed. Comment Actions FIx nits from previous review and rerun clang-format on the result. Comment Actions Couple of inline comments. Probably want to clean up the testcase a bit (though I know you've said you're working on it). -eric
Comment Actions Finish up test case. Comment Actions Make Eric Christophers suggest change to remove the test for isVectorAllowed since this is not currently Comment Actions The code change looks right to me (assuming the answer to my main question below is 'no') but I have a couple questions and nits regarding the test case. The main question is should we optimize 'X & 0', 'X | 0', and 'X ^ 0'?
Comment Actions Haven't looked at the contents of the testcases past the general stuff, but this looks much better. One inline comment. -eric
|
Formatting nit: needs a blank line after this